[INFO] fetching crate huff_utils 0.1.0... [INFO] checking huff_utils-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate huff_utils 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate huff_utils 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate huff_utils 0.1.0 [INFO] finished tweaking crates.io crate huff_utils 0.1.0 [INFO] tweaked toml for crates.io crate huff_utils 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding phf v0.10.1 (latest: v0.11.2) [INFO] [stderr] Adding phf_generator v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_macros v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b291b5d960b2bdfda70a5aaa789f6747afa5549d689dbd889e72779ef28a442f [INFO] running `Command { std: "docker" "start" "-a" "b291b5d960b2bdfda70a5aaa789f6747afa5549d689dbd889e72779ef28a442f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b291b5d960b2bdfda70a5aaa789f6747afa5549d689dbd889e72779ef28a442f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b291b5d960b2bdfda70a5aaa789f6747afa5549d689dbd889e72779ef28a442f", kill_on_drop: false }` [INFO] [stdout] b291b5d960b2bdfda70a5aaa789f6747afa5549d689dbd889e72779ef28a442f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ee51fd7f16581bcaead3573122aaa1b194d8a85d586122b6eb05dafe26be921c [INFO] running `Command { std: "docker" "start" "-a" "ee51fd7f16581bcaead3573122aaa1b194d8a85d586122b6eb05dafe26be921c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking codemap v0.1.3 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking codemap-diagnostic v0.1.2 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking huff_utils v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | pub use crate::{ [INFO] [stdout] | _____________^ [INFO] [stdout] 51 | | abi::*, artifact::*, ast::*, bytecode::*, bytes_util::*, error::*, files::*, io::*, [INFO] [stdout] | | ------ but the name `Function` in the type namespace is also re-exported here [INFO] [stdout] 52 | | report::*, span::*, token::*, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ the name `Function` in the type namespace is first re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | pub use crate::{ [INFO] [stdout] | _____________^ [INFO] [stdout] 51 | | abi::*, artifact::*, ast::*, bytecode::*, bytes_util::*, error::*, files::*, io::*, [INFO] [stdout] | | ------ but the name `Event` in the type namespace is also re-exported here [INFO] [stdout] 52 | | report::*, span::*, token::*, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ the name `Event` in the type namespace is first re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | pub use crate::{ [INFO] [stdout] | _____________^ [INFO] [stdout] 51 | | abi::*, artifact::*, ast::*, bytecode::*, bytes_util::*, error::*, files::*, io::*, [INFO] [stdout] | | ------ but the name `Function` in the type namespace is also re-exported here [INFO] [stdout] 52 | | report::*, span::*, token::*, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ the name `Function` in the type namespace is first re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | pub use crate::{ [INFO] [stdout] | _____________^ [INFO] [stdout] 51 | | abi::*, artifact::*, ast::*, bytecode::*, bytes_util::*, error::*, files::*, io::*, [INFO] [stdout] | | ------ but the name `Event` in the type namespace is also re-exported here [INFO] [stdout] 52 | | report::*, span::*, token::*, [INFO] [stdout] 53 | | }; [INFO] [stdout] | |_____^ the name `Event` in the type namespace is first re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:146:26 [INFO] [stdout] | [INFO] [stdout] 78 | let mut functions = BTreeMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut events = BTreeMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | constructor: Some(Constructor { [INFO] [stdout] | __________________________^ [INFO] [stdout] 147 | | inputs: constructor [INFO] [stdout] 148 | | .inputs [INFO] [stdout] 149 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 155 | | .collect(), [INFO] [stdout] 156 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:97:39 [INFO] [stdout] | [INFO] [stdout] 97 | ... kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:106:39 [INFO] [stdout] | [INFO] [stdout] 106 | ... kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:133:39 [INFO] [stdout] | [INFO] [stdout] 133 | ... kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:152:31 [INFO] [stdout] | [INFO] [stdout] 152 | kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:32:39 [INFO] [stdout] | [INFO] [stdout] 32 | files.map(|x| x.unwrap().path().to_str().unwrap().to_string()).collect(); [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `huff_utils` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:146:26 [INFO] [stdout] | [INFO] [stdout] 78 | let mut functions = BTreeMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut events = BTreeMap::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | constructor: Some(Constructor { [INFO] [stdout] | __________________________^ [INFO] [stdout] 147 | | inputs: constructor [INFO] [stdout] 148 | | .inputs [INFO] [stdout] 149 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 155 | | .collect(), [INFO] [stdout] 156 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:97:39 [INFO] [stdout] | [INFO] [stdout] 97 | ... kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:106:39 [INFO] [stdout] | [INFO] [stdout] 106 | ... kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:133:39 [INFO] [stdout] | [INFO] [stdout] 133 | ... kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi.rs:152:31 [INFO] [stdout] | [INFO] [stdout] 152 | kind: argument.arg_type.clone().unwrap_or_default().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:32:39 [INFO] [stdout] | [INFO] [stdout] 32 | files.map(|x| x.unwrap().path().to_str().unwrap().to_string()).collect(); [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `huff_utils` (lib) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ee51fd7f16581bcaead3573122aaa1b194d8a85d586122b6eb05dafe26be921c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee51fd7f16581bcaead3573122aaa1b194d8a85d586122b6eb05dafe26be921c", kill_on_drop: false }` [INFO] [stdout] ee51fd7f16581bcaead3573122aaa1b194d8a85d586122b6eb05dafe26be921c