[INFO] fetching crate hudoku 0.0.1... [INFO] checking hudoku-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hudoku 0.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate hudoku 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hudoku 0.0.1 [INFO] finished tweaking crates.io crate hudoku 0.0.1 [INFO] tweaked toml for crates.io crate hudoku 0.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 284b262cacb460758e30b69c54323e174c054e2271bd7020cd98d3d6fc2f0de9 [INFO] running `Command { std: "docker" "start" "-a" "284b262cacb460758e30b69c54323e174c054e2271bd7020cd98d3d6fc2f0de9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "284b262cacb460758e30b69c54323e174c054e2271bd7020cd98d3d6fc2f0de9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "284b262cacb460758e30b69c54323e174c054e2271bd7020cd98d3d6fc2f0de9", kill_on_drop: false }` [INFO] [stdout] 284b262cacb460758e30b69c54323e174c054e2271bd7020cd98d3d6fc2f0de9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e68c3f5a68a6186f656567efab47ae0d801e07015ba41e46d160597b65b84bcf [INFO] running `Command { std: "docker" "start" "-a" "e68c3f5a68a6186f656567efab47ae0d801e07015ba41e46d160597b65b84bcf", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.43 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking hudoku v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking serde v1.0.209 [INFO] [stdout] warning: unused import: `comb` [INFO] [stdout] --> src/solver/single_digit_patterns/rectangle_elimination.rs:3:20 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::utils::{comb, NamedCellSet}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> src/solver/fish/mutant_fish.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pos` [INFO] [stdout] --> src/solver/fish/mutant_fish.rs:44:34 [INFO] [stdout] | [INFO] [stdout] 44 | let ref mut on_unselected = |pos: usize, element: usize| { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pos` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pos` [INFO] [stdout] --> src/solver/fish/mutant_fish.rs:82:38 [INFO] [stdout] | [INFO] [stdout] 82 | let ref mut on_unselected = |pos: usize, element: usize| { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pos` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `element` [INFO] [stdout] --> src/solver/fish/mutant_fish.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 82 | let ref mut on_unselected = |pos: usize, element: usize| { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_element` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cols` [INFO] [stdout] --> src/solver/single_digit_patterns/rectangle_elimination.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | cols: &[NamedCellSet], [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cols` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `skip_unselected` is never read [INFO] [stdout] --> src/utils/combination_generator.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | skip_unselected = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `candidate_cells_in_blocks` is never used [INFO] [stdout] --> src/solver.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 43 | impl SudokuSolver { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 153 | pub(crate) fn candidate_cells_in_blocks(&self, value: CellValue) -> &[NamedCellSet] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/sudoku.rs:281:19 [INFO] [stdout] | [INFO] [stdout] 280 | impl StepPosition { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 281 | pub(crate) fn new(reason: String, cell_index: CellIndex, value: CellValue) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver.rs:177:63 [INFO] [stdout] | [INFO] [stdout] 177 | .get_or_init(|| NamedCellSet::from_cellset(house, self.possible_cells(value) & house)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver.rs:270:38 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn new(sudoku: Sudoku) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let mut all_constraints = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let mut constraints_of_cell = (0..81).map(|_| vec![]).collect::>(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let mut house_union_of_cell = (0..81).map(|_| CellSet::new()).collect::>(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let mut cells_in_rows = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let mut cells_in_columns = vec![]; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let mut cells_in_blocks = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let possible_positions_for_house_and_value = vec![OnceCell::new(); 27 * 9]; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | candidate_cells_in_rows: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver.rs:271:41 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn new(sudoku: Sudoku) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let mut all_constraints = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let mut constraints_of_cell = (0..81).map(|_| vec![]).collect::>(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let mut house_union_of_cell = (0..81).map(|_| CellSet::new()).collect::>(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let mut cells_in_rows = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let mut cells_in_columns = vec![]; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let mut cells_in_blocks = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let possible_positions_for_house_and_value = vec![OnceCell::new(); 27 * 9]; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | candidate_cells_in_columns: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver.rs:272:40 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn new(sudoku: Sudoku) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let mut all_constraints = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let mut constraints_of_cell = (0..81).map(|_| vec![]).collect::>(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let mut house_union_of_cell = (0..81).map(|_| CellSet::new()).collect::>(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let mut cells_in_rows = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let mut cells_in_columns = vec![]; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let mut cells_in_blocks = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let possible_positions_for_house_and_value = vec![OnceCell::new(); 27 * 9]; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | candidate_cells_in_blocks: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver/fish/franken_fish.rs:66:54 [INFO] [stdout] | [INFO] [stdout] 66 | .filter(|&b| row_set.iter().all(|&r| (r & b).is_empty())), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hudoku` (lib) due to 6 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e68c3f5a68a6186f656567efab47ae0d801e07015ba41e46d160597b65b84bcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e68c3f5a68a6186f656567efab47ae0d801e07015ba41e46d160597b65b84bcf", kill_on_drop: false }` [INFO] [stdout] e68c3f5a68a6186f656567efab47ae0d801e07015ba41e46d160597b65b84bcf