[INFO] fetching crate httpsig 0.0.16... [INFO] checking httpsig-0.0.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate httpsig 0.0.16 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate httpsig 0.0.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate httpsig 0.0.16 [INFO] finished tweaking crates.io crate httpsig 0.0.16 [INFO] tweaked toml for crates.io crate httpsig 0.0.16 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4391f0de52b0ba423cbfc50083ea2217681facef37d8a294ec375dac22d0a950 [INFO] running `Command { std: "docker" "start" "-a" "4391f0de52b0ba423cbfc50083ea2217681facef37d8a294ec375dac22d0a950", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4391f0de52b0ba423cbfc50083ea2217681facef37d8a294ec375dac22d0a950", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4391f0de52b0ba423cbfc50083ea2217681facef37d8a294ec375dac22d0a950", kill_on_drop: false }` [INFO] [stdout] 4391f0de52b0ba423cbfc50083ea2217681facef37d8a294ec375dac22d0a950 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b4d94864940fe42bfbf210f8f85ddddf683f7a3f78ffce33ec26be7bd667199 [INFO] running `Command { std: "docker" "start" "-a" "9b4d94864940fe42bfbf210f8f85ddddf683f7a3f78ffce33ec26be7bd667199", kill_on_drop: false }` [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ed25519-compact v2.1.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking sfv v0.9.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking httpsig v0.0.16 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_component/component_param.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 82 | let hs = val [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Self(hs)) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signature_base.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 72 | let signature_params = HttpSignatureParams::try_from(v)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / Ok(( [INFO] [stdout] 84 | | signature_name.clone(), [INFO] [stdout] 85 | | Self { [INFO] [stdout] 86 | | signature_name, [INFO] [stdout] ... | [INFO] [stdout] 89 | | }, [INFO] [stdout] 90 | | )) as HttpSigResult<(String, Self)> [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:8:3 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn has_unique_elements(iter: T) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 7 | let mut uniq = rustc_hash::FxHashSet::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | iter.into_iter().all(move |x| uniq.insert(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn has_unique_elements(iter: T) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 7 | let mut uniq = rustc_hash::FxHashSet::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | iter.into_iter().all(move |x| uniq.insert(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `httpsig` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_component/component_param.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 82 | let hs = val [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Self(hs)) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signature_base.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 72 | let signature_params = HttpSignatureParams::try_from(v)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / Ok(( [INFO] [stdout] 84 | | signature_name.clone(), [INFO] [stdout] 85 | | Self { [INFO] [stdout] 86 | | signature_name, [INFO] [stdout] ... | [INFO] [stdout] 89 | | }, [INFO] [stdout] 90 | | )) as HttpSigResult<(String, Self)> [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signature_params.rs:323:18 [INFO] [stdout] | [INFO] [stdout] 323 | .map(|v| HttpMessageComponentId::try_from(v).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:8:3 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn has_unique_elements(iter: T) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 7 | let mut uniq = rustc_hash::FxHashSet::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | iter.into_iter().all(move |x| uniq.insert(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) fn has_unique_elements(iter: T) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 7 | let mut uniq = rustc_hash::FxHashSet::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | iter.into_iter().all(move |x| uniq.insert(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | .map(|&line| message_component::HttpMessageComponent::try_from(line).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|&line| message_component::HttpMessageComponent::try_from(line).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `httpsig` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "9b4d94864940fe42bfbf210f8f85ddddf683f7a3f78ffce33ec26be7bd667199", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b4d94864940fe42bfbf210f8f85ddddf683f7a3f78ffce33ec26be7bd667199", kill_on_drop: false }` [INFO] [stdout] 9b4d94864940fe42bfbf210f8f85ddddf683f7a3f78ffce33ec26be7bd667199