[INFO] fetching crate httprs 0.2.3... [INFO] checking httprs-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate httprs 0.2.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate httprs 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate httprs 0.2.3 [INFO] finished tweaking crates.io crate httprs 0.2.3 [INFO] tweaked toml for crates.io crate httprs 0.2.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate httprs 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9abc06a9500ef26e1b64e0524e80e18f7f10845fe198d96a31b96ef4ee231330 [INFO] running `Command { std: "docker" "start" "-a" "9abc06a9500ef26e1b64e0524e80e18f7f10845fe198d96a31b96ef4ee231330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9abc06a9500ef26e1b64e0524e80e18f7f10845fe198d96a31b96ef4ee231330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9abc06a9500ef26e1b64e0524e80e18f7f10845fe198d96a31b96ef4ee231330", kill_on_drop: false }` [INFO] [stdout] 9abc06a9500ef26e1b64e0524e80e18f7f10845fe198d96a31b96ef4ee231330 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65bf16ed2ad78fe921699bb6f641e1847fd22be5350500fc9625b2bc9c8bd610 [INFO] running `Command { std: "docker" "start" "-a" "65bf16ed2ad78fe921699bb6f641e1847fd22be5350500fc9625b2bc9c8bd610", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking winnow v0.6.6 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.9 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking httprs v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/http.rs:730:13 [INFO] [stdout] | [INFO] [stdout] 730 | let mut expected = String::from(BREADCRUMBS_TEMPLATE) [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/http.rs:865:13 [INFO] [stdout] | [INFO] [stdout] 865 | let text = "this is line 1\nthis is line 2\nthis is line 3"; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_text` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:532:21 [INFO] [stdout] | [INFO] [stdout] 523 | let mut file = std::fs::File::open(self.file.as_path()).expect("read file error"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:592:21 [INFO] [stdout] | [INFO] [stdout] 541 | let mut file = std::fs::File::open(self.file.as_path()).expect("read file error"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 592 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:652:11 [INFO] [stdout] | [INFO] [stdout] 642 | let socket = match std::net::UdpSocket::bind("0.0.0.0:0") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 643 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 652 | match socket.local_addr() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `test_file_size` should have an upper case name [INFO] [stdout] --> src/http.rs:702:11 [INFO] [stdout] | [INFO] [stdout] 702 | const test_file_size: u64 = 2560000; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper case: `TEST_FILE_SIZE` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:175:26 [INFO] [stdout] | [INFO] [stdout] 173 | pub(crate) fn new(notify: Receiver<()>) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Self { [INFO] [stdout] 175 | in_shutdown: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `httprs` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/http.rs:398:8 [INFO] [stdout] | [INFO] [stdout] 397 | impl Range { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 398 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:532:21 [INFO] [stdout] | [INFO] [stdout] 523 | let mut file = std::fs::File::open(self.file.as_path()).expect("read file error"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:592:21 [INFO] [stdout] | [INFO] [stdout] 541 | let mut file = std::fs::File::open(self.file.as_path()).expect("read file error"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 592 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:652:11 [INFO] [stdout] | [INFO] [stdout] 642 | let socket = match std::net::UdpSocket::bind("0.0.0.0:0") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 643 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 652 | match socket.local_addr() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:175:26 [INFO] [stdout] | [INFO] [stdout] 173 | pub(crate) fn new(notify: Receiver<()>) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Self { [INFO] [stdout] 175 | in_shutdown: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `httprs` (lib) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "65bf16ed2ad78fe921699bb6f641e1847fd22be5350500fc9625b2bc9c8bd610", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65bf16ed2ad78fe921699bb6f641e1847fd22be5350500fc9625b2bc9c8bd610", kill_on_drop: false }` [INFO] [stdout] 65bf16ed2ad78fe921699bb6f641e1847fd22be5350500fc9625b2bc9c8bd610