[INFO] fetching crate http4r-core 0.0.6... [INFO] checking http4r-core-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate http4r-core 0.0.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate http4r-core 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate http4r-core 0.0.6 [INFO] finished tweaking crates.io crate http4r-core 0.0.6 [INFO] tweaked toml for crates.io crate http4r-core 0.0.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate http4r-core 0.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d89a74ebf5816061b9c9c0bfecdf78329f59082c0616572415b027b3d08bd021 [INFO] running `Command { std: "docker" "start" "-a" "d89a74ebf5816061b9c9c0bfecdf78329f59082c0616572415b027b3d08bd021", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d89a74ebf5816061b9c9c0bfecdf78329f59082c0616572415b027b3d08bd021", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d89a74ebf5816061b9c9c0bfecdf78329f59082c0616572415b027b3d08bd021", kill_on_drop: false }` [INFO] [stdout] d89a74ebf5816061b9c9c0bfecdf78329f59082c0616572415b027b3d08bd021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 820a316ea54379057519edaa3b67ea53424f11b007f96a8b6bc93e501b32d5a5 [INFO] running `Command { std: "docker" "start" "-a" "820a316ea54379057519edaa3b67ea53424f11b007f96a8b6bc93e501b32d5a5", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking alloc-no-stdlib v2.0.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking alloc-stdlib v0.2.1 [INFO] [stderr] Checking brotli-decompressor v2.3.2 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking brotli v3.3.3 [INFO] [stderr] Checking http4r-core v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `options` is never read [INFO] [stdout] --> src/client.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 65 | options: ClientOptions, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `headers_size` and `trailers_size` are never read [INFO] [stdout] --> src/client.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | pub struct ClientOptions { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 70 | headers_size: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 71 | trailers_size: usize, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Multipart` is never constructed [INFO] [stdout] --> src/http_message.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 173 | enum ReadMetadata { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 174 | Chunked(ChunkedMetadata), [INFO] [stdout] 175 | Multipart(MultipartMetadata), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReadMetadata` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:90:43 [INFO] [stdout] | [INFO] [stdout] 87 | fn handle(self: &mut WithContentLength, req: Request, fun: F) -> () [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | where F: FnOnce(Response) -> () + Sized { [INFO] [stdout] 89 | let request = with_content_length(HttpMessage::Request(req)).to_req(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | self.next_handler.handle(request, |res| { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 91 | | fun(res) [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/http_message.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | message(part1.to_string(), part2, part3.clone().to_string(), is_response, body, headers, trailers) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_message.rs:309:8 [INFO] [stdout] | [INFO] [stdout] 264 | stream: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let (body, content_length) = match content_length { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let rest = stream.take((content_length - bytes_left_in_reader) as u64); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok((body, Headers::empty(), content_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_message.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 314 | mut stream: TcpStream, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | let body = if compression.is_some() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Ok((body, trailers, chunked_body_bytes_read)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `(String, String)` instead of cloning the inner type [INFO] [stdout] --> src/query.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | q.clone().0 == p0 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http4r-core` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `options` is never read [INFO] [stdout] --> src/client.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct Client { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 65 | options: ClientOptions, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `headers_size` and `trailers_size` are never read [INFO] [stdout] --> src/client.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | pub struct ClientOptions { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 70 | headers_size: usize, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 71 | trailers_size: usize, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Multipart` is never constructed [INFO] [stdout] --> src/http_message.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 173 | enum ReadMetadata { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 174 | Chunked(ChunkedMetadata), [INFO] [stdout] 175 | Multipart(MultipartMetadata), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReadMetadata` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:90:43 [INFO] [stdout] | [INFO] [stdout] 87 | fn handle(self: &mut WithContentLength, req: Request, fun: F) -> () [INFO] [stdout] | ------------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | where F: FnOnce(Response) -> () + Sized { [INFO] [stdout] 89 | let request = with_content_length(HttpMessage::Request(req)).to_req(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | self.next_handler.handle(request, |res| { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 91 | | fun(res) [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/http_message.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | message(part1.to_string(), part2, part3.clone().to_string(), is_response, body, headers, trailers) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_message.rs:309:8 [INFO] [stdout] | [INFO] [stdout] 264 | stream: TcpStream, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let (body, content_length) = match content_length { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let rest = stream.take((content_length - bytes_left_in_reader) as u64); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Ok((body, Headers::empty(), content_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_message.rs:336:8 [INFO] [stdout] | [INFO] [stdout] 314 | mut stream: TcpStream, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | let body = if compression.is_some() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Ok((body, trailers, chunked_body_bytes_read)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `(String, String)` instead of cloning the inner type [INFO] [stdout] --> src/query.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | q.clone().0 == p0 [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http4r-core` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "820a316ea54379057519edaa3b67ea53424f11b007f96a8b6bc93e501b32d5a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "820a316ea54379057519edaa3b67ea53424f11b007f96a8b6bc93e501b32d5a5", kill_on_drop: false }` [INFO] [stdout] 820a316ea54379057519edaa3b67ea53424f11b007f96a8b6bc93e501b32d5a5