[INFO] fetching crate http-tunnel 0.1.11... [INFO] checking http-tunnel-0.1.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate http-tunnel 0.1.11 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate http-tunnel 0.1.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate http-tunnel 0.1.11 [INFO] finished tweaking crates.io crate http-tunnel 0.1.11 [INFO] tweaked toml for crates.io crate http-tunnel 0.1.11 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate http-tunnel 0.1.11 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9eec5f81fddb9e06f260bf369326b6873afa9e319f6d73fdead6acf434d1ffe3 [INFO] running `Command { std: "docker" "start" "-a" "9eec5f81fddb9e06f260bf369326b6873afa9e319f6d73fdead6acf434d1ffe3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9eec5f81fddb9e06f260bf369326b6873afa9e319f6d73fdead6acf434d1ffe3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9eec5f81fddb9e06f260bf369326b6873afa9e319f6d73fdead6acf434d1ffe3", kill_on_drop: false }` [INFO] [stdout] 9eec5f81fddb9e06f260bf369326b6873afa9e319f6d73fdead6acf434d1ffe3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94d27e39d35fb4bb3730afc8807270b9b4b22b543903ce682b883a643e8b664d [INFO] running `Command { std: "docker" "start" "-a" "94d27e39d35fb4bb3730afc8807270b9b4b22b543903ce682b883a643e8b664d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling tokio v1.14.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling anyhow v1.0.45 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling serde_json v1.0.71 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling openssl-sys v0.9.71 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking arc-swap v0.4.8 [INFO] [stderr] Checking strum v0.19.5 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ordered-float v2.8.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tokio-macros v1.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling async-stream-impl v0.3.2 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Compiling strum_macros v0.19.4 [INFO] [stderr] Checking async-stream v0.3.2 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking futures v0.3.17 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking humantime-serde v1.0.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking log4rs v1.0.0 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking tokio-test v0.4.2 [INFO] [stderr] Checking http-tunnel v0.1.11 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:132:22 [INFO] [stdout] | [INFO] [stdout] 117 | let dns_resolver_ref = dns_resolver.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok((stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | stream.nodelay().unwrap_or_default(); [INFO] [stdout] 122 | let stream_tls_acceptor = tls_acceptor.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:157:92 [INFO] [stdout] | [INFO] [stdout] 150 | let dns_resolver_ref = dns_resolver.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok((stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | stream.nodelay().unwrap_or_default(); [INFO] [stdout] 155 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | // handle accepted connections asynchronously [INFO] [stdout] 157 | tokio::spawn(async move { tunnel_stream(&config, stream, dns_resolver_ref).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:197:27 [INFO] [stdout] | [INFO] [stdout] 175 | let dns_resolver_ref = dns_resolver.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let destination_copy = destination.clone(); [INFO] [stdout] 177 | let config_copy = config.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Ok((stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut connector: SimpleTcpConnector = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | match connector [INFO] [stdout] | ___________________________^ [INFO] [stdout] 198 | | .connect(&HttpTunnelTarget { [INFO] [stdout] 199 | | target: destination_copy, [INFO] [stdout] 200 | | nugget: None, [INFO] [stdout] 201 | | }) [INFO] [stdout] 202 | | .await [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 144 | let mode = match cli.command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let identity = ProxyConfiguration::tls_identity_from_file(pkcs12_file, password)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let tunnel_config = match config { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(ProxyConfigurationBuilder::default() [INFO] [stdout] | ____________^ [INFO] [stdout] 182 | | .bind_address(bind_address) [INFO] [stdout] 183 | | .mode(mode) [INFO] [stdout] 184 | | .tunnel_config(tunnel_config) [INFO] [stdout] 185 | | .build() [INFO] [stdout] 186 | | .expect("ProxyConfigurationBuilder failed")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 190 | let mut file = File::open(filename).map_err(|e| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Identity::from_pkcs12(&identity, password).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy_target.rs:199:19 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn new>>(v: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | Self { [INFO] [stdout] 199 | data: Arc::new(v.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 101 | handshake_codec: H, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | target_connector: T, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | client: C, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | tunnel_config: TunnelConfig, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | tunnel_request_codec: Some(handshake_codec), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 101 | handshake_codec: H, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | target_connector: T, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | client: C, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | tunnel_config: TunnelConfig, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | client: Some(client), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:302:89 [INFO] [stdout] | [INFO] [stdout] 284 | let (client_recv, client_send) = io::split(client); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let (target_recv, target_send) = io::split(target); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | tokio::spawn(async move { downstream_relay.relay_data(client_recv, target_send).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:305:87 [INFO] [stdout] | [INFO] [stdout] 284 | let (client_recv, client_send) = io::split(client); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let (target_recv, target_send) = io::split(target); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | tokio::spawn(async move { upstream_relay.relay_data(target_recv, client_send).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-tunnel` (bin "http-tunnel") due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:132:22 [INFO] [stdout] | [INFO] [stdout] 117 | let dns_resolver_ref = dns_resolver.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok((stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | stream.nodelay().unwrap_or_default(); [INFO] [stdout] 122 | let stream_tls_acceptor = tls_acceptor.clone(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:157:92 [INFO] [stdout] | [INFO] [stdout] 150 | let dns_resolver_ref = dns_resolver.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok((stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | stream.nodelay().unwrap_or_default(); [INFO] [stdout] 155 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | // handle accepted connections asynchronously [INFO] [stdout] 157 | tokio::spawn(async move { tunnel_stream(&config, stream, dns_resolver_ref).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:197:27 [INFO] [stdout] | [INFO] [stdout] 175 | let dns_resolver_ref = dns_resolver.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let destination_copy = destination.clone(); [INFO] [stdout] 177 | let config_copy = config.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Ok((stream, _)) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let mut connector: SimpleTcpConnector = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | match connector [INFO] [stdout] | ___________________________^ [INFO] [stdout] 198 | | .connect(&HttpTunnelTarget { [INFO] [stdout] 199 | | target: destination_copy, [INFO] [stdout] 200 | | nugget: None, [INFO] [stdout] 201 | | }) [INFO] [stdout] 202 | | .await [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 144 | let mode = match cli.command { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let identity = ProxyConfiguration::tls_identity_from_file(pkcs12_file, password)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let tunnel_config = match config { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(ProxyConfigurationBuilder::default() [INFO] [stdout] | ____________^ [INFO] [stdout] 182 | | .bind_address(bind_address) [INFO] [stdout] 183 | | .mode(mode) [INFO] [stdout] 184 | | .tunnel_config(tunnel_config) [INFO] [stdout] 185 | | .build() [INFO] [stdout] 186 | | .expect("ProxyConfigurationBuilder failed")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 190 | let mut file = File::open(filename).map_err(|e| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Identity::from_pkcs12(&identity, password).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy_target.rs:199:19 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn new>>(v: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | Self { [INFO] [stdout] 199 | data: Arc::new(v.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | assert_eq!(data, &buf[..timed_future.unwrap().unwrap()]) [INFO] [stdout] | ^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay.rs:321:33 [INFO] [stdout] | [INFO] [stdout] 307 | let mut mock_connection: Mock = Builder::new().read(data).build(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | let timed_future = relay_policy [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | assert_eq!(data, &buf[..timed_future.unwrap().unwrap()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 101 | handshake_codec: H, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | target_connector: T, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | client: C, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | tunnel_config: TunnelConfig, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | tunnel_request_codec: Some(handshake_codec), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 101 | handshake_codec: H, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | target_connector: T, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | client: C, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | tunnel_config: TunnelConfig, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | client: Some(client), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:302:89 [INFO] [stdout] | [INFO] [stdout] 284 | let (client_recv, client_send) = io::split(client); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let (target_recv, target_send) = io::split(target); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | tokio::spawn(async move { downstream_relay.relay_data(client_recv, target_send).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tunnel.rs:305:87 [INFO] [stdout] | [INFO] [stdout] 284 | let (client_recv, client_send) = io::split(client); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | let (target_recv, target_send) = io::split(target); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | tokio::spawn(async move { upstream_relay.relay_data(target_recv, client_send).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-tunnel` (bin "http-tunnel" test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "94d27e39d35fb4bb3730afc8807270b9b4b22b543903ce682b883a643e8b664d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94d27e39d35fb4bb3730afc8807270b9b4b22b543903ce682b883a643e8b664d", kill_on_drop: false }` [INFO] [stdout] 94d27e39d35fb4bb3730afc8807270b9b4b22b543903ce682b883a643e8b664d