[INFO] fetching crate http-signature-normalization-actix 0.11.1... [INFO] checking http-signature-normalization-actix-0.11.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate http-signature-normalization-actix 0.11.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate http-signature-normalization-actix 0.11.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate http-signature-normalization-actix 0.11.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate http-signature-normalization-actix 0.11.1 [INFO] tweaked toml for crates.io crate http-signature-normalization-actix 0.11.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate http-signature-normalization-actix 0.11.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d53c8ea2703d83d4832b5914a907fb4989fc55210b5eb1437f84c1f71499fa8 [INFO] running `Command { std: "docker" "start" "-a" "0d53c8ea2703d83d4832b5914a907fb4989fc55210b5eb1437f84c1f71499fa8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d53c8ea2703d83d4832b5914a907fb4989fc55210b5eb1437f84c1f71499fa8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d53c8ea2703d83d4832b5914a907fb4989fc55210b5eb1437f84c1f71499fa8", kill_on_drop: false }` [INFO] [stdout] 0d53c8ea2703d83d4832b5914a907fb4989fc55210b5eb1437f84c1f71499fa8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d36220f366399640e835e72dcb197c9c1824973e6ec7c058044e0841e35e99b2 [INFO] running `Command { std: "docker" "start" "-a" "d36220f366399640e835e72dcb197c9c1824973e6ec7c058044e0841e35e99b2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking http-signature-normalization v0.7.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking streem v0.2.0 [INFO] [stderr] Checking mutually_exclusive_features v0.0.3 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking actix-rt v2.9.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking actix-router v0.5.2 [INFO] [stderr] Checking actix-server v2.3.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking actix-http v3.6.0 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking actix-web v4.5.1 [INFO] [stderr] Checking tracing-actix-web v0.7.10 [INFO] [stderr] Checking http-signature-normalization-actix v0.11.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 323 | fn spawn_blocking(&self, func: Func) -> Self::Future [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | inner: actix_rt::task::spawn_blocking(func), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:343:32 [INFO] [stdout] | [INFO] [stdout] 341 | let res = std::task::ready!(std::pin::Pin::new(&mut self.inner).poll(cx)); [INFO] [stdout] | --- --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | [INFO] [stdout] 343 | std::task::Poll::Ready(res.map_err(|_| Canceled)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 61 | context: SpanTrace::capture().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:147:18 [INFO] [stdout] | [INFO] [stdout] 137 | let res = req [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 148 | | res?.await [INFO] [stdout] 149 | | .map_err(|_| VerifyError::new(&Span::current(), VerifyErrorKind::Dropped)) [INFO] [stdout] 150 | | .map(|()| DigestVerified) [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:141:46 [INFO] [stdout] | [INFO] [stdout] 141 | .ok_or_else(|| VerifyError::new(&Span::current(), VerifyErrorKind::Extension)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 137 | let res = req [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | res?.await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:149:48 [INFO] [stdout] | [INFO] [stdout] 149 | .map_err(|_| VerifyError::new(&Span::current(), VerifyErrorKind::Dropped)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:170:15 [INFO] [stdout] | [INFO] [stdout] 169 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ready(Ok(VerifyMiddleware( [INFO] [stdout] | _______________^ [INFO] [stdout] 171 | | service, [INFO] [stdout] 172 | | self.0.clone(), [INFO] [stdout] 173 | | self.1, [INFO] [stdout] 174 | | self.2.clone(), [INFO] [stdout] 175 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:218:87 [INFO] [stdout] | [INFO] [stdout] 211 | let spawner = self.1.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let digest = self.3.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | let (verify_tx, verify_rx) = oneshot::channel(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | [INFO] [stdout] 215 | let payload = req.take_payload(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | verify_payload(yielder, spawner, vec, digest, payload, verify_tx).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 265 | let bytes2 = bytes.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | let mut verify_digest2 = verify_digest.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(verify_digest2) as Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:122:23 [INFO] [stdout] | [INFO] [stdout] 121 | fn new(span: &Span, kind: VerifyErrorKind) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | span.in_scope(|| VerifyError { [INFO] [stdout] | _______________________^ [INFO] [stdout] 123 | | context: SpanTrace::capture().to_string(), [INFO] [stdout] 124 | | kind, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:123:22 [INFO] [stdout] | [INFO] [stdout] 121 | fn new(span: &Span, kind: VerifyErrorKind) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | span.in_scope(|| VerifyError { [INFO] [stdout] 123 | context: SpanTrace::capture().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 160 | span: Span, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | req: ServiceRequest, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> LocalBoxFuture<'static, Result, Error>> { [INFO] [stdout] 163 | let res = self.1.begin_verify( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Err(PrepareVerifyError::Required(mut req)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let verify_fut = unverified.verify(|signature, signing_string| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let service = Rc::clone(&self.0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 225 | | if verify_fut.instrument(span).await? { [INFO] [stdout] 226 | | req.extensions_mut().insert(SignatureVerified(key_id)); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | [INFO] [stdout] 229 | | service.call(req).await [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:229:31 [INFO] [stdout] | [INFO] [stdout] 160 | span: Span, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | req: ServiceRequest, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let verify_fut = unverified.verify(|signature, signing_string| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let service = Rc::clone(&self.0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | service.call(req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:253:46 [INFO] [stdout] | [INFO] [stdout] 253 | .ok_or_else(|| VerifyError::new(&Span::current(), VerifyErrorKind::Extension)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:253:63 [INFO] [stdout] | [INFO] [stdout] 253 | .ok_or_else(|| VerifyError::new(&Span::current(), VerifyErrorKind::Extension)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:278:15 [INFO] [stdout] | [INFO] [stdout] 277 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | ready(Ok(VerifyMiddleware( [INFO] [stdout] | _______________^ [INFO] [stdout] 279 | | Rc::new(service), [INFO] [stdout] 280 | | self.1.clone(), [INFO] [stdout] 281 | | self.2, [INFO] [stdout] 282 | | self.0.clone(), [INFO] [stdout] 283 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:327:18 [INFO] [stdout] | [INFO] [stdout] 302 | fn call(&self, req: ServiceRequest) -> Self::Future { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let span = tracing::info_span!( [INFO] [stdout] | _____________----___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | | "Signature Verification", [INFO] [stdout] 305 | | signature.kind = tracing::field::Empty, [INFO] [stdout] 306 | | signature.expected_kind = tracing::field::display(&self.2), [INFO] [stdout] 307 | | ); [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | Box::pin(self.0.call(req)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-signature-normalization-actix` (lib) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 323 | fn spawn_blocking(&self, func: Func) -> Self::Future [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | inner: actix_rt::task::spawn_blocking(func), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:343:32 [INFO] [stdout] | [INFO] [stdout] 341 | let res = std::task::ready!(std::pin::Pin::new(&mut self.inner).poll(cx)); [INFO] [stdout] | --- --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | [INFO] [stdout] 343 | std::task::Poll::Ready(res.map_err(|_| Canceled)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 61 | context: SpanTrace::capture().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:147:18 [INFO] [stdout] | [INFO] [stdout] 137 | let res = req [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 148 | | res?.await [INFO] [stdout] 149 | | .map_err(|_| VerifyError::new(&Span::current(), VerifyErrorKind::Dropped)) [INFO] [stdout] 150 | | .map(|()| DigestVerified) [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:141:46 [INFO] [stdout] | [INFO] [stdout] 141 | .ok_or_else(|| VerifyError::new(&Span::current(), VerifyErrorKind::Extension)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 137 | let res = req [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | res?.await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:149:48 [INFO] [stdout] | [INFO] [stdout] 149 | .map_err(|_| VerifyError::new(&Span::current(), VerifyErrorKind::Dropped)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:170:15 [INFO] [stdout] | [INFO] [stdout] 169 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ready(Ok(VerifyMiddleware( [INFO] [stdout] | _______________^ [INFO] [stdout] 171 | | service, [INFO] [stdout] 172 | | self.0.clone(), [INFO] [stdout] 173 | | self.1, [INFO] [stdout] 174 | | self.2.clone(), [INFO] [stdout] 175 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:218:87 [INFO] [stdout] | [INFO] [stdout] 211 | let spawner = self.1.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let digest = self.3.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | let (verify_tx, verify_rx) = oneshot::channel(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | [INFO] [stdout] 215 | let payload = req.take_payload(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | verify_payload(yielder, spawner, vec, digest, payload, verify_tx).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/digest/middleware.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 265 | let bytes2 = bytes.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | let mut verify_digest2 = verify_digest.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | Ok(verify_digest2) as Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:122:23 [INFO] [stdout] | [INFO] [stdout] 121 | fn new(span: &Span, kind: VerifyErrorKind) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | span.in_scope(|| VerifyError { [INFO] [stdout] | _______________________^ [INFO] [stdout] 123 | | context: SpanTrace::capture().to_string(), [INFO] [stdout] 124 | | kind, [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:123:22 [INFO] [stdout] | [INFO] [stdout] 121 | fn new(span: &Span, kind: VerifyErrorKind) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | span.in_scope(|| VerifyError { [INFO] [stdout] 123 | context: SpanTrace::capture().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:224:18 [INFO] [stdout] | [INFO] [stdout] 160 | span: Span, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | req: ServiceRequest, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> LocalBoxFuture<'static, Result, Error>> { [INFO] [stdout] 163 | let res = self.1.begin_verify( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Err(PrepareVerifyError::Required(mut req)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let verify_fut = unverified.verify(|signature, signing_string| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let service = Rc::clone(&self.0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 225 | | if verify_fut.instrument(span).await? { [INFO] [stdout] 226 | | req.extensions_mut().insert(SignatureVerified(key_id)); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | [INFO] [stdout] 229 | | service.call(req).await [INFO] [stdout] 230 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:229:31 [INFO] [stdout] | [INFO] [stdout] 160 | span: Span, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | req: ServiceRequest, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let verify_fut = unverified.verify(|signature, signing_string| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let service = Rc::clone(&self.0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | service.call(req).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:253:46 [INFO] [stdout] | [INFO] [stdout] 253 | .ok_or_else(|| VerifyError::new(&Span::current(), VerifyErrorKind::Extension)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:253:63 [INFO] [stdout] | [INFO] [stdout] 253 | .ok_or_else(|| VerifyError::new(&Span::current(), VerifyErrorKind::Extension)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:278:15 [INFO] [stdout] | [INFO] [stdout] 277 | fn new_transform(&self, service: S) -> Self::Future { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | ready(Ok(VerifyMiddleware( [INFO] [stdout] | _______________^ [INFO] [stdout] 279 | | Rc::new(service), [INFO] [stdout] 280 | | self.1.clone(), [INFO] [stdout] 281 | | self.2, [INFO] [stdout] 282 | | self.0.clone(), [INFO] [stdout] 283 | | ))) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/middleware.rs:327:18 [INFO] [stdout] | [INFO] [stdout] 302 | fn call(&self, req: ServiceRequest) -> Self::Future { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let span = tracing::info_span!( [INFO] [stdout] | _____________----___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 304 | | "Signature Verification", [INFO] [stdout] 305 | | signature.kind = tracing::field::Empty, [INFO] [stdout] 306 | | signature.expected_kind = tracing::field::display(&self.2), [INFO] [stdout] 307 | | ); [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | Box::pin(self.0.call(req)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-signature-normalization-actix` (lib test) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "d36220f366399640e835e72dcb197c9c1824973e6ec7c058044e0841e35e99b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d36220f366399640e835e72dcb197c9c1824973e6ec7c058044e0841e35e99b2", kill_on_drop: false }` [INFO] [stdout] d36220f366399640e835e72dcb197c9c1824973e6ec7c058044e0841e35e99b2