[INFO] fetching crate http-rate 0.1.1... [INFO] checking http-rate-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate http-rate 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate http-rate 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate http-rate 0.1.1 [INFO] finished tweaking crates.io crate http-rate 0.1.1 [INFO] tweaked toml for crates.io crate http-rate 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 464a3cd80edaed7c4fd6cb452b27499c68fe7623beb70c844920ffb61e09bef7 [INFO] running `Command { std: "docker" "start" "-a" "464a3cd80edaed7c4fd6cb452b27499c68fe7623beb70c844920ffb61e09bef7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "464a3cd80edaed7c4fd6cb452b27499c68fe7623beb70c844920ffb61e09bef7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "464a3cd80edaed7c4fd6cb452b27499c68fe7623beb70c844920ffb61e09bef7", kill_on_drop: false }` [INFO] [stdout] 464a3cd80edaed7c4fd6cb452b27499c68fe7623beb70c844920ffb61e09bef7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 316958854b480e12f5f222a18ef70b0054f0a0edf6c9ac23dd1c91b7cc7967a5 [INFO] running `Command { std: "docker" "start" "-a" "316958854b480e12f5f222a18ef70b0054f0a0edf6c9ac23dd1c91b7cc7967a5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking all_asserts v2.3.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking http-rate v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stdout] warning: trait `ShrinkableKeyedStateStore` is never used [INFO] [stdout] --> src/state/keyed.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 99 | pub(crate) trait ShrinkableKeyedStateStore: KeyedStateStore { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_older_than` is never used [INFO] [stdout] --> src/state/in_memory.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 23 | impl InMemoryState { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub(crate) fn is_older_than(&self, nanos: Nanos) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ReasonablyRealtime` is never used [INFO] [stdout] --> src/timer.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 137 | pub trait ReasonablyRealtime: Timer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stdout] warning: trait `ReasonablyRealtime` is never used [INFO] [stdout] --> src/timer.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 137 | pub trait ReasonablyRealtime: Timer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 194 | fn measure_and_replace(&self, _key: &Self::Key, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | f(None).map(|(res, _)| res) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/in_memory.rs:101:53 [INFO] [stdout] | [INFO] [stdout] 101 | let hits: u64 = threads.into_iter().map(|t| t.join().unwrap()).sum(); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timer.rs:156:36 [INFO] [stdout] | [INFO] [stdout] 151 | let clock = Arc::new(FakeRelativeClock::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let clock = Arc::clone(&clock); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | std::thread::spawn(move || { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 157 | | for _ in 0..1000000 { [INFO] [stdout] 158 | | let now = clock.now(); [INFO] [stdout] 159 | | clock.advance(Duration::from_nanos(1)); [INFO] [stdout] 160 | | assert!(clock.now() > now); [INFO] [stdout] 161 | | } [INFO] [stdout] 162 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-rate` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "316958854b480e12f5f222a18ef70b0054f0a0edf6c9ac23dd1c91b7cc7967a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "316958854b480e12f5f222a18ef70b0054f0a0edf6c9ac23dd1c91b7cc7967a5", kill_on_drop: false }` [INFO] [stdout] 316958854b480e12f5f222a18ef70b0054f0a0edf6c9ac23dd1c91b7cc7967a5