[INFO] fetching crate http-adapter-ureq 0.2.0... [INFO] checking http-adapter-ureq-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate http-adapter-ureq 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate http-adapter-ureq 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate http-adapter-ureq 0.2.0 [INFO] finished tweaking crates.io crate http-adapter-ureq 0.2.0 [INFO] tweaked toml for crates.io crate http-adapter-ureq 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 81 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding brotli-decompressor v2.5.1 (latest: v4.0.1) [INFO] [stderr] Adding cookie v0.17.0 (latest: v0.18.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding ureq v2.8.0 (latest: v2.10.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ee455f36b79e0af2482c8a7701ba103cdadb2edb651be01d9d596681f5541ce [INFO] running `Command { std: "docker" "start" "-a" "7ee455f36b79e0af2482c8a7701ba103cdadb2edb651be01d9d596681f5541ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ee455f36b79e0af2482c8a7701ba103cdadb2edb651be01d9d596681f5541ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ee455f36b79e0af2482c8a7701ba103cdadb2edb651be01d9d596681f5541ce", kill_on_drop: false }` [INFO] [stdout] 7ee455f36b79e0af2482c8a7701ba103cdadb2edb651be01d9d596681f5541ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e97982b2952e9188d903769053454bb2bf0c9edb8c727e65588188654a82d0b [INFO] running `Command { std: "docker" "start" "-a" "0e97982b2952e9188d903769053454bb2bf0c9edb8c727e65588188654a82d0b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking ureq v2.8.0 [INFO] [stderr] Checking http-adapter v0.2.0 [INFO] [stderr] Checking http-adapter-ureq v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:57 [INFO] [stdout] | [INFO] [stdout] 81 | value.to_str().map_err(|_| Error::InvalidHeaderValue(value.clone()))?, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:2 [INFO] [stdout] | [INFO] [stdout] 88 | fn to_response(res: ureq::Response) -> Result>, Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut response = Response::builder().status(status).version(version); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | response.body(body).map_err(Error::Http) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:28 [INFO] [stdout] | [INFO] [stdout] 110 | .map_err(|e| Error::Ureq(Box::new(e.into())))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:95 [INFO] [stdout] | [INFO] [stdout] 118 | async fn execute(&self, request: Request>) -> Result>, Self::Error> { [INFO] [stdout] | _____________________________-------------------------____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | | let req = from_request(&self.agent, &request)?; [INFO] [stdout] 120 | | let res = ThreadFuture::new(|send_result, recv_waker| { [INFO] [stdout] 121 | | move || { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:66 [INFO] [stdout] | [INFO] [stdout] 125 | match req.send_bytes(request.body()).map_err(|e| Error::Ureq(Box::new(e))) { [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn new(factory: Factory) -> ThreadFuture [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let (send_result, recv_result) = channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let (send_waker, recv_waker) = channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let body = factory(send_result, recv_waker); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let thread = thread::spawn(body); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ThreadFuture { [INFO] [stdout] 163 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-adapter-ureq` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:57 [INFO] [stdout] | [INFO] [stdout] 81 | value.to_str().map_err(|_| Error::InvalidHeaderValue(value.clone()))?, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:2 [INFO] [stdout] | [INFO] [stdout] 88 | fn to_response(res: ureq::Response) -> Result>, Error> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let mut response = Response::builder().status(status).version(version); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | response.body(body).map_err(Error::Http) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:28 [INFO] [stdout] | [INFO] [stdout] 110 | .map_err(|e| Error::Ureq(Box::new(e.into())))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:95 [INFO] [stdout] | [INFO] [stdout] 118 | async fn execute(&self, request: Request>) -> Result>, Self::Error> { [INFO] [stdout] | _____________________________-------------------------____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | | let req = from_request(&self.agent, &request)?; [INFO] [stdout] 120 | | let res = ThreadFuture::new(|send_result, recv_waker| { [INFO] [stdout] 121 | | move || { [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:66 [INFO] [stdout] | [INFO] [stdout] 125 | match req.send_bytes(request.body()).map_err(|e| Error::Ureq(Box::new(e))) { [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn new(factory: Factory) -> ThreadFuture [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let (send_result, recv_result) = channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let (send_waker, recv_waker) = channel(); [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let body = factory(send_result, recv_waker); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let thread = thread::spawn(body); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ThreadFuture { [INFO] [stdout] 163 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `http-adapter-ureq` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "0e97982b2952e9188d903769053454bb2bf0c9edb8c727e65588188654a82d0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e97982b2952e9188d903769053454bb2bf0c9edb8c727e65588188654a82d0b", kill_on_drop: false }` [INFO] [stdout] 0e97982b2952e9188d903769053454bb2bf0c9edb8c727e65588188654a82d0b