[INFO] fetching crate htn_planner 0.1.0... [INFO] checking htn_planner-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate htn_planner 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate htn_planner 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate htn_planner 0.1.0 [INFO] finished tweaking crates.io crate htn_planner 0.1.0 [INFO] tweaked toml for crates.io crate htn_planner 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate htn_planner 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12c6c9c24ffc0e2e7afe05952a54636bde44bc7f0d38c00fd9471fcdeb08e384 [INFO] running `Command { std: "docker" "start" "-a" "12c6c9c24ffc0e2e7afe05952a54636bde44bc7f0d38c00fd9471fcdeb08e384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12c6c9c24ffc0e2e7afe05952a54636bde44bc7f0d38c00fd9471fcdeb08e384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12c6c9c24ffc0e2e7afe05952a54636bde44bc7f0d38c00fd9471fcdeb08e384", kill_on_drop: false }` [INFO] [stdout] 12c6c9c24ffc0e2e7afe05952a54636bde44bc7f0d38c00fd9471fcdeb08e384 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68d0ec4354d7a9dfd5b8bb071efff866cd9b2dda4955e952cf5689702a289d5c [INFO] running `Command { std: "docker" "start" "-a" "68d0ec4354d7a9dfd5b8bb071efff866cd9b2dda4955e952cf5689702a289d5c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling priority-queue v1.2.2 [INFO] [stderr] Checking hashbrown v0.12.2 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking filename v0.1.1 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking htn_planner v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: named argument `depth` is not used by name [INFO] [stdout] --> src/htn/parser/statement.rs:61:49 [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {}", "", depth=self.depth)?; [INFO] [stdout] | -- ^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | | [INFO] [stdout] | this formatting argument uses named argument `depth` by position [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {depth}", "", depth=self.depth)?; [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TaskBody` [INFO] [stdout] --> src/htn/domain.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | use super::compiler::{Task, self, TaskBody}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `iter::Map` and `slice::Iter` [INFO] [stdout] --> src/htn/compiler/domain.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, slice::Iter, iter::Map}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `depth` is not used by name [INFO] [stdout] --> src/htn/parser/statement.rs:61:49 [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {}", "", depth=self.depth)?; [INFO] [stdout] | -- ^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | | [INFO] [stdout] | this formatting argument uses named argument `depth` by position [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 61 | write!(self.f, "{:>depth$}task {depth}", "", depth=self.depth)?; [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TaskBody` [INFO] [stdout] --> src/htn/domain.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | use super::compiler::{Task, self, TaskBody}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `iter::Map` and `slice::Iter` [INFO] [stdout] --> src/htn/compiler/domain.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, slice::Iter, iter::Map}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/htn/parser.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 83 | Some(Err(e)) => Err(self.lexer.next().unwrap().unwrap_err()), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `On` [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_On` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/htn/search.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | while let Some((mut current, total_plan_cost)) = open_set.pop() { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `On` should have a snake case name [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/htn/parser.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 359 | let body = Box::new(self.parse_body()?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | Ok(Stmt::Type{name, body}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `htn_planner` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/htn/parser.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 83 | Some(Err(e)) => Err(self.lexer.next().unwrap().unwrap_err()), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `On` [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_On` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/htn/search.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | while let Some((mut current, total_plan_cost)) = open_set.pop() { [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `On` should have a snake case name [INFO] [stdout] --> src/htn/parser.rs:260:75 [INFO] [stdout] | [INFO] [stdout] 260 | let variable = if self.lexer.next_if(|t| match t { Ok(Token{t:On,..})=>true,_=>false}).is_some() { [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `on` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/htn/parser.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 359 | let body = Box::new(self.parse_body()?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | Ok(Stmt::Type{name, body}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `htn_planner` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "68d0ec4354d7a9dfd5b8bb071efff866cd9b2dda4955e952cf5689702a289d5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68d0ec4354d7a9dfd5b8bb071efff866cd9b2dda4955e952cf5689702a289d5c", kill_on_drop: false }` [INFO] [stdout] 68d0ec4354d7a9dfd5b8bb071efff866cd9b2dda4955e952cf5689702a289d5c