[INFO] fetching crate htmli 0.1.3... [INFO] checking htmli-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate htmli 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate htmli 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate htmli 0.1.3 [INFO] finished tweaking crates.io crate htmli 0.1.3 [INFO] tweaked toml for crates.io crate htmli 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding docopt v0.8.3 (latest: v1.1.1) [INFO] [stderr] Adding minifier v0.0.3 (latest: v0.3.1) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.6.0 (latest: v0.11.1) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61eab5e0c59ae3a433bfa043202a8c4210738e5805d2988df3c9986741352a60 [INFO] running `Command { std: "docker" "start" "-a" "61eab5e0c59ae3a433bfa043202a8c4210738e5805d2988df3c9986741352a60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61eab5e0c59ae3a433bfa043202a8c4210738e5805d2988df3c9986741352a60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61eab5e0c59ae3a433bfa043202a8c4210738e5805d2988df3c9986741352a60", kill_on_drop: false }` [INFO] [stdout] 61eab5e0c59ae3a433bfa043202a8c4210738e5805d2988df3c9986741352a60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e9781cf0fd123707a18a90ddc9480febf9ccde9cda47c9810433797d997e3aa [INFO] running `Command { std: "docker" "start" "-a" "1e9781cf0fd123707a18a90ddc9480febf9ccde9cda47c9810433797d997e3aa", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking minifier v0.0.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking htmli v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/parser.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | try!(parse_to_string(path, file, &mut html, 0, 0)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/parser.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | let file_contents = try!(file_to_string(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/parser.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | try!(file_to_string(&mut include_file)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/parser.rs:69:35 [INFO] [stdout] | [INFO] [stdout] 69 | ... (end_offset + 1), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - (end_offset + 1), [INFO] [stdout] 69 + end_offset + 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:80:40 [INFO] [stdout] | [INFO] [stdout] 80 | let (input_path, mut input_file) = try!(open_as_file(&args.arg_file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | let mut html_str = try!(parser::parse(input_path, &mut input_file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 93 | let mut output_file = try!(create_file(output_path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | let result = try!(write_to_file(&mut output_file, html_str.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/parser.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | try!(parse_to_string(path, file, &mut html, 0, 0)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/parser.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | let file_contents = try!(file_to_string(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/parser.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | try!(file_to_string(&mut include_file)) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/parser.rs:69:35 [INFO] [stdout] | [INFO] [stdout] 69 | ... (end_offset + 1), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 69 - (end_offset + 1), [INFO] [stdout] 69 + end_offset + 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:80:40 [INFO] [stdout] | [INFO] [stdout] 80 | let (input_path, mut input_file) = try!(open_as_file(&args.arg_file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 81 | let mut html_str = try!(parser::parse(input_path, &mut input_file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 93 | let mut output_file = try!(create_file(output_path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | let result = try!(write_to_file(&mut output_file, html_str.as_bytes())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/parser.rs:48:49 [INFO] [stdout] | [INFO] [stdout] 48 | let err_str = format!("{}", err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/parser.rs:59:49 [INFO] [stdout] | [INFO] [stdout] 59 | let err_str = format!("{}", err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/parser.rs:115:41 [INFO] [stdout] | [INFO] [stdout] 115 | let err_str = format!("{}", err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:123:23 [INFO] [stdout] | [INFO] [stdout] 123 | format!("{}", err.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/parser.rs:48:49 [INFO] [stdout] | [INFO] [stdout] 48 | let err_str = format!("{}", err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/parser.rs:59:49 [INFO] [stdout] | [INFO] [stdout] 59 | let err_str = format!("{}", err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/parser.rs:115:41 [INFO] [stdout] | [INFO] [stdout] 115 | let err_str = format!("{}", err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:123:23 [INFO] [stdout] | [INFO] [stdout] 123 | format!("{}", err.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 101 | let result = File::open(path); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | if result.is_err() { return Err(desc_from_err(result)); } [INFO] [stdout] 103 | let file = result.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | Ok((path, file)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 101 | let result = File::open(path); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | if result.is_err() { return Err(desc_from_err(result)); } [INFO] [stdout] 103 | let file = result.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | Ok((path, file)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `htmli` (bin "htmli") due to 2 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `htmli` (bin "htmli" test) due to 2 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1e9781cf0fd123707a18a90ddc9480febf9ccde9cda47c9810433797d997e3aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e9781cf0fd123707a18a90ddc9480febf9ccde9cda47c9810433797d997e3aa", kill_on_drop: false }` [INFO] [stdout] 1e9781cf0fd123707a18a90ddc9480febf9ccde9cda47c9810433797d997e3aa