[INFO] fetching crate html_parse 1.1.2... [INFO] checking html_parse-1.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate html_parse 1.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate html_parse 1.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate html_parse 1.1.2 [INFO] finished tweaking crates.io crate html_parse 1.1.2 [INFO] tweaked toml for crates.io crate html_parse 1.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 63 packages to latest compatible versions [INFO] [stderr] Adding html5ever v0.26.0 (latest: v0.28.0) [INFO] [stderr] Adding markup5ever v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding phf v0.10.1 (latest: v0.11.2) [INFO] [stderr] Adding phf_codegen v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_generator v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2168b07fca43b0ae23ffab762ea1a9735d2828586082733d86af6abbd132b5db [INFO] running `Command { std: "docker" "start" "-a" "2168b07fca43b0ae23ffab762ea1a9735d2828586082733d86af6abbd132b5db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2168b07fca43b0ae23ffab762ea1a9735d2828586082733d86af6abbd132b5db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2168b07fca43b0ae23ffab762ea1a9735d2828586082733d86af6abbd132b5db", kill_on_drop: false }` [INFO] [stdout] 2168b07fca43b0ae23ffab762ea1a9735d2828586082733d86af6abbd132b5db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76025bc5625efbf60b8791546b1ee321d19347bf7e7d064ba2e5aac469ea6c83 [INFO] running `Command { std: "docker" "start" "-a" "76025bc5625efbf60b8791546b1ee321d19347bf7e7d064ba2e5aac469ea6c83", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking forest-ds v1.1.7 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Checking html_parse v1.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/node.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(name: QualName, attrs: Vec) -> Self { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let id = attrs [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let classes: IndexSet = attrs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | attrs: attrs.into_iter().map(|a| (a.name, a.value)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 58 | fn create_comment(&mut self, text: StrTendril) -> Self::Handle { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | self.tree [INFO] [stdout] 60 | .create_node(Node::Comment(Comment { comment: text })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 63 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | self.tree [INFO] [stdout] 65 | .create_node(Node::ProcessingInstruction(ProcessingInstruction { [INFO] [stdout] | __________________________^ [INFO] [stdout] 66 | | target, [INFO] [stdout] 67 | | data, [INFO] [stdout] 68 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `html_parse` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/node.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(name: QualName, attrs: Vec) -> Self { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let id = attrs [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let classes: IndexSet = attrs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | attrs: attrs.into_iter().map(|a| (a.name, a.value)).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:60:26 [INFO] [stdout] | [INFO] [stdout] 58 | fn create_comment(&mut self, text: StrTendril) -> Self::Handle { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | self.tree [INFO] [stdout] 60 | .create_node(Node::Comment(Comment { comment: text })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/html/tree_sink.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 63 | fn create_pi(&mut self, target: StrTendril, data: StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | self.tree [INFO] [stdout] 65 | .create_node(Node::ProcessingInstruction(ProcessingInstruction { [INFO] [stdout] | __________________________^ [INFO] [stdout] 66 | | target, [INFO] [stdout] 67 | | data, [INFO] [stdout] 68 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `html_parse` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "76025bc5625efbf60b8791546b1ee321d19347bf7e7d064ba2e5aac469ea6c83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76025bc5625efbf60b8791546b1ee321d19347bf7e7d064ba2e5aac469ea6c83", kill_on_drop: false }` [INFO] [stdout] 76025bc5625efbf60b8791546b1ee321d19347bf7e7d064ba2e5aac469ea6c83