[INFO] fetching crate html2pango 0.6.0...
[INFO] checking html2pango-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604
[INFO] extracting crate html2pango 0.6.0 into /workspace/builds/worker-1-tc2/source
[INFO] validating manifest of crates.io crate html2pango 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking crates.io crate html2pango 0.6.0
[INFO] finished tweaking crates.io crate html2pango 0.6.0
[INFO] tweaked toml for crates.io crate html2pango 0.6.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Updating crates.io index
[INFO] [stderr] Blocking waiting for file lock on package cache
[INFO] [stderr] Locking 75 packages to latest compatible versions
[INFO] [stderr] Adding ammonia v3.3.0 (latest: v4.0.0)
[INFO] [stderr] Adding html5ever v0.26.0 (latest: v0.28.0)
[INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2)
[INFO] [stderr] Adding linkify v0.9.0 (latest: v0.10.0)
[INFO] [stderr] Adding markup5ever v0.11.0 (latest: v0.13.0)
[INFO] [stderr] Adding markup5ever_rcdom v0.2.0 (latest: v0.3.0)
[INFO] [stderr] Adding phf v0.10.1 (latest: v0.11.2)
[INFO] [stderr] Adding phf_codegen v0.10.0 (latest: v0.11.2)
[INFO] [stderr] Adding phf_generator v0.10.0 (latest: v0.11.2)
[INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2)
[INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1)
[INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77)
[INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1)
[INFO] [stderr] Adding xml5ever v0.17.0 (latest: v0.19.0)
[INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 5671d26966bda8997ad640dcca14e685daae3f52946f6bdbe4055526a3fb0036
[INFO] running `Command { std: "docker" "start" "-a" "5671d26966bda8997ad640dcca14e685daae3f52946f6bdbe4055526a3fb0036", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "5671d26966bda8997ad640dcca14e685daae3f52946f6bdbe4055526a3fb0036", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5671d26966bda8997ad640dcca14e685daae3f52946f6bdbe4055526a3fb0036", kill_on_drop: false }`
[INFO] [stdout] 5671d26966bda8997ad640dcca14e685daae3f52946f6bdbe4055526a3fb0036
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] e8b4e47ab616332b411dc2266102512f1677a3b0d57a63690ae7cbbf0fd262ed
[INFO] running `Command { std: "docker" "start" "-a" "e8b4e47ab616332b411dc2266102512f1677a3b0d57a63690ae7cbbf0fd262ed", kill_on_drop: false }`
[INFO] [stderr] Compiling libc v0.2.158
[INFO] [stderr] Compiling byteorder v1.5.0
[INFO] [stderr] Compiling cfg-if v1.0.0
[INFO] [stderr] Compiling parking_lot_core v0.9.10
[INFO] [stderr] Compiling serde v1.0.209
[INFO] [stderr] Checking smallvec v1.13.2
[INFO] [stderr] Checking new_debug_unreachable v1.0.6
[INFO] [stderr] Checking scopeguard v1.2.0
[INFO] [stderr] Checking mac v0.1.1
[INFO] [stderr] Compiling syn v1.0.109
[INFO] [stderr] Compiling phf_shared v0.10.0
[INFO] [stderr] Compiling lock_api v0.4.12
[INFO] [stderr] Checking utf-8 v0.7.6
[INFO] [stderr] Checking precomputed-hash v0.1.1
[INFO] [stderr] Checking unicode-normalization v0.1.23
[INFO] [stderr] Checking unicode-bidi v0.3.15
[INFO] [stderr] Checking maplit v1.0.2
[INFO] [stderr] Checking linkify v0.9.0
[INFO] [stderr] Checking futf v0.1.5
[INFO] [stderr] Checking yansi v0.5.1
[INFO] [stderr] Checking diff v0.1.13
[INFO] [stderr] Checking phf v0.10.1
[INFO] [stderr] Compiling zerocopy v0.7.35
[INFO] [stderr] Checking tendril v0.4.3
[INFO] [stderr] Checking pretty_assertions v1.4.0
[INFO] [stderr] Checking parking_lot v0.12.3
[INFO] [stderr] Compiling getrandom v0.2.15
[INFO] [stderr] Checking idna v0.5.0
[INFO] [stderr] Compiling rand_core v0.6.4
[INFO] [stderr] Compiling ppv-lite86 v0.2.20
[INFO] [stderr] Checking url v2.5.2
[INFO] [stderr] Compiling rand_chacha v0.3.1
[INFO] [stderr] Compiling rand v0.8.5
[INFO] [stderr] Compiling phf_generator v0.10.0
[INFO] [stderr] Compiling string_cache_codegen v0.5.2
[INFO] [stderr] Compiling phf_codegen v0.10.0
[INFO] [stderr] Compiling markup5ever v0.11.0
[INFO] [stderr] Checking string_cache v0.8.7
[INFO] [stderr] Checking xml5ever v0.17.0
[INFO] [stderr] Compiling html5ever v0.26.0
[INFO] [stderr] Checking ammonia v3.3.0
[INFO] [stderr] Checking markup5ever_rcdom v0.2.0
[INFO] [stderr] Checking html2pango v0.6.0 (/opt/rustwide/workdir)
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/lib.rs:292:5
[INFO] [stdout] |
[INFO] [stdout] 260 | let allowed_tags = hashset![
[INFO] [stdout] | _________------------___-
[INFO] [stdout] | | |
[INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 261 | | "font", // custom to matrix for IRC-style font coloring
[INFO] [stdout] 262 | | "del", // for markdown
[INFO] [stdout] 263 | | "h1", "h2", "h3", "h4", "h5", "h6", "blockquote", "p", "a", "ul", "ol", "sup", "sub",
[INFO] [stdout] 264 | | "nl", "li", "b", "i", "u", "strong", "em", "strike", "code", "hr", "br", "div",
[INFO] [stdout] 265 | | "table", "thead", "caption", "tbody", "tr", "th", "td", "pre", "span", "img",
[INFO] [stdout] 266 | | ];
[INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 269 | let allowed_attributes = hashmap![
[INFO] [stdout] | _________------------------___-
[INFO] [stdout] | | |
[INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 270 | | // custom ones first:
[INFO] [stdout] 271 | | "font" => hashset!["color", "data-mx-bg-color", "data-mx-color", "style"],
[INFO] [stdout] | | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 272 | | "span" => hashset!["data-mx-bg-color", "data-mx-color", "style"],
[INFO] [stdout] | | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 273 | | // remote target: custom to matrix
[INFO] [stdout] 274 | | "a" => hashset!["href", "name", "target", "rel"],
[INFO] [stdout] | | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 275 | | "img" => hashset!["src", "width", "height", "alt", "title"],
[INFO] [stdout] | | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 276 | | "ol" => hashset!["start"],
[INFO] [stdout] | | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 277 | | // We don't actually allow all classes, TODO: we should filter them afterwards
[INFO] [stdout] 278 | | "code" => hashset!["class"],
[INFO] [stdout] | | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 279 | | ];
[INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 282 | let allowed_urls = hashset!["http", "https", "ftp", "mailto", "magnet"];
[INFO] [stdout] | ------------ ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] | |
[INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 292 | / markup_html(&sanitized_html)
[INFO] [stdout] 293 | | .map(|x| x.trim_matches('\n').to_string())
[INFO] [stdout] | |__________________________________________________^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order`
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: aborting due to 1 previous error
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stderr] error: could not compile `html2pango` (lib) due to 2 previous errors
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/lib.rs:292:5
[INFO] [stdout] |
[INFO] [stdout] 260 | let allowed_tags = hashset![
[INFO] [stdout] | _________------------___-
[INFO] [stdout] | | |
[INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 261 | | "font", // custom to matrix for IRC-style font coloring
[INFO] [stdout] 262 | | "del", // for markdown
[INFO] [stdout] 263 | | "h1", "h2", "h3", "h4", "h5", "h6", "blockquote", "p", "a", "ul", "ol", "sup", "sub",
[INFO] [stdout] 264 | | "nl", "li", "b", "i", "u", "strong", "em", "strike", "code", "hr", "br", "div",
[INFO] [stdout] 265 | | "table", "thead", "caption", "tbody", "tr", "th", "td", "pre", "span", "img",
[INFO] [stdout] 266 | | ];
[INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 269 | let allowed_attributes = hashmap![
[INFO] [stdout] | _________------------------___-
[INFO] [stdout] | | |
[INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 270 | | // custom ones first:
[INFO] [stdout] 271 | | "font" => hashset!["color", "data-mx-bg-color", "data-mx-color", "style"],
[INFO] [stdout] | | --------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 272 | | "span" => hashset!["data-mx-bg-color", "data-mx-color", "style"],
[INFO] [stdout] | | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 273 | | // remote target: custom to matrix
[INFO] [stdout] 274 | | "a" => hashset!["href", "name", "target", "rel"],
[INFO] [stdout] | | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 275 | | "img" => hashset!["src", "width", "height", "alt", "title"],
[INFO] [stdout] | | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 276 | | "ol" => hashset!["start"],
[INFO] [stdout] | | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 277 | | // We don't actually allow all classes, TODO: we should filter them afterwards
[INFO] [stdout] 278 | | "code" => hashset!["class"],
[INFO] [stdout] | | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 279 | | ];
[INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 282 | let allowed_urls = hashset!["http", "https", "ftp", "mailto", "magnet"];
[INFO] [stdout] | ------------ ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] | |
[INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 292 | / markup_html(&sanitized_html)
[INFO] [stdout] 293 | | .map(|x| x.trim_matches('\n').to_string())
[INFO] [stdout] | |__________________________________________________^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order`
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: aborting due to 1 previous error
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stderr] error: could not compile `html2pango` (lib test) due to 2 previous errors
[INFO] running `Command { std: "docker" "inspect" "e8b4e47ab616332b411dc2266102512f1677a3b0d57a63690ae7cbbf0fd262ed", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e8b4e47ab616332b411dc2266102512f1677a3b0d57a63690ae7cbbf0fd262ed", kill_on_drop: false }`
[INFO] [stdout] e8b4e47ab616332b411dc2266102512f1677a3b0d57a63690ae7cbbf0fd262ed