[INFO] fetching crate hpk 0.3.12... [INFO] checking hpk-0.3.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hpk 0.3.12 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hpk 0.3.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hpk 0.3.12 [INFO] finished tweaking crates.io crate hpk 0.3.12 [INFO] tweaked toml for crates.io crate hpk 0.3.12 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate hpk 0.3.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e51a9b1eafdd3970ad876f2683b49b049f165a80eab861f72e0471b2b46d3d75 [INFO] running `Command { std: "docker" "start" "-a" "e51a9b1eafdd3970ad876f2683b49b049f165a80eab861f72e0471b2b46d3d75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e51a9b1eafdd3970ad876f2683b49b049f165a80eab861f72e0471b2b46d3d75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e51a9b1eafdd3970ad876f2683b49b049f165a80eab861f72e0471b2b46d3d75", kill_on_drop: false }` [INFO] [stdout] e51a9b1eafdd3970ad876f2683b49b049f165a80eab861f72e0471b2b46d3d75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4cecd84712b19fdfd49d8cdbee8a58bebf2aa6deea480bb4ff63b17e46048760 [INFO] running `Command { std: "docker" "start" "-a" "4cecd84712b19fdfd49d8cdbee8a58bebf2aa6deea480bb4ff63b17e46048760", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling zstd-safe v6.0.6 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking lz4-compress v0.1.1 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Compiling zstd-sys v2.0.8+zstd.1.5.5 [INFO] [stderr] Checking zstd v0.12.4 [INFO] [stderr] Checking hpk v0.3.12 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk/compress.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 69 | let mut enc = flate2::write::ZlibEncoder::new(vec![], flate2::Compression::best()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | io::copy(&mut chunk, &mut enc)?; [INFO] [stdout] 71 | match enc.finish() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk/walk.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn walk>(file: P) -> HpkResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let file = file.as_ref().to_path_buf(); [INFO] [stdout] 15 | let (mut f, _tempdir) = { [INFO] [stdout] | - -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut f = File::open(&file)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let tempdir = tempfile::Builder::new().prefix("hpk").tempdir()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut out = File::create(&tmpfile)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(HpkIter { [INFO] [stdout] | ________^ [INFO] [stdout] 60 | | file, [INFO] [stdout] 61 | | f, [INFO] [stdout] 62 | | compressed: _tempdir.is_some(), [INFO] [stdout] ... | [INFO] [stdout] 67 | | stack_list: vec![], [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hpk` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `PrintState` is never used [INFO] [stdout] --> src/hpk/read.rs:203:11 [INFO] [stdout] | [INFO] [stdout] 203 | trait PrintState { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk/compress.rs:71:15 [INFO] [stdout] | [INFO] [stdout] 69 | let mut enc = flate2::write::ZlibEncoder::new(vec![], flate2::Compression::best()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | io::copy(&mut chunk, &mut enc)?; [INFO] [stdout] 71 | match enc.finish() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hpk/walk.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn walk>(file: P) -> HpkResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let file = file.as_ref().to_path_buf(); [INFO] [stdout] 15 | let (mut f, _tempdir) = { [INFO] [stdout] | - -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut f = File::open(&file)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let tempdir = tempfile::Builder::new().prefix("hpk").tempdir()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let mut out = File::create(&tmpfile)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(HpkIter { [INFO] [stdout] | ________^ [INFO] [stdout] 60 | | file, [INFO] [stdout] 61 | | f, [INFO] [stdout] 62 | | compressed: _tempdir.is_some(), [INFO] [stdout] ... | [INFO] [stdout] 67 | | stack_list: vec![], [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hpk` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4cecd84712b19fdfd49d8cdbee8a58bebf2aa6deea480bb4ff63b17e46048760", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cecd84712b19fdfd49d8cdbee8a58bebf2aa6deea480bb4ff63b17e46048760", kill_on_drop: false }` [INFO] [stdout] 4cecd84712b19fdfd49d8cdbee8a58bebf2aa6deea480bb4ff63b17e46048760