[INFO] fetching crate hornet 0.1.0... [INFO] checking hornet-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hornet 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate hornet 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hornet 0.1.0 [INFO] finished tweaking crates.io crate hornet 0.1.0 [INFO] tweaked toml for crates.io crate hornet 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v0.7.0 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding flate2 v0.2.20 (latest: v1.0.33) [INFO] [stderr] Adding hdrsample v4.0.0 (latest: v6.0.4) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding memmap v0.5.2 (latest: v0.7.0) [INFO] [stderr] Adding nix v0.8.1 (latest: v0.29.0) [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 38a2af09672496cc2fa99a6406221deead3a6c7fef7dc8da7a536d7a26fcd80f [INFO] running `Command { std: "docker" "start" "-a" "38a2af09672496cc2fa99a6406221deead3a6c7fef7dc8da7a536d7a26fcd80f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "38a2af09672496cc2fa99a6406221deead3a6c7fef7dc8da7a536d7a26fcd80f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38a2af09672496cc2fa99a6406221deead3a6c7fef7dc8da7a536d7a26fcd80f", kill_on_drop: false }` [INFO] [stdout] 38a2af09672496cc2fa99a6406221deead3a6c7fef7dc8da7a536d7a26fcd80f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6980d09b70aa10bd31cc9e56225b24afb0e009e4efdaa933453ea35bccaceb79 [INFO] running `Command { std: "docker" "start" "-a" "6980d09b70aa10bd31cc9e56225b24afb0e009e4efdaa933453ea35bccaceb79", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking memmap v0.5.2 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Compiling miniz-sys v0.1.12 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking hdrsample v4.0.0 [INFO] [stderr] Checking hornet v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/client/mod.rs:148:1 [INFO] [stdout] | [INFO] [stdout] 148 | / bitflags! { [INFO] [stdout] 149 | | /// Flags used to modify how a client exports metrics [INFO] [stdout] 150 | | pub struct MMVFlags: u32 { [INFO] [stdout] 151 | | /// Metric names aren't prefixed with MMV filename [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/client/mod.rs:148:1 [INFO] [stdout] | [INFO] [stdout] 148 | / bitflags! { [INFO] [stdout] 149 | | /// Flags used to modify how a client exports metrics [INFO] [stdout] 150 | | pub struct MMVFlags: u32 { [INFO] [stdout] 151 | | /// Metric names aren't prefixed with MMV filename [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/client/mod.rs:148:1 [INFO] [stdout] | [INFO] [stdout] 148 | / bitflags! { [INFO] [stdout] 149 | | /// Flags used to modify how a client exports metrics [INFO] [stdout] 150 | | pub struct MMVFlags: u32 { [INFO] [stdout] 151 | | /// Metric names aren't prefixed with MMV filename [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/client/mod.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / lazy_static! { [INFO] [stdout] 93 | | static ref RE: Regex = [INFO] [stdout] 94 | | Regex::new("(?-u)^(PCP_[[:alnum:]_]+)=([^\"\'].*[^\"\'])\n$") [INFO] [stdout] 95 | | .unwrap(); [INFO] [stdout] 96 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/client/metric/mod.rs:539:1 [INFO] [stdout] | [INFO] [stdout] 539 | / lazy_static! { [INFO] [stdout] 540 | | static ref SCRATCH_VIEW: MmapViewSync = { [INFO] [stdout] 541 | | Mmap::anonymous(STRING_BLOCK_LEN as usize, Protection::ReadWrite).unwrap() [INFO] [stdout] 542 | | .into_view_sync() [INFO] [stdout] 543 | | }; [INFO] [stdout] 544 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/client/mod.rs:148:1 [INFO] [stdout] | [INFO] [stdout] 148 | / bitflags! { [INFO] [stdout] 149 | | /// Flags used to modify how a client exports metrics [INFO] [stdout] 150 | | pub struct MMVFlags: u32 { [INFO] [stdout] 151 | | /// Metric names aren't prefixed with MMV filename [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/client/mod.rs:148:1 [INFO] [stdout] | [INFO] [stdout] 148 | / bitflags! { [INFO] [stdout] 149 | | /// Flags used to modify how a client exports metrics [INFO] [stdout] 150 | | pub struct MMVFlags: u32 { [INFO] [stdout] 151 | | /// Metric names aren't prefixed with MMV filename [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/client/mod.rs:148:1 [INFO] [stdout] | [INFO] [stdout] 148 | / bitflags! { [INFO] [stdout] 149 | | /// Flags used to modify how a client exports metrics [INFO] [stdout] 150 | | pub struct MMVFlags: u32 { [INFO] [stdout] 151 | | /// Metric names aren't prefixed with MMV filename [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:226:46 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn export(&self, metrics: &mut [&mut MMVWriter]) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 226 | pub fn export(&self, metrics: &mut [&mut dyn MMVWriter]) -> io::Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/client/mod.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / lazy_static! { [INFO] [stdout] 93 | | static ref RE: Regex = [INFO] [stdout] 94 | | Regex::new("(?-u)^(PCP_[[:alnum:]_]+)=([^\"\'].*[^\"\'])\n$") [INFO] [stdout] 95 | | .unwrap(); [INFO] [stdout] 96 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/client/metric/mod.rs:539:1 [INFO] [stdout] | [INFO] [stdout] 539 | / lazy_static! { [INFO] [stdout] 540 | | static ref SCRATCH_VIEW: MmapViewSync = { [INFO] [stdout] 541 | | Mmap::anonymous(STRING_BLOCK_LEN as usize, Protection::ReadWrite).unwrap() [INFO] [stdout] 542 | | .into_view_sync() [INFO] [stdout] 543 | | }; [INFO] [stdout] 544 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/mod.rs:226:46 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn export(&self, metrics: &mut [&mut MMVWriter]) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 226 | pub fn export(&self, metrics: &mut [&mut dyn MMVWriter]) -> io::Result<()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/metric/mod.rs:1355:39 [INFO] [stdout] | [INFO] [stdout] 1355 | let mut mmv_writers: Vec<&mut MMVWriter> = metrics.iter_mut() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1355 | let mut mmv_writers: Vec<&mut dyn MMVWriter> = metrics.iter_mut() [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/client/metric/mod.rs:1356:32 [INFO] [stdout] | [INFO] [stdout] 1356 | .map(|m| m as &mut MMVWriter) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1356 | .map(|m| m as &mut dyn MMVWriter) [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:569:12 [INFO] [stdout] | [INFO] [stdout] 552 | name: &str, init_val: T, sem: Semantics, unit: Unit, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | Ok(Metric { [INFO] [stdout] | ____________^ [INFO] [stdout] 570 | | name: name.to_owned(), [INFO] [stdout] 571 | | item: item, [INFO] [stdout] 572 | | sem: sem, [INFO] [stdout] ... | [INFO] [stdout] 578 | | mmap_view: unsafe { SCRATCH_VIEW.clone() } [INFO] [stdout] 579 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:732:12 [INFO] [stdout] | [INFO] [stdout] 706 | init_val: T, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 712 | let mut vals = HashMap::with_capacity(indom.instances.len()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | let mut metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 732 | Ok(InstanceMetric { [INFO] [stdout] | ____________^ [INFO] [stdout] 733 | | indom: indom.clone(), [INFO] [stdout] 734 | | vals: vals, [INFO] [stdout] 735 | | metric: metric [INFO] [stdout] 736 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:757:41 [INFO] [stdout] | [INFO] [stdout] 756 | pub fn set_val(&mut self, instance: &str, new_val: T) -> Option> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 757 | self.vals.get_mut(instance).map(|i| { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 758 | | new_val.write(unsafe { &mut i.mmap_view.as_mut_slice() })?; [INFO] [stdout] 759 | | i.val = new_val; [INFO] [stdout] 760 | | Ok(()) [INFO] [stdout] 761 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:1006:8 [INFO] [stdout] | [INFO] [stdout] 1003 | fn three_way_split(view: MmapViewSync, mid_idx: usize, mid_len: usize) -> io::Result<(MmapViewSync, MmapViewSync, MmapViewSync)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1004 | let (left_view, mid_right_view) = view.split_at(mid_idx).unwrap(); [INFO] [stdout] | --------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1005 | let (mid_view, right_view) = mid_right_view.split_at(mid_len).unwrap(); [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1006 | Ok((left_view, mid_view, right_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/counter.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 16 | let metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Counter { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | metric: metric, [INFO] [stdout] 27 | | init_val: init_val [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/gauge.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 16 | let metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Gauge { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | metric: metric, [INFO] [stdout] 27 | | init_val: init_val [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/timer.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 36 | let metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Timer { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | metric: metric, [INFO] [stdout] 47 | | time_scale: time_scale, [INFO] [stdout] 48 | | start_time: None [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/countvector.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 43 | let indom = Indom::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut im = InstanceMetric::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(CountVector { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | im: im, [INFO] [stdout] 66 | | indom: indom, [INFO] [stdout] 67 | | init_vals: init_vals [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/gaugevector.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 20 | let indom = Indom::new(instances, &indom_helptext, &indom_helptext)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let im = InstanceMetric::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(GaugeVector { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | im: im, [INFO] [stdout] 34 | | indom: indom, [INFO] [stdout] 35 | | init_val: init_val [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/histogram.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 75 | let indom = Indom::new(HIST_INSTANCES, &indom_helptext, &indom_helptext).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | let im = InstanceMetric::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(Histogram { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | im: im, [INFO] [stdout] 92 | | indom: indom, [INFO] [stdout] 93 | | histogram: histogram [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hornet` (lib) due to 11 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:569:12 [INFO] [stdout] | [INFO] [stdout] 552 | name: &str, init_val: T, sem: Semantics, unit: Unit, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | Ok(Metric { [INFO] [stdout] | ____________^ [INFO] [stdout] 570 | | name: name.to_owned(), [INFO] [stdout] 571 | | item: item, [INFO] [stdout] 572 | | sem: sem, [INFO] [stdout] ... | [INFO] [stdout] 578 | | mmap_view: unsafe { SCRATCH_VIEW.clone() } [INFO] [stdout] 579 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:732:12 [INFO] [stdout] | [INFO] [stdout] 706 | init_val: T, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 712 | let mut vals = HashMap::with_capacity(indom.instances.len()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | let mut metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 732 | Ok(InstanceMetric { [INFO] [stdout] | ____________^ [INFO] [stdout] 733 | | indom: indom.clone(), [INFO] [stdout] 734 | | vals: vals, [INFO] [stdout] 735 | | metric: metric [INFO] [stdout] 736 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:757:41 [INFO] [stdout] | [INFO] [stdout] 756 | pub fn set_val(&mut self, instance: &str, new_val: T) -> Option> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 757 | self.vals.get_mut(instance).map(|i| { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 758 | | new_val.write(unsafe { &mut i.mmap_view.as_mut_slice() })?; [INFO] [stdout] 759 | | i.val = new_val; [INFO] [stdout] 760 | | Ok(()) [INFO] [stdout] 761 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/mod.rs:1006:8 [INFO] [stdout] | [INFO] [stdout] 1003 | fn three_way_split(view: MmapViewSync, mid_idx: usize, mid_len: usize) -> io::Result<(MmapViewSync, MmapViewSync, MmapViewSync)> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1004 | let (left_view, mid_right_view) = view.split_at(mid_idx).unwrap(); [INFO] [stdout] | --------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1005 | let (mid_view, right_view) = mid_right_view.split_at(mid_len).unwrap(); [INFO] [stdout] | -------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1006 | Ok((left_view, mid_view, right_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/counter.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 16 | let metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Counter { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | metric: metric, [INFO] [stdout] 27 | | init_val: init_val [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/gauge.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 16 | let metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok(Gauge { [INFO] [stdout] | ____________^ [INFO] [stdout] 26 | | metric: metric, [INFO] [stdout] 27 | | init_val: init_val [INFO] [stdout] 28 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/timer.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 36 | let metric = Metric::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Timer { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | metric: metric, [INFO] [stdout] 47 | | time_scale: time_scale, [INFO] [stdout] 48 | | start_time: None [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/countvector.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 43 | let indom = Indom::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut im = InstanceMetric::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(CountVector { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | im: im, [INFO] [stdout] 66 | | indom: indom, [INFO] [stdout] 67 | | init_vals: init_vals [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/gaugevector.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 20 | let indom = Indom::new(instances, &indom_helptext, &indom_helptext)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let im = InstanceMetric::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(GaugeVector { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | im: im, [INFO] [stdout] 34 | | indom: indom, [INFO] [stdout] 35 | | init_val: init_val [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/metric/histogram.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 75 | let indom = Indom::new(HIST_INSTANCES, &indom_helptext, &indom_helptext).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | let im = InstanceMetric::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Ok(Histogram { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | im: im, [INFO] [stdout] 92 | | indom: indom, [INFO] [stdout] 93 | | histogram: histogram [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hornet` (lib test) due to 11 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6980d09b70aa10bd31cc9e56225b24afb0e009e4efdaa933453ea35bccaceb79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6980d09b70aa10bd31cc9e56225b24afb0e009e4efdaa933453ea35bccaceb79", kill_on_drop: false }` [INFO] [stdout] 6980d09b70aa10bd31cc9e56225b24afb0e009e4efdaa933453ea35bccaceb79