[INFO] fetching crate hornbeam_grammar 0.0.4... [INFO] checking hornbeam_grammar-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hornbeam_grammar 0.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate hornbeam_grammar 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hornbeam_grammar 0.0.4 [INFO] finished tweaking crates.io crate hornbeam_grammar 0.0.4 [INFO] tweaked toml for crates.io crate hornbeam_grammar 0.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.3.8 (latest: v0.8.11) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe5f0174805c77972bf292388f53be6705551932453a83e444a3e39b6a43fa2b [INFO] running `Command { std: "docker" "start" "-a" "fe5f0174805c77972bf292388f53be6705551932453a83e444a3e39b6a43fa2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe5f0174805c77972bf292388f53be6705551932453a83e444a3e39b6a43fa2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe5f0174805c77972bf292388f53be6705551932453a83e444a3e39b6a43fa2b", kill_on_drop: false }` [INFO] [stdout] fe5f0174805c77972bf292388f53be6705551932453a83e444a3e39b6a43fa2b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 756ba7a7ad4980e9c72dc000e7226ccf869bf14c7086ac996ceab12484fe556b [INFO] running `Command { std: "docker" "start" "-a" "756ba7a7ad4980e9c72dc000e7226ccf869bf14c7086ac996ceab12484fe556b", kill_on_drop: false }` [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Compiling pest_consume_macros v1.1.0 [INFO] [stderr] Checking pest_consume v1.1.3 [INFO] [stderr] Checking arc-interner v0.7.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking hornbeam_grammar v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:10 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn intern(s: impl Into) -> IStr { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | IStr(ArcIntern::new(s.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:300:20 [INFO] [stdout] | [INFO] [stdout] 299 | ... let node = Node::new_with_user_data(primary, ud.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | ... Ok(match node.as_rule() { [INFO] [stdout] | ______________^ [INFO] [stdout] 301 | | ... Rule::IntLiteral => Expression::IntLiteral { val: node.as_str().parse().map_err(|e| error(&format!("can't parse int: {e:?}"), n... [INFO] [stdout] 302 | | ... Rule::String => Expression::StringExpr(HornbeamParser::String(node)?), [INFO] [stdout] 303 | | ... Rule::Variable => HornbeamParser::Variable(node)?, [INFO] [stdout] 304 | | ... Rule::FunctionCall => HornbeamParser::FunctionCall(node)?, [INFO] [stdout] 305 | | ... other => unimplemented!("unimp primary {other:?}!"), [INFO] [stdout] 306 | | ... })}) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:307:38 [INFO] [stdout] | [INFO] [stdout] 307 | .map_prefix(|op, rhs| Ok(match op.as_rule() { [INFO] [stdout] | ______________________________---_____^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | | Rule::negation => Expression::Negate { sub: Box::new(rhs?) }, [INFO] [stdout] 309 | | other => unimplemented!("unimp prefix {other:?}!"), [INFO] [stdout] 310 | | })) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:311:42 [INFO] [stdout] | [INFO] [stdout] 311 | .map_infix(|lhs, op, rhs| Ok(match op.as_rule() { [INFO] [stdout] | _________________________---______---_____^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | | Rule::add => Expression::Add { left: Box::new(lhs?), right: Box::new(rhs?) }, [INFO] [stdout] 313 | | Rule::sub => Expression::Sub { left: Box::new(lhs?), right: Box::new(rhs?) }, [INFO] [stdout] 314 | | Rule::mul => Expression::Mul { left: Box::new(lhs?), right: Box::new(rhs?) }, [INFO] [stdout] ... | [INFO] [stdout] 324 | | other => unimplemented!("unimp infix {other:?}!"), [INFO] [stdout] 325 | | })) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 326 | .map_postfix(|lhs, op| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | let node = Node::new_with_user_data(op, ud.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let loc = nodeloc(&node); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Ok(match node.as_rule() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 330 | | Rule::unwrap => unimplemented!("unimp unwrap"), [INFO] [stdout] 331 | | Rule::FieldLookup => { [INFO] [stdout] 332 | | let ident = intern(node.into_children().single()?.as_str()); [INFO] [stdout] ... | [INFO] [stdout] 342 | | other => unimplemented!("unimp postfix {other:?}!"), [INFO] [stdout] 343 | | })}) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:497:12 [INFO] [stdout] | [INFO] [stdout] 496 | fn helper_block<'a>(input: Node) -> PCResult> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 497 | Ok(match input.as_rule() { [INFO] [stdout] | ____________^ [INFO] [stdout] 498 | | Rule::Element => Some(HornbeamParser::Element(input)?), [INFO] [stdout] 499 | | Rule::Text => Some(HornbeamParser::Text(input)?), [INFO] [stdout] 500 | | Rule::RawUnescapedHtml => Some(HornbeamParser::RawUnescapedHtml(input)?), [INFO] [stdout] ... | [INFO] [stdout] 507 | | other => unimplemented!("unimp rule {other:?}"), [INFO] [stdout] 508 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hornbeam_grammar` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:10 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn intern(s: impl Into) -> IStr { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | IStr(ArcIntern::new(s.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:300:20 [INFO] [stdout] | [INFO] [stdout] 299 | ... let node = Node::new_with_user_data(primary, ud.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | ... Ok(match node.as_rule() { [INFO] [stdout] | ______________^ [INFO] [stdout] 301 | | ... Rule::IntLiteral => Expression::IntLiteral { val: node.as_str().parse().map_err(|e| error(&format!("can't parse int: {e:?}"), n... [INFO] [stdout] 302 | | ... Rule::String => Expression::StringExpr(HornbeamParser::String(node)?), [INFO] [stdout] 303 | | ... Rule::Variable => HornbeamParser::Variable(node)?, [INFO] [stdout] 304 | | ... Rule::FunctionCall => HornbeamParser::FunctionCall(node)?, [INFO] [stdout] 305 | | ... other => unimplemented!("unimp primary {other:?}!"), [INFO] [stdout] 306 | | ... })}) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:307:38 [INFO] [stdout] | [INFO] [stdout] 307 | .map_prefix(|op, rhs| Ok(match op.as_rule() { [INFO] [stdout] | ______________________________---_____^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 308 | | Rule::negation => Expression::Negate { sub: Box::new(rhs?) }, [INFO] [stdout] 309 | | other => unimplemented!("unimp prefix {other:?}!"), [INFO] [stdout] 310 | | })) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:311:42 [INFO] [stdout] | [INFO] [stdout] 311 | .map_infix(|lhs, op, rhs| Ok(match op.as_rule() { [INFO] [stdout] | _________________________---______---_____^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | | Rule::add => Expression::Add { left: Box::new(lhs?), right: Box::new(rhs?) }, [INFO] [stdout] 313 | | Rule::sub => Expression::Sub { left: Box::new(lhs?), right: Box::new(rhs?) }, [INFO] [stdout] 314 | | Rule::mul => Expression::Mul { left: Box::new(lhs?), right: Box::new(rhs?) }, [INFO] [stdout] ... | [INFO] [stdout] 324 | | other => unimplemented!("unimp infix {other:?}!"), [INFO] [stdout] 325 | | })) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:329:20 [INFO] [stdout] | [INFO] [stdout] 326 | .map_postfix(|lhs, op| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | let node = Node::new_with_user_data(op, ud.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let loc = nodeloc(&node); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Ok(match node.as_rule() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 330 | | Rule::unwrap => unimplemented!("unimp unwrap"), [INFO] [stdout] 331 | | Rule::FieldLookup => { [INFO] [stdout] 332 | | let ident = intern(node.into_children().single()?.as_str()); [INFO] [stdout] ... | [INFO] [stdout] 342 | | other => unimplemented!("unimp postfix {other:?}!"), [INFO] [stdout] 343 | | })}) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:497:12 [INFO] [stdout] | [INFO] [stdout] 496 | fn helper_block<'a>(input: Node) -> PCResult> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 497 | Ok(match input.as_rule() { [INFO] [stdout] | ____________^ [INFO] [stdout] 498 | | Rule::Element => Some(HornbeamParser::Element(input)?), [INFO] [stdout] 499 | | Rule::Text => Some(HornbeamParser::Text(input)?), [INFO] [stdout] 500 | | Rule::RawUnescapedHtml => Some(HornbeamParser::RawUnescapedHtml(input)?), [INFO] [stdout] ... | [INFO] [stdout] 507 | | other => unimplemented!("unimp rule {other:?}"), [INFO] [stdout] 508 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hornbeam_grammar` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "756ba7a7ad4980e9c72dc000e7226ccf869bf14c7086ac996ceab12484fe556b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "756ba7a7ad4980e9c72dc000e7226ccf869bf14c7086ac996ceab12484fe556b", kill_on_drop: false }` [INFO] [stdout] 756ba7a7ad4980e9c72dc000e7226ccf869bf14c7086ac996ceab12484fe556b