[INFO] fetching crate hop 0.1.12... [INFO] checking hop-0.1.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hop 0.1.12 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate hop 0.1.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hop 0.1.12 [INFO] finished tweaking crates.io crate hop 0.1.12 [INFO] tweaked toml for crates.io crate hop 0.1.12 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate hop 0.1.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `reqwest` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ad7367fd8d98a9ad46f601d64ca3183376cb890a2f18087f748884b04447b75 [INFO] running `Command { std: "docker" "start" "-a" "2ad7367fd8d98a9ad46f601d64ca3183376cb890a2f18087f748884b04447b75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ad7367fd8d98a9ad46f601d64ca3183376cb890a2f18087f748884b04447b75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ad7367fd8d98a9ad46f601d64ca3183376cb890a2f18087f748884b04447b75", kill_on_drop: false }` [INFO] [stdout] 2ad7367fd8d98a9ad46f601d64ca3183376cb890a2f18087f748884b04447b75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b761d3996bc296c29fd20b81228d4325fff6f730a370c9258d4dab3f854ea44 [INFO] running `Command { std: "docker" "start" "-a" "1b761d3996bc296c29fd20b81228d4325fff6f730a370c9258d4dab3f854ea44", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `reqwest` dependency) [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling rustls v0.21.7 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Compiling hop v0.1.12 (/opt/rustwide/workdir) [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking webpki-roots v0.25.2 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking rustls-webpki v0.101.6 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking serde v1.0.188 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-rustls v0.24.1 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stdout] warning: field `success` is never read [INFO] [stdout] --> src/client/http/types.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Base { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 9 | pub success: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Base` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 82 | let http = Arc::new(Client::new(options.token, options.api_url)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let users = users::Users::new(http.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let projects = projects::Projects::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let registry = registry::Registry::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let channels = channels::Channels::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let ignite = ignite::Ignite::new(http.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let webhooks = webhooks::Webhooks::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | users, [INFO] [stdout] 93 | | projects, [INFO] [stdout] 94 | | registry, [INFO] [stdout] ... | [INFO] [stdout] 97 | | webhooks, [INFO] [stdout] 98 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 21 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | client: AsyncClient::builder() [INFO] [stdout] 40 | | .user_agent(ua) [INFO] [stdout] 41 | | .default_headers(headers.clone()) [INFO] [stdout] ... | [INFO] [stdout] 44 | | auth_type: AuthType::from_token(token), [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http/response.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 18 | pub const fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self { data: Some(data) } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes/channels/mod.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | || (Method::POST, format!("/channels?project={project}")), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes/channels/mod.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | |name| (Method::PUT, format!("/channels/{name}?project={project}")), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes/channels/tokens/mod.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn new(http: Http) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { http: http.clone() } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `success` is never read [INFO] [stdout] --> src/client/http/types.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Base { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 9 | pub success: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Base` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 82 | let http = Arc::new(Client::new(options.token, options.api_url)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let users = users::Users::new(http.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let projects = projects::Projects::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let registry = registry::Registry::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let channels = channels::Channels::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let ignite = ignite::Ignite::new(http.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let webhooks = webhooks::Webhooks::new(http.clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | [INFO] [stdout] 91 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | users, [INFO] [stdout] 93 | | projects, [INFO] [stdout] 94 | | registry, [INFO] [stdout] ... | [INFO] [stdout] 97 | | webhooks, [INFO] [stdout] 98 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 21 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | client: AsyncClient::builder() [INFO] [stdout] 40 | | .user_agent(ua) [INFO] [stdout] 41 | | .default_headers(headers.clone()) [INFO] [stdout] ... | [INFO] [stdout] 44 | | auth_type: AuthType::from_token(token), [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/http/response.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 18 | pub const fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self { data: Some(data) } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes/channels/mod.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | || (Method::POST, format!("/channels?project={project}")), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes/channels/mod.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | |name| (Method::PUT, format!("/channels/{name}?project={project}")), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes/channels/tokens/mod.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn new(http: Http) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self { http: http.clone() } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hop` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hop` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1b761d3996bc296c29fd20b81228d4325fff6f730a370c9258d4dab3f854ea44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b761d3996bc296c29fd20b81228d4325fff6f730a370c9258d4dab3f854ea44", kill_on_drop: false }` [INFO] [stdout] 1b761d3996bc296c29fd20b81228d4325fff6f730a370c9258d4dab3f854ea44