[INFO] fetching crate hone 0.0.1... [INFO] checking hone-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hone 0.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate hone 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hone 0.0.1 [INFO] finished tweaking crates.io crate hone 0.0.1 [INFO] tweaked toml for crates.io crate hone 0.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate hone 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] df9a71ab0884525e5ce67563e80928b35a817382445d42d4187f41b7a82cc8a6 [INFO] running `Command { std: "docker" "start" "-a" "df9a71ab0884525e5ce67563e80928b35a817382445d42d4187f41b7a82cc8a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "df9a71ab0884525e5ce67563e80928b35a817382445d42d4187f41b7a82cc8a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df9a71ab0884525e5ce67563e80928b35a817382445d42d4187f41b7a82cc8a6", kill_on_drop: false }` [INFO] [stdout] df9a71ab0884525e5ce67563e80928b35a817382445d42d4187f41b7a82cc8a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06e644bd82dadb99e299bc37c9b68119cdbe2dea6d271233ee342c6b6b4521e0 [INFO] running `Command { std: "docker" "start" "-a" "06e644bd82dadb99e299bc37c9b68119cdbe2dea6d271233ee342c6b6b4521e0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.7 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking trackable v0.2.23 [INFO] [stderr] Compiling syn-mid v0.4.0 [INFO] [stderr] Compiling rustversion v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling proc-macro-error v0.4.4 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.3 [INFO] [stderr] Compiling structopt-derive v0.4.0 [INFO] [stderr] Checking structopt v0.3.7 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking serde_json v1.0.44 [INFO] [stderr] Checking hone v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `study_name` is never read [INFO] [stdout] --> src/study.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct StudyServer { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 74 | study_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StudyServer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/study.rs:285:5 [INFO] [stdout] | [INFO] [stdout] 284 | pub struct TrialHandle { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 285 | id: Uuid, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `TrialHandle` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `handle` is never read [INFO] [stdout] --> src/run.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 80 | struct Trial { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 81 | child: Child, [INFO] [stdout] 82 | handle: TrialHandle, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Trial` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metric.rs:12:56 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(optimizer: T) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Self(Box::new(optimizer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `study_name` is never read [INFO] [stdout] --> src/study.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct StudyServer { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 74 | study_name: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StudyServer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/study.rs:285:5 [INFO] [stdout] | [INFO] [stdout] 284 | pub struct TrialHandle { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 285 | id: Uuid, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `TrialHandle` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 41 | let my_journal = track!(OpenOptions::new() [INFO] [stdout] | _____________----------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | | .create_new(true) [INFO] [stdout] 43 | | .write(true) [INFO] [stdout] 44 | | .open(dir.join(thread_id.to_string())) [INFO] [stdout] 45 | | .map_err(Error::from))?; [INFO] [stdout] | |__________________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let subscriber = track!(self.subscribe(study_name))?; [INFO] [stdout] | ---------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(PubSubChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 48 | | my_journal: JournalWriter::new(my_journal), [INFO] [stdout] 49 | | subscriber, [INFO] [stdout] 50 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `handle` is never read [INFO] [stdout] --> src/run.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 80 | struct Trial { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 81 | child: Child, [INFO] [stdout] 82 | handle: TrialHandle, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Trial` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 124 | fn new(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Self { [INFO] [stdout] 126 | file: BufWriter::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:147:19 [INFO] [stdout] | [INFO] [stdout] 145 | fn new(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Self { [INFO] [stdout] 147 | file: BufReader::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metric.rs:12:56 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(optimizer: T) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Self(Box::new(optimizer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 41 | let my_journal = track!(OpenOptions::new() [INFO] [stdout] | _____________----------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | | .create_new(true) [INFO] [stdout] 43 | | .write(true) [INFO] [stdout] 44 | | .open(dir.join(thread_id.to_string())) [INFO] [stdout] 45 | | .map_err(Error::from))?; [INFO] [stdout] | |__________________________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let subscriber = track!(self.subscribe(study_name))?; [INFO] [stdout] | ---------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Ok(PubSubChannel { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 48 | | my_journal: JournalWriter::new(my_journal), [INFO] [stdout] 49 | | subscriber, [INFO] [stdout] 50 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/study.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 28 | let addr = track!( [INFO] [stdout] | ____________________- [INFO] [stdout] 29 | | env::var(ENV_VAR_SERVER_ADDR).map_err(Error::from), [INFO] [stdout] 30 | | "name={}", [INFO] [stdout] 31 | | ENV_VAR_SERVER_ADDR [INFO] [stdout] 32 | | )?; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let addr: SocketAddr = track!(addr.parse().map_err(Error::from))?; [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let socket = track!(UdpSocket::bind("127.0.0.1:0").map_err(Error::from))?; [INFO] [stdout] | ------ ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 36 | | server: addr, [INFO] [stdout] 37 | | socket, [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 124 | fn new(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Self { [INFO] [stdout] 126 | file: BufWriter::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubsub.rs:147:19 [INFO] [stdout] | [INFO] [stdout] 145 | fn new(file: File) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Self { [INFO] [stdout] 147 | file: BufReader::new(file), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/study.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 265 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | let command = Command::StartTrial { reply: tx }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | let _ = self.tx.send(command); [INFO] [stdout] 268 | let id = track!(rx.recv().map_err(Error::from))?; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | env::set_var("HONE_TRIAL_ID", id.to_string()); [INFO] [stdout] 270 | Ok(TrialHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 271 | | id, [INFO] [stdout] 272 | | tx: self.tx.clone(), [INFO] [stdout] 273 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/study.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 28 | let addr = track!( [INFO] [stdout] | ____________________- [INFO] [stdout] 29 | | env::var(ENV_VAR_SERVER_ADDR).map_err(Error::from), [INFO] [stdout] 30 | | "name={}", [INFO] [stdout] 31 | | ENV_VAR_SERVER_ADDR [INFO] [stdout] 32 | | )?; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let addr: SocketAddr = track!(addr.parse().map_err(Error::from))?; [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let socket = track!(UdpSocket::bind("127.0.0.1:0").map_err(Error::from))?; [INFO] [stdout] | ------ ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 36 | | server: addr, [INFO] [stdout] 37 | | socket, [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trial.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 23 | let a: HashSet<&str> = self.metrics.keys().map(|x| x.as_str()).collect(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let b: HashSet<&str> = other.metrics.keys().map(|x| x.as_str()).collect(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let intersection: HashSet<&str> = a.intersection(&b).copied().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / self.last_metrics() [INFO] [stdout] 31 | | .filter(|x| intersection.contains(x.0)) [INFO] [stdout] 32 | | .zip(other.last_metrics().filter(|x| intersection.contains(x.0))) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/study.rs:270:12 [INFO] [stdout] | [INFO] [stdout] 265 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | let command = Command::StartTrial { reply: tx }; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | let _ = self.tx.send(command); [INFO] [stdout] 268 | let id = track!(rx.recv().map_err(Error::from))?; [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | env::set_var("HONE_TRIAL_ID", id.to_string()); [INFO] [stdout] 270 | Ok(TrialHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 271 | | id, [INFO] [stdout] 272 | | tx: self.tx.clone(), [INFO] [stdout] 273 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | let client = track!(StudyClient::new())?; [INFO] [stdout] | ------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Ok(Self { opt, client }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / #[structopt(long, default_value = "MINIMIZE")] [INFO] [stdout] 19 | | pub direction: Direction, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | let client = track!(StudyClient::new())?; [INFO] [stdout] | ------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(Self { opt, client }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trial.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 23 | let a: HashSet<&str> = self.metrics.keys().map(|x| x.as_str()).collect(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let b: HashSet<&str> = other.metrics.keys().map(|x| x.as_str()).collect(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let intersection: HashSet<&str> = a.intersection(&b).copied().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / self.last_metrics() [INFO] [stdout] 31 | | .filter(|x| intersection.contains(x.0)) [INFO] [stdout] 32 | | .zip(other.last_metrics().filter(|x| intersection.contains(x.0))) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/get.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | let client = track!(StudyClient::new())?; [INFO] [stdout] | ------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Ok(Self { opt, client }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trials.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 15 | let data_dir = track!(config.data_dir())?; [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut pubsub = PubSub::new(data_dir); [INFO] [stdout] 17 | let mut subscriber = track!(pubsub.subscribe(&opt.study_name))?; [INFO] [stdout] | ---------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(trials.into_iter().map(|(_, v)| v).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / #[structopt(long, default_value = "MINIMIZE")] [INFO] [stdout] 19 | | pub direction: Direction, [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/report.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 43 | let client = track!(StudyClient::new())?; [INFO] [stdout] | ------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Ok(Self { opt, client }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trials.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 15 | let data_dir = track!(config.data_dir())?; [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut pubsub = PubSub::new(data_dir); [INFO] [stdout] 17 | let mut subscriber = track!(pubsub.subscribe(&opt.study_name))?; [INFO] [stdout] | ---------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | Ok(trials.into_iter().map(|(_, v)| v).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | fn from(f: Failure) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ErrorKind::Other.takes_over(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | fn from(f: Failure) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ErrorKind::Other.takes_over(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(f: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ErrorKind::IoError.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 39 | fn from(f: std::sync::PoisonError) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ErrorKind::Other.cause(f.to_string()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(f: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ErrorKind::IoError.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 39 | fn from(f: std::sync::PoisonError) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ErrorKind::Other.cause(f.to_string()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hone` (lib test) due to 16 previous errors; 3 warnings emitted [INFO] [stdout] error: aborting due to 15 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hone` (lib) due to 16 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "06e644bd82dadb99e299bc37c9b68119cdbe2dea6d271233ee342c6b6b4521e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06e644bd82dadb99e299bc37c9b68119cdbe2dea6d271233ee342c6b6b4521e0", kill_on_drop: false }` [INFO] [stdout] 06e644bd82dadb99e299bc37c9b68119cdbe2dea6d271233ee342c6b6b4521e0