[INFO] fetching crate holochain_tracing 0.0.24... [INFO] checking holochain_tracing-0.0.24 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate holochain_tracing 0.0.24 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate holochain_tracing 0.0.24 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate holochain_tracing 0.0.24 [INFO] finished tweaking crates.io crate holochain_tracing 0.0.24 [INFO] tweaked toml for crates.io crate holochain_tracing 0.0.24 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate holochain_tracing 0.0.24 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5052bb8e65cea983e0880f68b0f222114f68c0e42ebbedbcbea046dc01fe0038 [INFO] running `Command { std: "docker" "start" "-a" "5052bb8e65cea983e0880f68b0f222114f68c0e42ebbedbcbea046dc01fe0038", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5052bb8e65cea983e0880f68b0f222114f68c0e42ebbedbcbea046dc01fe0038", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5052bb8e65cea983e0880f68b0f222114f68c0e42ebbedbcbea046dc01fe0038", kill_on_drop: false }` [INFO] [stdout] 5052bb8e65cea983e0880f68b0f222114f68c0e42ebbedbcbea046dc01fe0038 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 99334e90d32ec67cf038940e8e40c19994f99ab78ea7a882c034e079645d2f50 [INFO] running `Command { std: "docker" "start" "-a" "99334e90d32ec67cf038940e8e40c19994f99ab78ea7a882c034e079645d2f50", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling cc v1.0.46 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling protobuf v2.10.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.10 [INFO] [stderr] Compiling prometheus v0.7.0 [INFO] [stderr] Checking regex-syntax v0.6.16 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking crossbeam-channel v0.3.8 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking integer-encoding v1.1.4 [INFO] [stderr] Compiling either v1.5.3 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking hostname v0.1.5 [INFO] [stderr] Compiling itertools v0.8.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking tracing-log v0.1.1 [INFO] [stderr] Checking sharded-slab v0.0.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking thrift v0.13.0 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking gag v0.1.10 [INFO] [stderr] Compiling trackable_derive v0.1.2 [INFO] [stderr] Checking trackable v0.2.23 [INFO] [stderr] Checking thrift_codec v0.1.1 [INFO] [stderr] Checking rustracing v0.2.1 [INFO] [stderr] Checking rustracing_jaeger v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling pin-project-internal v0.4.8 [INFO] [stderr] Compiling tracing-attributes v0.1.7 [INFO] [stderr] Compiling shrinkwraprs v0.3.0 [INFO] [stderr] Checking tracing v0.1.13 [INFO] [stderr] Checking pin-project v0.4.8 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking tracing-serde v0.1.1 [INFO] [stderr] Checking serde_json v1.0.47 [INFO] [stderr] Checking opentelemetry v0.2.0 [INFO] [stderr] Checking opentelemetry-jaeger v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.2.3 [INFO] [stderr] Checking holochain_tracing v0.0.24 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn send_wrapped(&self, v: T) -> Result<(), cb::SendError>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | self.0.send(SpanWrap::new(v, context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn send_wrapped(&self, v: T) -> Result<(), cb::SendError>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | self.0.send(SpanWrap::new(v, context).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 53 | tx: SpanSender, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | val: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match tx.send_wrapped(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn event>>(&mut self, msg: S) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.0.log(|l| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 31 | | l.std().event(msg); [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn error>>(&mut self, kind: S, msg: S) { [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | self.0.log(|l| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 37 | | l.error().kind(kind).message(msg); [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn child>>(&self, operation_name: S) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.0.child(operation_name, |o| o.start()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn follower>>(&self, operation_name: S) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | self.0.follower(operation_name, |o| o.start()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_context.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 32 | operation_name: S, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> HSpan { [INFO] [stdout] 34 | / tracer [INFO] [stdout] 35 | | .span(operation_name) [INFO] [stdout] 36 | | .follows_from(&self.0) [INFO] [stdout] 37 | | .start() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_context.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 44 | operation_name: N, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | f(tracer.span(operation_name).follows_from(&self.0)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 36 | operation_name: S, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .map(|context| context.follower(tracer, operation_name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 46 | operation_name: S, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> HSpan { [INFO] [stdout] 48 | self.follower(tracer, operation_name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 55 | operation_name: N, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | .map(|context| context.follower_(tracer, operation_name, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn map(self, f: F) -> SpanWrap [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | data: f(self.data), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn map(self, f: F) -> EncodedSpanWrap [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | data: f(self.data), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn test_wrap(t: T) -> SpanWrap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | test_span().wrap(t) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn test_wrap_enc(t: T) -> EncodedSpanWrap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | test_span().wrap(t).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:100:32 [INFO] [stdout] | [INFO] [stdout] 100 | SPANSTACK.with(|stack| stack.borrow_mut().prune(self.index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/stack.rs:106:31 [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!(msg), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!("{}", msg), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn push_span_with Span>(f: F) -> Option { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let maybe_guard = SPANSTACK [INFO] [stdout] 124 | .with(|stack| stack.borrow_mut().top().map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn with_top A>(f: F) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | SPANSTACK.with(|stack| stack.borrow_mut().top().map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:134:28 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn with_top A>(f: F) -> Option { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | SPANSTACK.with(|stack| stack.borrow_mut().top().map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn with_top_or_null A>(f: F) -> A { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | SPANSTACK.with(|stack| match stack.borrow_mut().top() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 140 | | Some(top) => f(top), [INFO] [stdout] 141 | | None => { [INFO] [stdout] 142 | | handle_empty_stack("Using with_top but the span stack is empty! Using noop span."); [INFO] [stdout] 143 | | f(&mut Span::noop()) [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:139:34 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn with_top_or_null A>(f: F) -> A { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | SPANSTACK.with(|stack| match stack.borrow_mut().top() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:150:20 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn top_follower>>(name: S) -> Span { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | SPANSTACK.with(|stack| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 151 | | stack [INFO] [stdout] 152 | | .borrow_mut() [INFO] [stdout] 153 | | .top() [INFO] [stdout] ... | [INFO] [stdout] 158 | | }) [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn top_follower>>(name: S) -> Span { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | SPANSTACK.with(|stack| { [INFO] [stdout] 151 | / stack [INFO] [stdout] 152 | | .borrow_mut() [INFO] [stdout] 153 | | .top() [INFO] [stdout] 154 | | .map(|s| s.follower(name)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:163:28 [INFO] [stdout] | [INFO] [stdout] 163 | SPANSTACK.with(|stack| stack.borrow().is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer_console.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 9 | let (span_tx, span_rx) = crossbeam_channel::bounded(1000); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let tracer = Tracer::with_sender(AllSampler, span_tx); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | (tracer, ConsoleReporter::new(span_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:79:22 [INFO] [stdout] | [INFO] [stdout] 78 | fn wrap_with_tag_inner(data: T, name: String, tag: Option) -> SpanWrap { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | with_top_or_null(|top| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 80 | | let child: Span = top [INFO] [stdout] 81 | | .follower_(name, |options| { [INFO] [stdout] 82 | | if let Some(tag) = tag { [INFO] [stdout] ... | [INFO] [stdout] 89 | | child.wrap(data) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 27 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holochain_tracing` (lib) due to 28 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn send_wrapped(&self, v: T) -> Result<(), cb::SendError>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | self.0.send(SpanWrap::new(v, context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn send_wrapped(&self, v: T) -> Result<(), cb::SendError>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | self.0.send(SpanWrap::new(v, context).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 53 | tx: SpanSender, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | val: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | match tx.send_wrapped(val) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn event>>(&mut self, msg: S) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | self.0.log(|l| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 31 | | l.std().event(msg); [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn error>>(&mut self, kind: S, msg: S) { [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | self.0.log(|l| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 37 | | l.error().kind(kind).message(msg); [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn child>>(&self, operation_name: S) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | self.0.child(operation_name, |o| o.start()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn follower>>(&self, operation_name: S) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | self.0.follower(operation_name, |o| o.start()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_context.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 32 | operation_name: S, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> HSpan { [INFO] [stdout] 34 | / tracer [INFO] [stdout] 35 | | .span(operation_name) [INFO] [stdout] 36 | | .follows_from(&self.0) [INFO] [stdout] 37 | | .start() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_context.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 44 | operation_name: N, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | f(tracer.span(operation_name).follows_from(&self.0)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 36 | operation_name: S, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .map(|context| context.follower(tracer, operation_name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 46 | operation_name: S, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | ) -> HSpan { [INFO] [stdout] 48 | self.follower(tracer, operation_name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 55 | operation_name: N, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | .map(|context| context.follower_(tracer, operation_name, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn map(self, f: F) -> SpanWrap [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | data: f(self.data), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn map(self, f: F) -> EncodedSpanWrap [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | data: f(self.data), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn test_wrap(t: T) -> SpanWrap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | test_span().wrap(t) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/span_wrap.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn test_wrap_enc(t: T) -> EncodedSpanWrap { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | test_span().wrap(t).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:100:32 [INFO] [stdout] | [INFO] [stdout] 100 | SPANSTACK.with(|stack| stack.borrow_mut().prune(self.index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/stack.rs:106:31 [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!(msg), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 106 | Mode::Panic => panic!("{}", msg), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:124:23 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn push_span_with Span>(f: F) -> Option { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let maybe_guard = SPANSTACK [INFO] [stdout] 124 | .with(|stack| stack.borrow_mut().top().map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:134:20 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn with_top A>(f: F) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | SPANSTACK.with(|stack| stack.borrow_mut().top().map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:134:28 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn with_top A>(f: F) -> Option { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | SPANSTACK.with(|stack| stack.borrow_mut().top().map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn with_top_or_null A>(f: F) -> A { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | SPANSTACK.with(|stack| match stack.borrow_mut().top() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 140 | | Some(top) => f(top), [INFO] [stdout] 141 | | None => { [INFO] [stdout] 142 | | handle_empty_stack("Using with_top but the span stack is empty! Using noop span."); [INFO] [stdout] 143 | | f(&mut Span::noop()) [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:139:34 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn with_top_or_null A>(f: F) -> A { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | SPANSTACK.with(|stack| match stack.borrow_mut().top() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:150:20 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn top_follower>>(name: S) -> Span { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | SPANSTACK.with(|stack| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 151 | | stack [INFO] [stdout] 152 | | .borrow_mut() [INFO] [stdout] 153 | | .top() [INFO] [stdout] ... | [INFO] [stdout] 158 | | }) [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn top_follower>>(name: S) -> Span { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | SPANSTACK.with(|stack| { [INFO] [stdout] 151 | / stack [INFO] [stdout] 152 | | .borrow_mut() [INFO] [stdout] 153 | | .top() [INFO] [stdout] 154 | | .map(|s| s.follower(name)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:163:28 [INFO] [stdout] | [INFO] [stdout] 163 | SPANSTACK.with(|stack| stack.borrow().is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 171 | fn with_stack A>(f: F) -> A { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | SPANSTACK.with(|s| f(&mut s.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stack.rs:172:35 [INFO] [stdout] | [INFO] [stdout] 171 | fn with_stack A>(f: F) -> A { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | SPANSTACK.with(|s| f(&mut s.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracer_console.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 9 | let (span_tx, span_rx) = crossbeam_channel::bounded(1000); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let tracer = Tracer::with_sender(AllSampler, span_tx); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | (tracer, ConsoleReporter::new(span_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:79:22 [INFO] [stdout] | [INFO] [stdout] 78 | fn wrap_with_tag_inner(data: T, name: String, tag: Option) -> SpanWrap { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | with_top_or_null(|top| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 80 | | let child: Span = top [INFO] [stdout] 81 | | .follower_(name, |options| { [INFO] [stdout] 82 | | if let Some(tag) = tag { [INFO] [stdout] ... | [INFO] [stdout] 89 | | child.wrap(data) [INFO] [stdout] 90 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holochain_tracing` (lib test) due to 30 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "99334e90d32ec67cf038940e8e40c19994f99ab78ea7a882c034e079645d2f50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99334e90d32ec67cf038940e8e40c19994f99ab78ea7a882c034e079645d2f50", kill_on_drop: false }` [INFO] [stdout] 99334e90d32ec67cf038940e8e40c19994f99ab78ea7a882c034e079645d2f50