[INFO] fetching crate holochain_logging 0.0.7... [INFO] checking holochain_logging-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate holochain_logging 0.0.7 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate holochain_logging 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate holochain_logging 0.0.7 [INFO] finished tweaking crates.io crate holochain_logging 0.0.7 [INFO] tweaked toml for crates.io crate holochain_logging 0.0.7 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate holochain_logging 0.0.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 885b244189f2ace93658d6c537bf976536b4daed4e80c221dc37e6757be49a54 [INFO] running `Command { std: "docker" "start" "-a" "885b244189f2ace93658d6c537bf976536b4daed4e80c221dc37e6757be49a54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "885b244189f2ace93658d6c537bf976536b4daed4e80c221dc37e6757be49a54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "885b244189f2ace93658d6c537bf976536b4daed4e80c221dc37e6757be49a54", kill_on_drop: false }` [INFO] [stdout] 885b244189f2ace93658d6c537bf976536b4daed4e80c221dc37e6757be49a54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4848f5fca34c31d16c2f98e4dbdd7d8fdc9f47785245d45616d01aa752a46687 [INFO] running `Command { std: "docker" "start" "-a" "4848f5fca34c31d16c2f98e4dbdd7d8fdc9f47785245d45616d01aa752a46687", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling regex v1.1.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking utf8-ranges v1.0.4 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking colored v1.7.0 [INFO] [stderr] Checking crossbeam-channel v0.3.8 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking toml v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking holochain_logging v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `shutdown` is never used [INFO] [stdout] --> src/lib.rs:683:8 [INFO] [stdout] | [INFO] [stdout] 681 | trait LogMessageTrait: Send { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 682 | fn build(&self) -> String; [INFO] [stdout] 683 | fn shutdown(&mut self); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 403 | Ok(logger.unwrap().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:547:12 [INFO] [stdout] | [INFO] [stdout] 470 | let (s, r): (Sender, Receiver) = crossbeam_channel::bounded(self.channel_size); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 471 | [INFO] [stdout] 472 | let logger = FastLogger { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 481 | let handle = match log::set_boxed_logger(Box::new(logger)) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 493 | let mut buffer = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 499 | let file_stream = std::fs::OpenOptions::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 522 | let mut buffer = io::BufWriter::new(io::stderr()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | Ok(FastLogger { [INFO] [stdout] | ____________^ [INFO] [stdout] 548 | | level: self.level, [INFO] [stdout] 549 | | rule_filters: self.rule_filters.to_owned(), [INFO] [stdout] 550 | | level_colors: self.level_colors, [INFO] [stdout] ... | [INFO] [stdout] 553 | | handle: Some(handle), [INFO] [stdout] 554 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:781:15 [INFO] [stdout] | [INFO] [stdout] 769 | let rule_filters: Vec = logger [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 781 | ..FastLoggerBuilder::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holochain_logging` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `shutdown` is never used [INFO] [stdout] --> src/lib.rs:683:8 [INFO] [stdout] | [INFO] [stdout] 681 | trait LogMessageTrait: Send { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 682 | fn build(&self) -> String; [INFO] [stdout] 683 | fn shutdown(&mut self); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 403 | Ok(logger.unwrap().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:547:12 [INFO] [stdout] | [INFO] [stdout] 470 | let (s, r): (Sender, Receiver) = crossbeam_channel::bounded(self.channel_size); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 471 | [INFO] [stdout] 472 | let logger = FastLogger { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 481 | let handle = match log::set_boxed_logger(Box::new(logger)) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 493 | let mut buffer = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 499 | let file_stream = std::fs::OpenOptions::new() [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 522 | let mut buffer = io::BufWriter::new(io::stderr()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | Ok(FastLogger { [INFO] [stdout] | ____________^ [INFO] [stdout] 548 | | level: self.level, [INFO] [stdout] 549 | | rule_filters: self.rule_filters.to_owned(), [INFO] [stdout] 550 | | level_colors: self.level_colors, [INFO] [stdout] ... | [INFO] [stdout] 553 | | handle: Some(handle), [INFO] [stdout] 554 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:781:15 [INFO] [stdout] | [INFO] [stdout] 769 | let rule_filters: Vec = logger [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 781 | ..FastLoggerBuilder::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holochain_logging` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4848f5fca34c31d16c2f98e4dbdd7d8fdc9f47785245d45616d01aa752a46687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4848f5fca34c31d16c2f98e4dbdd7d8fdc9f47785245d45616d01aa752a46687", kill_on_drop: false }` [INFO] [stdout] 4848f5fca34c31d16c2f98e4dbdd7d8fdc9f47785245d45616d01aa752a46687