[INFO] fetching crate holder_derive 0.14.0... [INFO] checking holder_derive-0.14.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate holder_derive 0.14.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate holder_derive 0.14.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate holder_derive 0.14.0 [INFO] finished tweaking crates.io crate holder_derive 0.14.0 [INFO] tweaked toml for crates.io crate holder_derive 0.14.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6bc503172ee3545486f5354a516f858b1a13731caad4eaebee186e6f7f80be4a [INFO] running `Command { std: "docker" "start" "-a" "6bc503172ee3545486f5354a516f858b1a13731caad4eaebee186e6f7f80be4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6bc503172ee3545486f5354a516f858b1a13731caad4eaebee186e6f7f80be4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bc503172ee3545486f5354a516f858b1a13731caad4eaebee186e6f7f80be4a", kill_on_drop: false }` [INFO] [stdout] 6bc503172ee3545486f5354a516f858b1a13731caad4eaebee186e6f7f80be4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f3e817cade91153062dfd886a0289510ffab0d342946773c471535727d3dc173 [INFO] running `Command { std: "docker" "start" "-a" "f3e817cade91153062dfd886a0289510ffab0d342946773c471535727d3dc173", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking holder_derive v0.14.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `parse_quote` [INFO] [stdout] --> src/lib.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | parse_macro_input, parse_quote, parse_str, punctuated::Punctuated, token::Comma, Attribute, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parse_quote` [INFO] [stdout] --> src/lib.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | parse_macro_input, parse_quote, parse_str, punctuated::Punctuated, token::Comma, Attribute, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 73 | let mut holder_trait_name_in_attr: Option = None; [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let field_name = field [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let field_type_ident = get_ident_by_type(&field.ty); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let field_type = &field.ty; [INFO] [stdout] 95 | let holder_trait_name = holder_trait_name_in_attr [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let field_type_name: Ident = parse_str(type_name.as_str()).unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let fn_name: Ident = parse_str(fn_name.as_str()).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let mut_fn_name = format!("{}_mut", fn_name.to_string()); [INFO] [stdout] 103 | let mut_fn_name: Ident = parse_str(mut_fn_name.as_str()).unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let field_bounds = get_generic_by_type(field_type); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Some( [INFO] [stdout] 106 | / quote! { [INFO] [stdout] 107 | | impl<#struct_generic> [INFO] [stdout] 108 | | #holder_trait_name<#field_bounds> for #struct_name<#struct_generic_without_bounds> #struct_where_clause { [INFO] [stdout] 109 | | fn #fn_name<'__a: '__b, '__b>(&'__a self) -> &'__b #field_type_name<#field_bounds> { [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] 117 | | .into(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:34 [INFO] [stdout] | [INFO] [stdout] 96 | .or_else(|| Some(parse_str(format!("{}{HOLDER_SUFFIX}", field_type_ident).as_str()).unwrap())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holder_derive` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 73 | let mut holder_trait_name_in_attr: Option = None; [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let field_name = field [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let field_type_ident = get_ident_by_type(&field.ty); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let field_type = &field.ty; [INFO] [stdout] 95 | let holder_trait_name = holder_trait_name_in_attr [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let field_type_name: Ident = parse_str(type_name.as_str()).unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let fn_name: Ident = parse_str(fn_name.as_str()).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let mut_fn_name = format!("{}_mut", fn_name.to_string()); [INFO] [stdout] 103 | let mut_fn_name: Ident = parse_str(mut_fn_name.as_str()).unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let field_bounds = get_generic_by_type(field_type); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Some( [INFO] [stdout] 106 | / quote! { [INFO] [stdout] 107 | | impl<#struct_generic> [INFO] [stdout] 108 | | #holder_trait_name<#field_bounds> for #struct_name<#struct_generic_without_bounds> #struct_where_clause { [INFO] [stdout] 109 | | fn #fn_name<'__a: '__b, '__b>(&'__a self) -> &'__b #field_type_name<#field_bounds> { [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] 117 | | .into(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:34 [INFO] [stdout] | [INFO] [stdout] 96 | .or_else(|| Some(parse_str(format!("{}{HOLDER_SUFFIX}", field_type_ident).as_str()).unwrap())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `holder_derive` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f3e817cade91153062dfd886a0289510ffab0d342946773c471535727d3dc173", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3e817cade91153062dfd886a0289510ffab0d342946773c471535727d3dc173", kill_on_drop: false }` [INFO] [stdout] f3e817cade91153062dfd886a0289510ffab0d342946773c471535727d3dc173