[INFO] fetching crate hoi4save 0.3.4... [INFO] checking hoi4save-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hoi4save 0.3.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate hoi4save 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hoi4save 0.3.4 [INFO] finished tweaking crates.io crate hoi4save 0.3.4 [INFO] tweaked toml for crates.io crate hoi4save 0.3.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate hoi4save 0.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a913caf36456a35c086d2eafdb2d9296580c3edd4691bd527733cf6e85fe4b56 [INFO] running `Command { std: "docker" "start" "-a" "a913caf36456a35c086d2eafdb2d9296580c3edd4691bd527733cf6e85fe4b56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a913caf36456a35c086d2eafdb2d9296580c3edd4691bd527733cf6e85fe4b56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a913caf36456a35c086d2eafdb2d9296580c3edd4691bd527733cf6e85fe4b56", kill_on_drop: false }` [INFO] [stdout] a913caf36456a35c086d2eafdb2d9296580c3edd4691bd527733cf6e85fe4b56 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aabe2bf9a70c6efb0c0891c519c404bb983a765d52b6554535e234d84fa6945b [INFO] running `Command { std: "docker" "start" "-a" "aabe2bf9a70c6efb0c0891c519c404bb983a765d52b6554535e234d84fa6945b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.138 [INFO] [stderr] Compiling serde v1.0.138 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling hoi4save v0.3.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling openssl v0.10.40 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking zip v0.6.2 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling jomini_derive v0.2.2 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking attohttpc v0.24.1 [INFO] [stderr] Checking jomini v0.21.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn new(kind: Hoi4ErrorKind) -> Hoi4Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | Hoi4Error(Box::new(kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 154 | .ok_or_else(|| Hoi4ErrorKind::UnknownHeader.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | .ok_or_else(|| Hoi4ErrorKind::UnknownHeader.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/melt.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 101 | let mut unknown_tokens = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok(MeltedDocument { [INFO] [stdout] | ________^ [INFO] [stdout] 207 | | data: wtr.into_inner(), [INFO] [stdout] 208 | | unknown_tokens, [INFO] [stdout] 209 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hoi4save` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn new(kind: Hoi4ErrorKind) -> Hoi4Error { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | Hoi4Error(Box::new(kind)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 154 | .ok_or_else(|| Hoi4ErrorKind::UnknownHeader.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | .ok_or_else(|| Hoi4ErrorKind::UnknownHeader.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/melt.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 101 | let mut unknown_tokens = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok(MeltedDocument { [INFO] [stdout] | ________^ [INFO] [stdout] 207 | | data: wtr.into_inner(), [INFO] [stdout] 208 | | unknown_tokens, [INFO] [stdout] 209 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hoi4save` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "aabe2bf9a70c6efb0c0891c519c404bb983a765d52b6554535e234d84fa6945b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aabe2bf9a70c6efb0c0891c519c404bb983a765d52b6554535e234d84fa6945b", kill_on_drop: false }` [INFO] [stdout] aabe2bf9a70c6efb0c0891c519c404bb983a765d52b6554535e234d84fa6945b