[INFO] fetching crate hmath 0.1.17... [INFO] checking hmath-0.1.17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hmath 0.1.17 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate hmath 0.1.17 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hmath 0.1.17 [INFO] finished tweaking crates.io crate hmath 0.1.17 [INFO] tweaked toml for crates.io crate hmath 0.1.17 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5f80f7ccbbf60af118112579a594cb9cdfdb525db11c77e88baecdf05fd95a6 [INFO] running `Command { std: "docker" "start" "-a" "b5f80f7ccbbf60af118112579a594cb9cdfdb525db11c77e88baecdf05fd95a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5f80f7ccbbf60af118112579a594cb9cdfdb525db11c77e88baecdf05fd95a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5f80f7ccbbf60af118112579a594cb9cdfdb525db11c77e88baecdf05fd95a6", kill_on_drop: false }` [INFO] [stdout] b5f80f7ccbbf60af118112579a594cb9cdfdb525db11c77e88baecdf05fd95a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f6886d4592efb9d379d1a4789258adc43d848724aa6991a247cfd7cf6108ebd [INFO] running `Command { std: "docker" "start" "-a" "1f6886d4592efb9d379d1a4789258adc43d848724aa6991a247cfd7cf6108ebd", kill_on_drop: false }` [INFO] [stderr] Checking hmath v0.1.17 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/poly/from_points.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn add(&self, other: &Polynomial) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:60:31 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn add_mut(&mut self, other: &Polynomial) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:96:23 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn mul(&self, other: &Polynomial) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn mul_mut(&mut self, other: &Polynomial) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn from_vec_generic>(data: Vec>) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Matrix::from_vec( [INFO] [stdout] 38 | / data.into_iter().map( [INFO] [stdout] 39 | | |row| row.into_iter().map( [INFO] [stdout] 40 | | |n| n.into() [INFO] [stdout] 41 | | ).collect::>() [INFO] [stdout] 42 | | ).collect() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 39 | |row| row.into_iter().map( [INFO] [stdout] | __________________---__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | |n| n.into() [INFO] [stdout] 41 | | ).collect::>() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poly.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn from_vec_generic>(coeffs: Vec) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Polynomial { coeffs: coeffs.into_iter().map(|n| n.into()).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poly/from_points.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn from_points_generic>(points: Vec<(T, T)>) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | from_points( [INFO] [stdout] 60 | points.into_iter().map(|(x, y)| (x.into(), y.into())).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hmath` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/poly/from_points.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn add(&self, other: &Polynomial) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:60:31 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn add_mut(&mut self, other: &Polynomial) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:96:23 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn mul(&self, other: &Polynomial) -> Self { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `other` [INFO] [stdout] --> src/poly.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn mul_mut(&mut self, other: &Polynomial) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_other` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn from_vec_generic>(data: Vec>) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Matrix::from_vec( [INFO] [stdout] 38 | / data.into_iter().map( [INFO] [stdout] 39 | | |row| row.into_iter().map( [INFO] [stdout] 40 | | |n| n.into() [INFO] [stdout] 41 | | ).collect::>() [INFO] [stdout] 42 | | ).collect() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matrix.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 39 | |row| row.into_iter().map( [INFO] [stdout] | __________________---__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | |n| n.into() [INFO] [stdout] 41 | | ).collect::>() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poly.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn from_vec_generic>(coeffs: Vec) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Polynomial { coeffs: coeffs.into_iter().map(|n| n.into()).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/poly/from_points.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn from_points_generic>(points: Vec<(T, T)>) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | from_points( [INFO] [stdout] 60 | points.into_iter().map(|(x, y)| (x.into(), y.into())).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hmath` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1f6886d4592efb9d379d1a4789258adc43d848724aa6991a247cfd7cf6108ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f6886d4592efb9d379d1a4789258adc43d848724aa6991a247cfd7cf6108ebd", kill_on_drop: false }` [INFO] [stdout] 1f6886d4592efb9d379d1a4789258adc43d848724aa6991a247cfd7cf6108ebd