[INFO] fetching crate hld 0.3.0... [INFO] checking hld-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hld 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate hld 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hld 0.3.0 [INFO] finished tweaking crates.io crate hld 0.3.0 [INFO] tweaked toml for crates.io crate hld 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate hld 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f1f3298ebf6358feb09cce28cd34ba5b9d6073d9e0d06b07b9806ea0e2785a9 [INFO] running `Command { std: "docker" "start" "-a" "6f1f3298ebf6358feb09cce28cd34ba5b9d6073d9e0d06b07b9806ea0e2785a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f1f3298ebf6358feb09cce28cd34ba5b9d6073d9e0d06b07b9806ea0e2785a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f1f3298ebf6358feb09cce28cd34ba5b9d6073d9e0d06b07b9806ea0e2785a9", kill_on_drop: false }` [INFO] [stdout] 6f1f3298ebf6358feb09cce28cd34ba5b9d6073d9e0d06b07b9806ea0e2785a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b05f0e3409ec6f7e9dc8a5dc606ab524086e956e364ddf630d3ed2a9071315b3 [INFO] running `Command { std: "docker" "start" "-a" "b05f0e3409ec6f7e9dc8a5dc606ab524086e956e364ddf630d3ed2a9071315b3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling serde_json v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Compiling escargot v0.5.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking lipsum v0.9.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling blake3 v1.5.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking reflink-copy v0.1.17 [INFO] [stderr] Checking ocli v0.1.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Checking ignore v0.4.21 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking assert_fs v1.1.1 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap_complete v4.5.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking hld v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 34 | fn path_ctx>(self, path: P) -> Result { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | self.map_err(|source| Error::PathIo { [INFO] [stdout] | ______________________^ [INFO] [stdout] 36 | | source, [INFO] [stdout] 37 | | path: path.into(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 48 | fn glob_ctx>(self, glob: S) -> Result { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | self.map_err(|source| Error::GlobPattern { [INFO] [stdout] | ______________________^ [INFO] [stdout] 50 | | source, [INFO] [stdout] 51 | | glob: glob.into(), [INFO] [stdout] 52 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hld.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | Ok(res [INFO] [stdout] | ________^ [INFO] [stdout] 86 | | .into_iter() [INFO] [stdout] 87 | | .filter(|(_, v)| v.len() >= 2) [INFO] [stdout] 88 | | .map(|(_, v)| v) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hld.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 105 | .map_or_else(HashMap::new, |reader| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | debug!("reading cache"); [INFO] [stdout] 107 | bincode::deserialize_from(io::BufReader::new(reader)).unwrap_or_default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hld` (bin "hld") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b05f0e3409ec6f7e9dc8a5dc606ab524086e956e364ddf630d3ed2a9071315b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b05f0e3409ec6f7e9dc8a5dc606ab524086e956e364ddf630d3ed2a9071315b3", kill_on_drop: false }` [INFO] [stdout] b05f0e3409ec6f7e9dc8a5dc606ab524086e956e364ddf630d3ed2a9071315b3