[INFO] fetching crate hive-mind 0.1.10... [INFO] checking hive-mind-0.1.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hive-mind 0.1.10 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate hive-mind 0.1.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hive-mind 0.1.10 [INFO] finished tweaking crates.io crate hive-mind 0.1.10 [INFO] tweaked toml for crates.io crate hive-mind 0.1.10 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d998f9a6e583bef0f27124b7a5455e5e31c4ab065dade187f40c4c7fd1700ca [INFO] running `Command { std: "docker" "start" "-a" "8d998f9a6e583bef0f27124b7a5455e5e31c4ab065dade187f40c4c7fd1700ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d998f9a6e583bef0f27124b7a5455e5e31c4ab065dade187f40c4c7fd1700ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d998f9a6e583bef0f27124b7a5455e5e31c4ab065dade187f40c4c7fd1700ca", kill_on_drop: false }` [INFO] [stdout] 8d998f9a6e583bef0f27124b7a5455e5e31c4ab065dade187f40c4c7fd1700ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c4a9d72efbd8b0764e41af4f70e5ba1e000011fd267d4c824071ff87aaf071ca [INFO] running `Command { std: "docker" "start" "-a" "c4a9d72efbd8b0764e41af4f70e5ba1e000011fd267d4c824071ff87aaf071ca", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pot v3.0.1 [INFO] [stderr] Checking hive-mind v0.1.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `lazy_static::lazy_static` [INFO] [stdout] --> src/self_boxed/mod.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | use lazy_static::lazy_static; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let path = path.as_ref(); [INFO] [stdout] 37 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | sled: sled::open(path.clone())?, [INFO] [stdout] 39 | | path: Some(std::sync::Arc::new(path.to_path_buf())), [INFO] [stdout] 40 | | _phantom: std::marker::PhantomData, [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | sled: sled::open(path.clone())?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 38 - sled: sled::open(path.clone())?, [INFO] [stdout] 38 + sled: sled::open(path)?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 74 | .map(|(_, bytes)| pot::from_slice::(&bytes).ok()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(hive_mind: Option, name: N, value: T) -> Result { [INFO] [stdout] | --------------------------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | hive_mind, [INFO] [stdout] 60 | | name, [INFO] [stdout] 61 | | value, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn initialize(hive_mind: Option, name: N, value: T) -> Result { [INFO] [stdout] | --------------------------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let rw_value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | // Self::debug_print(hive_mind.clone(), "after initialize"); [INFO] [stdout] 105 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | hive_mind, [INFO] [stdout] 107 | | name, [INFO] [stdout] 108 | | value: rw_value, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn get(hive_mind: HiveMind, name: N) -> Result { [INFO] [stdout] | ------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let value = hive_mind.get::(name.clone())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | hive_mind: Some(hive_mind), [INFO] [stdout] 117 | | name, [INFO] [stdout] 118 | | value, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn get_named(hive_mind: HiveMind) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let name = T::hive_name(); [INFO] [stdout] 143 | let value = hive_mind.get::(name.clone())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | hive_mind: Some(hive_mind), [INFO] [stdout] 147 | | name, [INFO] [stdout] 148 | | value, [INFO] [stdout] 149 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/self_boxed/mod.rs:143:47 [INFO] [stdout] | [INFO] [stdout] 143 | let value = hive_mind.get::(name.clone())?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn set_named(hive_mind: HiveMind, value: T) -> Result { [INFO] [stdout] | ------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 156 | | hive_mind: Some(hive_mind), [INFO] [stdout] 157 | | name, [INFO] [stdout] 158 | | value, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/self_boxed/mod.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | hive_mind.set(name.clone(), &value)?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hive-mind` (lib) due to 8 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `sled_memory` is never used [INFO] [stdout] --> src/test/mod.rs:55:19 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn sled_memory() -> sled::Db { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let path = path.as_ref(); [INFO] [stdout] 37 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | sled: sled::open(path.clone())?, [INFO] [stdout] 39 | | path: Some(std::sync::Arc::new(path.to_path_buf())), [INFO] [stdout] 40 | | _phantom: std::marker::PhantomData, [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | sled: sled::open(path.clone())?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 38 - sled: sled::open(path.clone())?, [INFO] [stdout] 38 + sled: sled::open(path)?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 74 | .map(|(_, bytes)| pot::from_slice::(&bytes).ok()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(hive_mind: Option, name: N, value: T) -> Result { [INFO] [stdout] | --------------------------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | hive_mind, [INFO] [stdout] 60 | | name, [INFO] [stdout] 61 | | value, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn initialize(hive_mind: Option, name: N, value: T) -> Result { [INFO] [stdout] | --------------------------- ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let rw_value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | // Self::debug_print(hive_mind.clone(), "after initialize"); [INFO] [stdout] 105 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 106 | | hive_mind, [INFO] [stdout] 107 | | name, [INFO] [stdout] 108 | | value: rw_value, [INFO] [stdout] 109 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn get(hive_mind: HiveMind, name: N) -> Result { [INFO] [stdout] | ------------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let value = hive_mind.get::(name.clone())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | hive_mind: Some(hive_mind), [INFO] [stdout] 117 | | name, [INFO] [stdout] 118 | | value, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn get_named(hive_mind: HiveMind) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let name = T::hive_name(); [INFO] [stdout] 143 | let value = hive_mind.get::(name.clone())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | hive_mind: Some(hive_mind), [INFO] [stdout] 147 | | name, [INFO] [stdout] 148 | | value, [INFO] [stdout] 149 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/self_boxed/mod.rs:143:47 [INFO] [stdout] | [INFO] [stdout] 143 | let value = hive_mind.get::(name.clone())?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/self_boxed/mod.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn set_named(hive_mind: HiveMind, value: T) -> Result { [INFO] [stdout] | ------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let value = Arc::new(tokio::sync::RwLock::new(value)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 156 | | hive_mind: Some(hive_mind), [INFO] [stdout] 157 | | name, [INFO] [stdout] 158 | | value, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/self_boxed/mod.rs:153:27 [INFO] [stdout] | [INFO] [stdout] 153 | hive_mind.set(name.clone(), &value)?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/mod.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | let config = sled::Config::new().temporary(true); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | config.open().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hive-mind` (lib test) due to 9 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c4a9d72efbd8b0764e41af4f70e5ba1e000011fd267d4c824071ff87aaf071ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4a9d72efbd8b0764e41af4f70e5ba1e000011fd267d4c824071ff87aaf071ca", kill_on_drop: false }` [INFO] [stdout] c4a9d72efbd8b0764e41af4f70e5ba1e000011fd267d4c824071ff87aaf071ca