[INFO] fetching crate hit-data 0.0.5... [INFO] checking hit-data-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hit-data 0.0.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate hit-data 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hit-data 0.0.5 [INFO] finished tweaking crates.io crate hit-data 0.0.5 [INFO] tweaked toml for crates.io crate hit-data 0.0.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bd2956f5a6be863896fbcb97c47aa74ab160add5eaaa519496a296b7e5c50d3 [INFO] running `Command { std: "docker" "start" "-a" "3bd2956f5a6be863896fbcb97c47aa74ab160add5eaaa519496a296b7e5c50d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bd2956f5a6be863896fbcb97c47aa74ab160add5eaaa519496a296b7e5c50d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bd2956f5a6be863896fbcb97c47aa74ab160add5eaaa519496a296b7e5c50d3", kill_on_drop: false }` [INFO] [stdout] 3bd2956f5a6be863896fbcb97c47aa74ab160add5eaaa519496a296b7e5c50d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 201be76f5f0b96a3093fbcaaebef411c509dd2c4c85f0ddf1c57bd2ec5eb81ac [INFO] running `Command { std: "docker" "start" "-a" "201be76f5f0b96a3093fbcaaebef411c509dd2c4c85f0ddf1c57bd2ec5eb81ac", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking mopa v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking hit-data v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::backtrace::Backtrace` [INFO] [stdout] --> src/errors/hit_error.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::backtrace::Backtrace; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/model/mod.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::backtrace::Backtrace` [INFO] [stdout] --> src/errors/hit_error.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::backtrace::Backtrace; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/model/mod.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `duplicate_hit` and `export` [INFO] [stdout] --> src/tests/hit/test_import_hit.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | duplicate_hit, export, test_kernel::create_test_kernel, Hit, IndexEntryProperty, ObjectValue, Reference, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/object_data.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 44 | return DateTime::::from_utc(NaiveDateTime::from_timestamp(self.datetime, 0), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/object_data.rs:44:57 [INFO] [stdout] | [INFO] [stdout] 44 | return DateTime::::from_utc(NaiveDateTime::from_timestamp(self.datetime, 0), Utc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/index/index.rs:241:43 [INFO] [stdout] | [INFO] [stdout] 241 | ObjectValue::VecReference(data) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/object_data.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 44 | return DateTime::::from_utc(NaiveDateTime::from_timestamp(self.datetime, 0), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/object_data.rs:44:57 [INFO] [stdout] | [INFO] [stdout] 44 | return DateTime::::from_utc(NaiveDateTime::from_timestamp(self.datetime, 0), Utc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/tests/object_data/test_date.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | let date = DateTime::::from_utc(NaiveDateTime::from_timestamp(61, 0), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/tests/object_data/test_date.rs:7:57 [INFO] [stdout] | [INFO] [stdout] 7 | let date = DateTime::::from_utc(NaiveDateTime::from_timestamp(61, 0), Utc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `InitEntryAfterIndexPlugin` is never used [INFO] [stdout] --> src/plugins/plugin.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 21 | pub trait InitEntryAfterIndexPlugin { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `property_name` is never read [INFO] [stdout] --> src/prelude/validators/unique_in_parent/unique_in_parent_validator.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct UniqueInParentValidator { [INFO] [stdout] | ----------------------- field in this struct [INFO] [stdout] 12 | property_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/on_field_set.rs:37:38 [INFO] [stdout] | [INFO] [stdout] 37 | listeners.retain(|listener2| listener2.borrow().get_unique_id() != listener_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit.rs:48:42 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(id: &str, model_type: &str, kernel: Rc) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Hit::new_with_values(id, kernel, LinkedHashMap::new(), model_type) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/hit_mod/hit.rs:315:19 [INFO] [stdout] | [INFO] [stdout] 315 | id.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/hit_mod/hit.rs:328:19 [INFO] [stdout] | [INFO] [stdout] 328 | id.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit.rs:382:14 [INFO] [stdout] | [INFO] [stdout] 379 | let index_entry = self.index.get(id)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | let model = self.model_index.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | let model = model.map.get(id)?; [INFO] [stdout] 382 | Some(HitEntry { [INFO] [stdout] | ______________^ [INFO] [stdout] 383 | | entry: index_entry, [INFO] [stdout] 384 | | model: model.clone(), [INFO] [stdout] 385 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit.rs:566:15 [INFO] [stdout] | [INFO] [stdout] 559 | listener: FieldListenerRef, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | ) -> Result { [INFO] [stdout] 561 | let model = self.get_model_or_error(id)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 566 | match self.index.get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit_importer.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(id: &str, kernel: Rc) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let model_index = ModelIndex::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let model_index = Rc::new(RefCell::new(model_index)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | IndexModelImporter { [INFO] [stdout] 28 | index: IndexImporter::new(id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit_importer.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(id: &str, kernel: Rc) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let model_index = ModelIndex::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let model_index = Rc::new(RefCell::new(model_index)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | plugins: kernel.get_plugins(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/patches.rs:61:72 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn apply_patches(hit: &Hit, patches: Vec) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut entries = LinkedHashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | import_from_patches_and_entries(patches, hit.get_main_object_id(), hit.kernel.clone(), &mut entries) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude/validators/unique_in_parent/unique_in_parent_validator.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 20 | index: Rc>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Box::new(UniqueInParentValidator { [INFO] [stdout] | __________________^ [INFO] [stdout] 24 | | property_name: property_name, [INFO] [stdout] 25 | | index: index, [INFO] [stdout] 26 | | value_index: value_index, [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hit-data` (lib) due to 9 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/index/index.rs:241:43 [INFO] [stdout] | [INFO] [stdout] 241 | ObjectValue::VecReference(data) => { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instance` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | instance: &mut Hit, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | reference_id: &crate::Id, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | target: &IndexEntryProperty, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `before_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | before_id: &Option, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_before_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instance` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | instance: &mut Hit, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | reference_id: &crate::Id, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | target: &IndexEntryProperty, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `before_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | before_id: &Option, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_before_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instance` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | instance: &mut Hit, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | reference_id: &crate::Id, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | target: &IndexEntryProperty, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `before_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | before_id: &Option, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_before_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instance` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | instance: &mut Hit, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | reference_id: &crate::Id, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | target: &IndexEntryProperty, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `before_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | before_id: &Option, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_before_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instance` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | instance: &mut Hit, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | reference_id: &crate::Id, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | target: &IndexEntryProperty, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `instance` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | instance: &mut Hit, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reference_id` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | reference_id: &crate::Id, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_reference_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `target` [INFO] [stdout] --> src/tests/plugins/test_reference_plugin.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | target: &IndexEntryProperty, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_target` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `InitEntryAfterIndexPlugin` is never used [INFO] [stdout] --> src/plugins/plugin.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 21 | pub trait InitEntryAfterIndexPlugin { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `it_should_return_an_error_on_reference_arrays_when_validator_detects_it` is never used [INFO] [stdout] --> src/tests/validation/test_validation.rs:130:4 [INFO] [stdout] | [INFO] [stdout] 130 | fn it_should_return_an_error_on_reference_arrays_when_validator_detects_it() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `property_name` is never read [INFO] [stdout] --> src/prelude/validators/unique_in_parent/unique_in_parent_validator.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct UniqueInParentValidator { [INFO] [stdout] | ----------------------- field in this struct [INFO] [stdout] 12 | property_name: String, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/on_field_set.rs:37:38 [INFO] [stdout] | [INFO] [stdout] 37 | listeners.retain(|listener2| listener2.borrow().get_unique_id() != listener_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit.rs:48:42 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(id: &str, model_type: &str, kernel: Rc) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Hit::new_with_values(id, kernel, LinkedHashMap::new(), model_type) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/hit_mod/hit.rs:315:19 [INFO] [stdout] | [INFO] [stdout] 315 | id.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/hit_mod/hit.rs:328:19 [INFO] [stdout] | [INFO] [stdout] 328 | id.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit.rs:382:14 [INFO] [stdout] | [INFO] [stdout] 379 | let index_entry = self.index.get(id)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | let model = self.model_index.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | let model = model.map.get(id)?; [INFO] [stdout] 382 | Some(HitEntry { [INFO] [stdout] | ______________^ [INFO] [stdout] 383 | | entry: index_entry, [INFO] [stdout] 384 | | model: model.clone(), [INFO] [stdout] 385 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit.rs:566:15 [INFO] [stdout] | [INFO] [stdout] 559 | listener: FieldListenerRef, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | ) -> Result { [INFO] [stdout] 561 | let model = self.get_model_or_error(id)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 566 | match self.index.get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit_importer.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(id: &str, kernel: Rc) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let model_index = ModelIndex::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let model_index = Rc::new(RefCell::new(model_index)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | IndexModelImporter { [INFO] [stdout] 28 | index: IndexImporter::new(id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hit_mod/hit_importer.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(id: &str, kernel: Rc) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let model_index = ModelIndex::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let model_index = Rc::new(RefCell::new(model_index)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | plugins: kernel.get_plugins(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/import/patches.rs:61:72 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn apply_patches(hit: &Hit, patches: Vec) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut entries = LinkedHashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | import_from_patches_and_entries(patches, hit.get_main_object_id(), hit.kernel.clone(), &mut entries) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude/validators/unique_in_parent/unique_in_parent_validator.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 20 | index: Rc>, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Box::new(UniqueInParentValidator { [INFO] [stdout] | __________________^ [INFO] [stdout] 24 | | property_name: property_name, [INFO] [stdout] 25 | | index: index, [INFO] [stdout] 26 | | value_index: value_index, [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 35 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hit-data` (lib test) due to 9 previous errors; 35 warnings emitted [INFO] running `Command { std: "docker" "inspect" "201be76f5f0b96a3093fbcaaebef411c509dd2c4c85f0ddf1c57bd2ec5eb81ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "201be76f5f0b96a3093fbcaaebef411c509dd2c4c85f0ddf1c57bd2ec5eb81ac", kill_on_drop: false }` [INFO] [stdout] 201be76f5f0b96a3093fbcaaebef411c509dd2c4c85f0ddf1c57bd2ec5eb81ac