[INFO] fetching crate hirofa_utils 0.7.3...
[INFO] checking hirofa_utils-0.7.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604
[INFO] extracting crate hirofa_utils 0.7.3 into /workspace/builds/worker-2-tc2/source
[INFO] validating manifest of crates.io crate hirofa_utils 0.7.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] started tweaking crates.io crate hirofa_utils 0.7.3
[INFO] finished tweaking crates.io crate hirofa_utils 0.7.3
[INFO] tweaked toml for crates.io crate hirofa_utils 0.7.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Updating crates.io index
[INFO] [stderr] Blocking waiting for file lock on package cache
[INFO] [stderr] Locking 141 packages to latest compatible versions
[INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1)
[INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0)
[INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0)
[INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0)
[INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0)
[INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0)
[INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2)
[INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2)
[INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3)
[INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1)
[INFO] [stderr] Adding thread-id v3.3.0 (latest: v4.2.2)
[INFO] [stderr] Adding tokio v1.38.1 (latest: v1.40.0)
[INFO] [stderr] Adding tokio-macros v2.3.0 (latest: v2.4.0)
[INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1)
[INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0)
[INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0)
[INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6)
[INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Blocking waiting for file lock on package cache
[INFO] [stderr] Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 6641a326d8e4cef980f287944e89988a96904de3f1959079a7da9c3296490ab0
[INFO] running `Command { std: "docker" "start" "-a" "6641a326d8e4cef980f287944e89988a96904de3f1959079a7da9c3296490ab0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "6641a326d8e4cef980f287944e89988a96904de3f1959079a7da9c3296490ab0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6641a326d8e4cef980f287944e89988a96904de3f1959079a7da9c3296490ab0", kill_on_drop: false }`
[INFO] [stdout] 6641a326d8e4cef980f287944e89988a96904de3f1959079a7da9c3296490ab0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c38975b6bc9a43b9663defab7755d8fd6e7b2aca5849a607b1bc939baddbd2c0
[INFO] running `Command { std: "docker" "start" "-a" "c38975b6bc9a43b9663defab7755d8fd6e7b2aca5849a607b1bc939baddbd2c0", kill_on_drop: false }`
[INFO] [stderr] Checking serde v1.0.209
[INFO] [stderr] Checking byteorder v1.5.0
[INFO] [stderr] Checking siphasher v0.3.11
[INFO] [stderr] Checking mio v0.8.11
[INFO] [stderr] Compiling tokio-macros v2.3.0
[INFO] [stderr] Compiling cargo-husky v1.5.0
[INFO] [stderr] Checking new_debug_unreachable v1.0.6
[INFO] [stderr] Checking precomputed-hash v0.1.1
[INFO] [stderr] Checking thread-id v3.3.0
[INFO] [stderr] Checking thread-id v4.2.2
[INFO] [stderr] Checking zerocopy v0.7.35
[INFO] [stderr] Checking is-terminal v0.4.13
[INFO] [stderr] Checking simple-logging v2.0.2
[INFO] [stderr] Checking phf_shared v0.10.0
[INFO] [stderr] Checking tokio v1.38.1
[INFO] [stderr] Checking ppv-lite86 v0.2.20
[INFO] [stderr] Checking rand_chacha v0.3.1
[INFO] [stderr] Checking rand v0.8.5
[INFO] [stderr] Checking serde_json v1.0.127
[INFO] [stderr] Checking ciborium v0.2.2
[INFO] [stderr] Checking string_cache v0.8.7
[INFO] [stderr] Checking tinytemplate v1.2.1
[INFO] [stderr] Checking criterion v0.5.1
[INFO] [stderr] Checking hirofa_utils v0.7.3 (/opt/rustwide/workdir)
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/cache.rs:40:22
[INFO] [stdout] |
[INFO] [stdout] 34 | pub fn new
(producer: P, max_inactive_time: Duration, max_size: usize) -> Self
[INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 40 | entries: LinkedHashMap::new(),
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order`
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/cache.rs:41:23
[INFO] [stdout] |
[INFO] [stdout] 34 | pub fn new(producer: P, max_inactive_time: Duration, max_size: usize) -> Self
[INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 41 | producer: Box::new(producer),
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/debug_mutex.rs:12:18
[INFO] [stdout] |
[INFO] [stdout] 10 | pub fn new(inner: T, name: &'static str) -> Self {
[INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 11 | DebugMutex {
[INFO] [stdout] 12 | mtx: Mutex::new(inner),
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:109:26
[INFO] [stdout] |
[INFO] [stdout] 54 | let (tx, rx) = channel();
[INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] | |
[INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 58 | let join_handle = std::thread::spawn(move || {
[INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 109 | join_handle: Some(join_handle),
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:92:42
[INFO] [stdout] |
[INFO] [stdout] 92 | if SPAWNER.with(|rc| rc.borrow().is_none()) {
[INFO] [stdout] | ^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:95:44
[INFO] [stdout] |
[INFO] [stdout] 95 | TIMEOUTS.with(|rc| rc.borrow_mut().clear());
[INFO] [stdout] | ^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:96:45
[INFO] [stdout] |
[INFO] [stdout] 96 | INTERVALS.with(|rc| rc.borrow_mut().clear());
[INFO] [stdout] | ^^^^^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:180:27
[INFO] [stdout] |
[INFO] [stdout] 180 | SPAWNER.with(|rc| rc.borrow().is_some())
[INFO] [stdout] | ^^^^^^^^^^^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:201:22
[INFO] [stdout] |
[INFO] [stdout] 198 | fut: F,
[INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 201 | SPAWNER.with(move |rc| {
[INFO] [stdout] | ______________________^
[INFO] [stdout] 202 | | let spawner = &*rc.borrow();
[INFO] [stdout] 203 | | spawner
[INFO] [stdout] 204 | | .as_ref()
[INFO] [stdout] ... |
[INFO] [stdout] 207 | | .expect("start fut failed")
[INFO] [stdout] 208 | | })
[INFO] [stdout] | |_________^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:203:13
[INFO] [stdout] |
[INFO] [stdout] 198 | fut: F,
[INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] ...
[INFO] [stdout] 203 | / spawner
[INFO] [stdout] 204 | | .as_ref()
[INFO] [stdout] 205 | | .unwrap()
[INFO] [stdout] 206 | | .spawn_local_with_handle(fut)
[INFO] [stdout] | |_____________________________________________^
[INFO] [stdout] |
[INFO] [stdout] = warning: this changes meaning in Rust 2024
[INFO] [stdout] = note: for more information, see issue #123739
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021
[INFO] [stdout] --> src/eventloop.rs:222:25
[INFO] [stdout] |
[INFO] [stdout] 220 | task: T,
[INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024
[INFO] [stdout] 221 | ) -> impl Future