[INFO] fetching crate hgrep 0.3.7... [INFO] checking hgrep-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hgrep 0.3.7 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hgrep 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hgrep 0.3.7 [INFO] finished tweaking crates.io crate hgrep 0.3.7 [INFO] tweaked toml for crates.io crate hgrep 0.3.7 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate hgrep 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 699ea43c3b2b663dcb8808cdc23186a30947e9c9d4bda88a828a9b06405880d8 [INFO] running `Command { std: "docker" "start" "-a" "699ea43c3b2b663dcb8808cdc23186a30947e9c9d4bda88a828a9b06405880d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "699ea43c3b2b663dcb8808cdc23186a30947e9c9d4bda88a828a9b06405880d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "699ea43c3b2b663dcb8808cdc23186a30947e9c9d4bda88a828a9b06405880d8", kill_on_drop: false }` [INFO] [stdout] 699ea43c3b2b663dcb8808cdc23186a30947e9c9d4bda88a828a9b06405880d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5ec36e838d0e2cdd1df84a523650f985f37a557c736202fcae327011a643e71 [INFO] running `Command { std: "docker" "start" "-a" "a5ec36e838d0e2cdd1df84a523650f985f37a557c736202fcae327011a643e71", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling rustix v0.38.33 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling jobserver v0.1.30 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking grep-matcher v0.1.7 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking line-wrap v0.2.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Compiling pcre2-sys v0.2.9 [INFO] [stderr] Compiling libmimalloc-sys v0.1.35 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling terminfo v0.8.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling bat v0.24.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking std_prelude v0.2.12 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking path_abs v0.5.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking pcre2 v0.2.7 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking ansi_colours v1.2.2 [INFO] [stderr] Checking clap_complete v4.5.2 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking roff v0.2.1 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking grep-searcher v0.1.13 [INFO] [stderr] Checking clap_mangen v0.2.20 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap_complete_nushell v4.5.1 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking grep-pcre2 v0.1.7 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking grep-regex v0.1.12 [INFO] [stderr] Checking mimalloc v0.1.39 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking insta v1.38.0 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking plist v1.6.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking clircle v0.4.0 [INFO] [stderr] Checking syntect v5.2.0 [INFO] [stderr] Checking hgrep v0.3.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 181 | iter: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | iter: iter.peekable(), [INFO] [stdout] 196 | | min_context, [INFO] [stdout] 197 | | max_context, [INFO] [stdout] ... | [INFO] [stdout] 200 | | encoding, [INFO] [stdout] 201 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:261:14 [INFO] [stdout] | [INFO] [stdout] 259 | fn error_item(&mut self, e: anyhow::Error) -> Option> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | self.saw_error = true; [INFO] [stdout] 261 | Some(Err(e)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:359:14 [INFO] [stdout] | [INFO] [stdout] 279 | Err(e) => return self.error_item(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | Err(err) => return self.error_item(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | Some(Ok(File::new(path, lmats, chunks, contents))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grep.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 30 | fn err(line: Vec, msg: impl Into>) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Err(Error::new(Self { [INFO] [stdout] | _____________^ [INFO] [stdout] 36 | | line, [INFO] [stdout] 37 | | message: msg.into(), [INFO] [stdout] 38 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bat.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | .and_then(|path| HighlightingAssets::from_cache(&path).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bat.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 176 | fn print(&self, file: File) -> Result<()> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | self.lock().unwrap().print(file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 238 | fn build_walker(&self, mut paths: impl Iterator) -> Result { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let overrides = builder.build()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | [INFO] [stdout] 250 | let mut builder = WalkBuilder::new(target); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(builder.build()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:548:12 [INFO] [stdout] | [INFO] [stdout] 547 | fn with_regex(pat: &str, config: Config<'main>, printer: P) -> Result { [INFO] [stdout] | --------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | Ok(Self::new(config.build_regex_matcher(pat)?, config, printer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:554:12 [INFO] [stdout] | [INFO] [stdout] 553 | fn with_pcre2(pat: &str, config: Config<'main>, printer: P) -> Result { [INFO] [stdout] | --------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 554 | Ok(Self::new(config.build_pcre2_matcher(pat)?, config, printer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:612:9 [INFO] [stdout] | [INFO] [stdout] 608 | fn grep(&self, paths: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | / paths [INFO] [stdout] 613 | | .par_bridge() [INFO] [stdout] 614 | | .filter_map(|path| match path { [INFO] [stdout] 615 | | Ok(path) => self.search(path).transpose(), [INFO] [stdout] 616 | | Err(err) => Some(Err(err)), [INFO] [stdout] 617 | | }) [INFO] [stdout] 618 | | .map(|matches| self.print_matches(matches?)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntect.rs:643:21 [INFO] [stdout] | [INFO] [stdout] 622 | fn new(out: W, opts: &PrinterOptions<'_>, theme: &'file Theme, chunks: &[(u64, u64)]) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | canvas: Canvas::new(out, opts, theme), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntect.rs:967:12 [INFO] [stdout] | [INFO] [stdout] 966 | pub fn new(writer: W, opts: PrinterOptions<'main>) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 967 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 968 | | writer, [INFO] [stdout] 969 | | syntaxes: load_syntax_set()?, [INFO] [stdout] 970 | | themes: load_themes(opts.theme)?, [INFO] [stdout] 971 | | opts, [INFO] [stdout] 972 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hgrep` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 181 | iter: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | iter: iter.peekable(), [INFO] [stdout] 196 | | min_context, [INFO] [stdout] 197 | | max_context, [INFO] [stdout] ... | [INFO] [stdout] 200 | | encoding, [INFO] [stdout] 201 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:261:14 [INFO] [stdout] | [INFO] [stdout] 259 | fn error_item(&mut self, e: anyhow::Error) -> Option> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | self.saw_error = true; [INFO] [stdout] 261 | Some(Err(e)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chunk.rs:359:14 [INFO] [stdout] | [INFO] [stdout] 279 | Err(e) => return self.error_item(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | Err(err) => return self.error_item(err), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | Some(Ok(File::new(path, lmats, chunks, contents))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/grep.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 30 | fn err(line: Vec, msg: impl Into>) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Err(Error::new(Self { [INFO] [stdout] | _____________^ [INFO] [stdout] 36 | | line, [INFO] [stdout] 37 | | message: msg.into(), [INFO] [stdout] 38 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bat.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | .and_then(|path| HighlightingAssets::from_cache(&path).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bat.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 176 | fn print(&self, file: File) -> Result<()> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | self.lock().unwrap().print(file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 238 | fn build_walker(&self, mut paths: impl Iterator) -> Result { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let overrides = builder.build()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | [INFO] [stdout] 250 | let mut builder = WalkBuilder::new(target); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(builder.build()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:548:12 [INFO] [stdout] | [INFO] [stdout] 547 | fn with_regex(pat: &str, config: Config<'main>, printer: P) -> Result { [INFO] [stdout] | --------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 548 | Ok(Self::new(config.build_regex_matcher(pat)?, config, printer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:554:12 [INFO] [stdout] | [INFO] [stdout] 553 | fn with_pcre2(pat: &str, config: Config<'main>, printer: P) -> Result { [INFO] [stdout] | --------------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 554 | Ok(Self::new(config.build_pcre2_matcher(pat)?, config, printer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ripgrep.rs:612:9 [INFO] [stdout] | [INFO] [stdout] 608 | fn grep(&self, paths: I) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | / paths [INFO] [stdout] 613 | | .par_bridge() [INFO] [stdout] 614 | | .filter_map(|path| match path { [INFO] [stdout] 615 | | Ok(path) => self.search(path).transpose(), [INFO] [stdout] 616 | | Err(err) => Some(Err(err)), [INFO] [stdout] 617 | | }) [INFO] [stdout] 618 | | .map(|matches| self.print_matches(matches?)) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntect.rs:643:21 [INFO] [stdout] | [INFO] [stdout] 622 | fn new(out: W, opts: &PrinterOptions<'_>, theme: &'file Theme, chunks: &[(u64, u64)]) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | canvas: Canvas::new(out, opts, theme), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntect.rs:967:12 [INFO] [stdout] | [INFO] [stdout] 966 | pub fn new(writer: W, opts: PrinterOptions<'main>) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 967 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 968 | | writer, [INFO] [stdout] 969 | | syntaxes: load_syntax_set()?, [INFO] [stdout] 970 | | themes: load_themes(opts.theme)?, [INFO] [stdout] 971 | | opts, [INFO] [stdout] 972 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) fn read_matches>(dir: &Path, input: S) -> Vec> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | fs::read_to_string(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | .flat_map(|input| read_matches(dir, input).into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:69:10 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn read_expected_chunks>(dir: &Path, input: S) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Some(File::new(infile, lmats, chunks, contents)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hgrep` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "a5ec36e838d0e2cdd1df84a523650f985f37a557c736202fcae327011a643e71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5ec36e838d0e2cdd1df84a523650f985f37a557c736202fcae327011a643e71", kill_on_drop: false }` [INFO] [stdout] a5ec36e838d0e2cdd1df84a523650f985f37a557c736202fcae327011a643e71