[INFO] fetching crate hgg 0.4.1... [INFO] checking hgg-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hgg 0.4.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate hgg 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hgg 0.4.1 [INFO] finished tweaking crates.io crate hgg 0.4.1 [INFO] tweaked toml for crates.io crate hgg 0.4.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate hgg 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47d2cd9d26442ffee3354f6642722b51d4ecd9372f0ac310b7e93191fedcfaaa [INFO] running `Command { std: "docker" "start" "-a" "47d2cd9d26442ffee3354f6642722b51d4ecd9372f0ac310b7e93191fedcfaaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47d2cd9d26442ffee3354f6642722b51d4ecd9372f0ac310b7e93191fedcfaaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47d2cd9d26442ffee3354f6642722b51d4ecd9372f0ac310b7e93191fedcfaaa", kill_on_drop: false }` [INFO] [stdout] 47d2cd9d26442ffee3354f6642722b51d4ecd9372f0ac310b7e93191fedcfaaa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d438a85c1ce9a91d48cf7f5a1d63ba5b77d329e61103f6f5eff6913abcb58bf [INFO] running `Command { std: "docker" "start" "-a" "0d438a85c1ce9a91d48cf7f5a1d63ba5b77d329e61103f6f5eff6913abcb58bf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Checking header-vec v0.1.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking space v0.17.0 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking bitarray v0.9.0 [INFO] [stderr] Checking hgg v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `node_get_key` is never used [INFO] [stdout] --> src/lib.rs:1110:8 [INFO] [stdout] | [INFO] [stdout] 1103 | trait HggInternal { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 1110 | fn node_get_key<'a>(&'a self, node: &'a HVec) -> &'a Self::K; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:18 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn new(metric: M) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Self { [INFO] [stdout] 114 | hgg: HggCore::new(metric), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn search_extra_knn(self, search_extra_knn: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Self { [INFO] [stdout] 125 | hgg: self.hgg.search_extra_knn(search_extra_knn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:18 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn freshens(self, freshens: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Self { [INFO] [stdout] 137 | hgg: self.hgg.freshens(freshens), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:18 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn exclude_all_searched(self, exclude_all_searched: bool) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | Self { [INFO] [stdout] 150 | hgg: self.hgg.exclude_all_searched(exclude_all_searched), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 164 | pub fn insert_knn(self, insert_knn: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Self { [INFO] [stdout] 166 | hgg: self.hgg.insert_knn(insert_knn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:321:18 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn new(metric: M) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | Self { [INFO] [stdout] 321 | hgg: HggCore::new(metric), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:18 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn search_extra_knn(self, search_extra_knn: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | Self { [INFO] [stdout] 332 | hgg: self.hgg.search_extra_knn(search_extra_knn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:18 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn freshens(self, freshens: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | Self { [INFO] [stdout] 344 | hgg: self.hgg.freshens(freshens), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:357:18 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn exclude_all_searched(self, exclude_all_searched: bool) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | Self { [INFO] [stdout] 357 | hgg: self.hgg.exclude_all_searched(exclude_all_searched), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:373:18 [INFO] [stdout] | [INFO] [stdout] 371 | pub fn insert_knn(self, insert_knn: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | Self { [INFO] [stdout] 373 | hgg: self.hgg.insert_knn(insert_knn), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:522:20 [INFO] [stdout] | [INFO] [stdout] 519 | pub fn new(metric: M) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 522 | nodes: NodeStorage(vec![], PhantomData), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1180:53 [INFO] [stdout] | [INFO] [stdout] 1180 | .map(|(neighbor, _, _)| (neighbor.node, neighbor.key.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hgg` (lib) due to 13 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0d438a85c1ce9a91d48cf7f5a1d63ba5b77d329e61103f6f5eff6913abcb58bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d438a85c1ce9a91d48cf7f5a1d63ba5b77d329e61103f6f5eff6913abcb58bf", kill_on_drop: false }` [INFO] [stdout] 0d438a85c1ce9a91d48cf7f5a1d63ba5b77d329e61103f6f5eff6913abcb58bf