[INFO] fetching crate hg-git-fast-import 1.4.0... [INFO] checking hg-git-fast-import-1.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hg-git-fast-import 1.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate hg-git-fast-import 1.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hg-git-fast-import 1.4.0 [INFO] finished tweaking crates.io crate hg-git-fast-import 1.4.0 [INFO] tweaked toml for crates.io crate hg-git-fast-import 1.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate hg-git-fast-import 1.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2ce11f0de0b13778da7edd89d7af332634b8c705d64198f7ad019ad23db4ce4 [INFO] running `Command { std: "docker" "start" "-a" "a2ce11f0de0b13778da7edd89d7af332634b8c705d64198f7ad019ad23db4ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2ce11f0de0b13778da7edd89d7af332634b8c705d64198f7ad019ad23db4ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2ce11f0de0b13778da7edd89d7af332634b8c705d64198f7ad019ad23db4ce4", kill_on_drop: false }` [INFO] [stdout] a2ce11f0de0b13778da7edd89d7af332634b8c705d64198f7ad019ad23db4ce4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ec24539477bbbe9d52649d7a2a390967cfeda8abc0c54a39b497d79eedfed0e [INFO] running `Command { std: "docker" "start" "-a" "1ec24539477bbbe9d52649d7a2a390967cfeda8abc0c54a39b497d79eedfed0e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking winnow v0.6.8 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking std-semaphore v0.1.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling hg-git-fast-import v1.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking ordered-parallel-iterator v0.2.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking tracing-appender v0.2.3 [INFO] [stderr] Checking hg-parser v0.8.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 142 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 148 | | inner: SharedMercurialRepository::new(MercurialRepository::open(path)?), [INFO] [stdout] 149 | | config, [INFO] [stdout] 150 | | env, [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 142 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | path: path.as_ref().to_path_buf(), [INFO] [stdout] 148 | | inner: SharedMercurialRepository::new(MercurialRepository::open(path)?), [INFO] [stdout] 149 | | config, [INFO] [stdout] 150 | | env, [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn open>(value: P) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | fast_import_cmd: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 142 | fn git_cmd_status(&self, mut f: F) -> ExitStatus [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let mut git_cmd = Command::new("git"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | f(&mut git_cmd); [INFO] [stdout] 148 | git_cmd.current_dir(&self.path).status().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:351:12 [INFO] [stdout] | [INFO] [stdout] 351 | Ok(output [INFO] [stdout] | ____________^ [INFO] [stdout] 352 | | .stdout [INFO] [stdout] 353 | | .split(|&x| x == b'\n') [INFO] [stdout] 354 | | .filter_map(|x| { [INFO] [stdout] ... | [INFO] [stdout] 360 | | }) [INFO] [stdout] 361 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn open>(value: P) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | fast_import_cmd: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 142 | fn git_cmd_status(&self, mut f: F) -> ExitStatus [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let mut git_cmd = Command::new("git"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | f(&mut git_cmd); [INFO] [stdout] 148 | git_cmd.current_dir(&self.path).status().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:351:12 [INFO] [stdout] | [INFO] [stdout] 351 | Ok(output [INFO] [stdout] | ____________^ [INFO] [stdout] 352 | | .stdout [INFO] [stdout] 353 | | .split(|&x| x == b'\n') [INFO] [stdout] 354 | | .filter_map(|x| { [INFO] [stdout] ... | [INFO] [stdout] 360 | | }) [INFO] [stdout] 361 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hg-git-fast-import` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hg-git-fast-import` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "1ec24539477bbbe9d52649d7a2a390967cfeda8abc0c54a39b497d79eedfed0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ec24539477bbbe9d52649d7a2a390967cfeda8abc0c54a39b497d79eedfed0e", kill_on_drop: false }` [INFO] [stdout] 1ec24539477bbbe9d52649d7a2a390967cfeda8abc0c54a39b497d79eedfed0e