[INFO] fetching crate hemoglobin 0.7.2... [INFO] checking hemoglobin-0.7.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hemoglobin 0.7.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate hemoglobin 0.7.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hemoglobin 0.7.2 [INFO] finished tweaking crates.io crate hemoglobin 0.7.2 [INFO] tweaked toml for crates.io crate hemoglobin 0.7.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05347c7a8bf1cda83e0a0338f2b86d51afad5289fcbc895cf20b6131c1325176 [INFO] running `Command { std: "docker" "start" "-a" "05347c7a8bf1cda83e0a0338f2b86d51afad5289fcbc895cf20b6131c1325176", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05347c7a8bf1cda83e0a0338f2b86d51afad5289fcbc895cf20b6131c1325176", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05347c7a8bf1cda83e0a0338f2b86d51afad5289fcbc895cf20b6131c1325176", kill_on_drop: false }` [INFO] [stdout] 05347c7a8bf1cda83e0a0338f2b86d51afad5289fcbc895cf20b6131c1325176 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f28095a0d57831ee3efb6d15fb3eb0e91fab594f3a6ff9b8c3e26643370c21b [INFO] running `Command { std: "docker" "start" "-a" "1f28095a0d57831ee3efb6d15fb3eb0e91fab594f3a6ff9b8c3e26643370c21b", kill_on_drop: false }` [INFO] [stderr] Checking rust-fuzzy-search v0.1.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking hemoglobin v0.7.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `max` [INFO] [stdout] --> src/search/fuzzy.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cmp::{max, max_by, Ordering}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clean_ascii` [INFO] [stdout] --> src/search/fuzzy.rs:5:38 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{cards::properties::Read, clean_ascii}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `max` [INFO] [stdout] --> src/search/fuzzy.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cmp::{max, max_by, Ordering}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clean_ascii` [INFO] [stdout] --> src/search/fuzzy.rs:5:38 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::{cards::properties::Read, clean_ascii}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbers.rs:193:37 [INFO] [stdout] | [INFO] [stdout] 193 | ... |_| Err(Error::custom("expected a bloodless number or a comparison")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:486:31 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn match_in_vec(vec: Option<&[T]>, cond: impl Fn(&T) -> bool) -> Ternary { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | vec.map_or(Ternary::Void, |vec| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 487 | | if vec.iter().any(cond) { [INFO] [stdout] 488 | | Ternary::True [INFO] [stdout] 489 | | } else { [INFO] [stdout] 490 | | Ternary::False [INFO] [stdout] 491 | | } [INFO] [stdout] 492 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/query_parser.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 48 | fn push(&mut self, token: Token) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match (token, self.pop()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/query_parser.rs:304:8 [INFO] [stdout] | [INFO] [stdout] 213 | let mut restrictions = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Ok(Query { [INFO] [stdout] | ________^ [INFO] [stdout] 305 | | name, [INFO] [stdout] 306 | | restrictions, [INFO] [stdout] 307 | | sort, [INFO] [stdout] 308 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hemoglobin` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/numbers.rs:193:37 [INFO] [stdout] | [INFO] [stdout] 193 | ... |_| Err(Error::custom("expected a bloodless number or a comparison")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:486:31 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn match_in_vec(vec: Option<&[T]>, cond: impl Fn(&T) -> bool) -> Ternary { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | vec.map_or(Ternary::Void, |vec| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 487 | | if vec.iter().any(cond) { [INFO] [stdout] 488 | | Ternary::True [INFO] [stdout] 489 | | } else { [INFO] [stdout] 490 | | Ternary::False [INFO] [stdout] 491 | | } [INFO] [stdout] 492 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/query_parser.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 48 | fn push(&mut self, token: Token) { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match (token, self.pop()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search/query_parser.rs:304:8 [INFO] [stdout] | [INFO] [stdout] 213 | let mut restrictions = vec![]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Ok(Query { [INFO] [stdout] | ________^ [INFO] [stdout] 305 | | name, [INFO] [stdout] 306 | | restrictions, [INFO] [stdout] 307 | | sort, [INFO] [stdout] 308 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hemoglobin` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1f28095a0d57831ee3efb6d15fb3eb0e91fab594f3a6ff9b8c3e26643370c21b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f28095a0d57831ee3efb6d15fb3eb0e91fab594f3a6ff9b8c3e26643370c21b", kill_on_drop: false }` [INFO] [stdout] 1f28095a0d57831ee3efb6d15fb3eb0e91fab594f3a6ff9b8c3e26643370c21b