[INFO] fetching crate helium-crypto 0.8.4... [INFO] checking helium-crypto-0.8.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate helium-crypto 0.8.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate helium-crypto 0.8.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate helium-crypto 0.8.4 [INFO] finished tweaking crates.io crate helium-crypto 0.8.4 [INFO] tweaked toml for crates.io crate helium-crypto 0.8.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 324 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding base16ct v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding base64 v0.12.3 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitfield v0.14.0 (latest: v0.16.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitmaps v2.1.0 (latest: v3.2.1) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding borsh v0.9.3 (latest: v1.5.1) [INFO] [stderr] Adding borsh-derive v0.9.3 (latest: v1.5.1) [INFO] [stderr] Adding borsh-derive-internal v0.9.3 (latest: v0.10.3) [INFO] [stderr] Adding borsh-schema-derive-internal v0.9.3 (latest: v0.10.3) [INFO] [stderr] Adding bs58 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding console_log v0.2.2 (latest: v1.0.0) [INFO] [stderr] Adding const-oid v0.7.1 (latest: v0.9.6) [INFO] [stderr] Adding crypto-bigint v0.3.2 (latest: v0.5.5) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding der v0.5.1 (latest: v0.7.9) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ecdsa v0.13.4 (latest: v0.16.9) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519 v2.2.2 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding ed25519-dalek-bip32 v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding elliptic-curve v0.11.12 (latest: v0.13.8) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding ff v0.11.1 (latest: v0.13.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding group v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding hashbrown v0.11.2 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hmac v0.8.1 (latest: v0.12.1) [INFO] [stderr] Adding hmac v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding k256 v0.10.4 (latest: v0.13.3) [INFO] [stderr] Adding libsecp256k1 v0.6.0 (latest: v0.7.1) [INFO] [stderr] Adding libsecp256k1-core v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding libsecp256k1-gen-ecmult v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding libsecp256k1-gen-genmult v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding multihash v0.18.1 (latest: v0.19.1) [INFO] [stderr] Adding multihash-derive v0.8.1 (latest: v0.9.0) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding num-bigint-dig v0.7.1 (latest: v0.8.4) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding p256 v0.10.1 (latest: v0.13.2) [INFO] [stderr] Adding pbkdf2 v0.10.1 (latest: v0.12.2) [INFO] [stderr] Adding pem v0.8.3 (latest: v3.0.4) [INFO] [stderr] Adding picky-asn1 v0.8.0 (latest: v0.9.0) [INFO] [stderr] Adding picky-asn1-der v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding picky-asn1-x509 v0.12.0 (latest: v0.13.0) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding proc-macro-crate v1.1.3 (latest: v3.2.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.4.1 (latest: v0.5.3) [INFO] [stderr] Adding rfc6979 v0.1.0 (latest: v0.4.0) [INFO] [stderr] Adding rsa v0.4.1 (latest: v0.9.6) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding sec1 v0.2.1 (latest: v0.7.3) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.4.0 (latest: v2.2.0) [INFO] [stderr] Adding simple_asn1 v0.5.4 (latest: v0.6.2) [INFO] [stderr] Adding sized-chunks v0.6.5 (latest: v0.7.0) [INFO] [stderr] Adding solana-frozen-abi v1.13.7 (latest: v2.0.8) [INFO] [stderr] Adding solana-frozen-abi-macro v1.13.7 (latest: v2.0.8) [INFO] [stderr] Adding solana-logger v1.13.7 (latest: v2.0.8) [INFO] [stderr] Adding solana-program v1.13.7 (latest: v2.0.8) [INFO] [stderr] Adding solana-sdk v1.13.7 (latest: v2.0.8) [INFO] [stderr] Adding solana-sdk-macro v1.13.7 (latest: v2.0.8) [INFO] [stderr] Adding sqlx v0.8.0 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-core v0.8.0 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-macros v0.8.0 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-macros-core v0.8.0 (latest: v0.8.1) [INFO] [stderr] Adding sqlx-postgres v0.8.0 (latest: v0.8.1) [INFO] [stderr] Adding subtle v2.4.1 (latest: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding unsigned-varint v0.7.2 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2065d44c2a1948f60ffb2cbdca823360529279e5c6f0e69ced2ece72dedceb30 [INFO] running `Command { std: "docker" "start" "-a" "2065d44c2a1948f60ffb2cbdca823360529279e5c6f0e69ced2ece72dedceb30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2065d44c2a1948f60ffb2cbdca823360529279e5c6f0e69ced2ece72dedceb30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2065d44c2a1948f60ffb2cbdca823360529279e5c6f0e69ced2ece72dedceb30", kill_on_drop: false }` [INFO] [stdout] 2065d44c2a1948f60ffb2cbdca823360529279e5c6f0e69ced2ece72dedceb30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e60c6e1c1b33617096c81a400a090b6193385559f393c419d575b9197f22b7a4 [INFO] running `Command { std: "docker" "start" "-a" "e60c6e1c1b33617096c81a400a090b6193385559f393c419d575b9197f22b7a4", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking const-oid v0.7.1 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking der v0.5.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling num-bigint-dig v0.7.1 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking ed25519 v2.2.2 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking ct-codecs v1.1.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking ff v0.11.1 [INFO] [stderr] Checking signature v1.4.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking group v0.11.0 [INFO] [stderr] Checking ed25519-compact v2.1.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking pem v0.8.3 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking crypto-bigint v0.3.2 [INFO] [stderr] Checking sec1 v0.2.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking simple_asn1 v0.5.4 [INFO] [stderr] Checking rfc6979 v0.1.0 [INFO] [stderr] Checking elliptic-curve v0.11.12 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ecdsa v0.13.4 [INFO] [stderr] Checking k256 v0.10.4 [INFO] [stderr] Checking p256 v0.10.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rsa v0.4.1 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking helium-crypto v0.8.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc_compact/mod.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 63 | let secret = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | p256::SecretKey::from_be_bytes(&input[1..usize::min(input.len(), KEYPAIR_LENGTH)])?; [INFO] [stdout] 65 | let public_key = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | public_key::PublicKey::for_network(network, PublicKey(secret.public_key())); [INFO] [stdout] 67 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | network, [INFO] [stdout] 69 | | public_key, [INFO] [stdout] 70 | | secret: p256::ecdsa::SigningKey::from(secret), [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc_compact/mod.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 87 | let mut secret = p256::SecretKey::random(&mut *csprng); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | public_key: public_key::PublicKey::for_network(network, PublicKey(public_key)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc_compact/mod.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 87 | let mut secret = p256::SecretKey::random(&mut *csprng); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | secret: p256::ecdsa::SigningKey::from(secret), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc_compact/mod.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 101 | let secret = p256::SecretKey::from_be_bytes(entropy)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | network, [INFO] [stdout] 108 | | public_key: public_key::PublicKey::for_network(network, PublicKey(public_key)), [INFO] [stdout] 109 | | secret: p256::ecdsa::SigningKey::from(secret), [INFO] [stdout] 110 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecc_compact/mod.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn ecdh<'a, C>(&self, public_key: C) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let secret_key = p256::SecretKey::from_be_bytes(&self.secret.to_bytes())?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let shared_secret = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | ecdh::diffie_hellman(secret_key.to_nonzero_scalar(), public_key.0.as_affine()); [INFO] [stdout] 139 | Ok(SharedSecret(shared_secret)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ed25519/mod.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 32 | let secret = ed25519_compact::SecretKey::from_slice( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let public_key = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | public_key::PublicKey::for_network(network, PublicKey(secret.public_key())); [INFO] [stdout] 37 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | network, [INFO] [stdout] 39 | | public_key, [INFO] [stdout] 40 | | secret, [INFO] [stdout] 41 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ed25519/mod.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 70 | let keypair = ed25519_compact::KeyPair::from_seed(seed); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let public_key = public_key::PublicKey::for_network(network, PublicKey(keypair.pk)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | network, [INFO] [stdout] 74 | | public_key, [INFO] [stdout] 75 | | secret: keypair.sk, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secp256k1/mod.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 51 | let secret = k256::SecretKey::from_be_bytes(&input[1..])?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let public_key = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | public_key::PublicKey::for_network(network, PublicKey(secret.public_key())); [INFO] [stdout] 54 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 55 | | network, [INFO] [stdout] 56 | | public_key, [INFO] [stdout] 57 | | secret: k256::ecdsa::SigningKey::from(secret), [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secp256k1/mod.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 74 | let secret = k256::SecretKey::random(&mut *csprng); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | public_key: public_key::PublicKey::for_network(network, PublicKey(public_key)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secp256k1/mod.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 74 | let secret = k256::SecretKey::random(&mut *csprng); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | secret: k256::ecdsa::SigningKey::from(secret), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secp256k1/mod.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 84 | let secret = k256::SecretKey::from_be_bytes(entropy)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let public_key = secret.public_key(); [INFO] [stdout] 86 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | network, [INFO] [stdout] 88 | | public_key: public_key::PublicKey::for_network(network, PublicKey(public_key)), [INFO] [stdout] 89 | | secret: k256::ecdsa::SigningKey::from(secret), [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secp256k1/mod.rs:253:12 [INFO] [stdout] | [INFO] [stdout] 250 | let inner = super::public_key::PublicKeyRepr::Secp256k1(PublicKey( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(public_key::PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 254 | | inner, [INFO] [stdout] 255 | | network: Network::MainNet, [INFO] [stdout] 256 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa/mod.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 54 | let secret = ::rsa::RSAPrivateKey::from_pkcs8(&input[1..])?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let public_key = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | public_key::PublicKey::for_network(network, PublicKey(secret.to_public_key())); [INFO] [stdout] 57 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | network, [INFO] [stdout] 59 | | public_key, [INFO] [stdout] 60 | | secret, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa/mod.rs:87:25 [INFO] [stdout] | [INFO] [stdout] 83 | let secret = ::rsa::RSAPrivateKey::new(csprng, 2048).expect("key generation"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let public_key = secret.to_public_key(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | public_key: public_key::PublicKey::for_network(network, PublicKey(public_key)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 93 | let secret = ::rsa::RSAPrivateKey::from_pkcs8(entropy)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let public_key = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | public_key::PublicKey::for_network(network, PublicKey(secret.to_public_key())); [INFO] [stdout] 96 | Ok(Keypair { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | network, [INFO] [stdout] 98 | | public_key, [INFO] [stdout] 99 | | secret, [INFO] [stdout] 100 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsa/mod.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 180 | let n = rsa::BigUint::from_bytes_be(n_buf); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let e = rsa::BigUint::from_bytes_be(e_buf); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let public_key = RSAPublicKey::new(n, e)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(PublicKey(public_key)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/public_key.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 134 | let inner = match key_tag.key_type { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | network: key_tag.network, [INFO] [stdout] 147 | | inner, [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/public_key.rs:366:20 [INFO] [stdout] | [INFO] [stdout] 363 | pub(crate) fn for_network>(network: Network, public_key: C) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | inner: public_key.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keypair.rs:175:19 [INFO] [stdout] | [INFO] [stdout] 174 | fn from(keypair: rsa::Keypair) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | Self::Rsa(Box::new(keypair)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `helium-crypto` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e60c6e1c1b33617096c81a400a090b6193385559f393c419d575b9197f22b7a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e60c6e1c1b33617096c81a400a090b6193385559f393c419d575b9197f22b7a4", kill_on_drop: false }` [INFO] [stdout] e60c6e1c1b33617096c81a400a090b6193385559f393c419d575b9197f22b7a4