[INFO] fetching crate heapz 1.1.4... [INFO] checking heapz-1.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate heapz 1.1.4 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate heapz 1.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate heapz 1.1.4 [INFO] finished tweaking crates.io crate heapz 1.1.4 [INFO] tweaked toml for crates.io crate heapz 1.1.4 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e435ae133186715ffdf2a2626edeb3f33be77d7acb16454bf2ebb61c87b37a4 [INFO] running `Command { std: "docker" "start" "-a" "3e435ae133186715ffdf2a2626edeb3f33be77d7acb16454bf2ebb61c87b37a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e435ae133186715ffdf2a2626edeb3f33be77d7acb16454bf2ebb61c87b37a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e435ae133186715ffdf2a2626edeb3f33be77d7acb16454bf2ebb61c87b37a4", kill_on_drop: false }` [INFO] [stdout] 3e435ae133186715ffdf2a2626edeb3f33be77d7acb16454bf2ebb61c87b37a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 88943da38d35dcb7a8ca94dcfbc42f031d0594f659336124996edb3c642eb7b0 [INFO] running `Command { std: "docker" "start" "-a" "88943da38d35dcb7a8ca94dcfbc42f031d0594f659336124996edb3c642eb7b0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking heapz v1.1.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rank_pairing_heap.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | let mut parent: Position; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rank_pairing_heap.rs:375:13 [INFO] [stdout] | [INFO] [stdout] 375 | let mut child: Position; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rank_pairing_heap.rs:377:17 [INFO] [stdout] | [INFO] [stdout] 377 | let mut parent_node: *mut Node; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rank_pairing_heap.rs:378:17 [INFO] [stdout] | [INFO] [stdout] 378 | let mut child_node: *mut Node; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `heap_rank` is never read [INFO] [stdout] --> src/rank_pairing_heap.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 69 | pub struct RankPairingHeap { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 70 | root: Position, [INFO] [stdout] 71 | heap_rank: HeapRank, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `rank1`, `rank2`, `rank`, and `rank_nodes` are never used [INFO] [stdout] --> src/rank_pairing_heap.rs:186:8 [INFO] [stdout] | [INFO] [stdout] 181 | / impl RankPairingHeap [INFO] [stdout] 182 | | where [INFO] [stdout] 183 | | K: Hash + Eq + Clone, [INFO] [stdout] 184 | | V: PartialOrd, [INFO] [stdout] | |__________________- associated items in this implementation [INFO] [stdout] 185 | { [INFO] [stdout] 186 | fn rank1(left: i32, next: i32) -> i32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 194 | fn rank2(left: i32, next: i32) -> i32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 203 | fn rank(&self, left: i32, next: i32) -> usize { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 210 | fn rank_nodes(&self, left: Position, next: Position) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_index`, `get_left_index`, `get_next_index`, `get_parent_index`, and `get_siblings` are never used [INFO] [stdout] --> src/rank_pairing_heap.rs:296:8 [INFO] [stdout] | [INFO] [stdout] 266 | impl RankPairingHeap { [INFO] [stdout] | --------------------------------------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 296 | fn get_index) -> Position>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 304 | fn get_left_index(&self, index: Position) -> Position { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 308 | fn get_next_index(&self, index: Position) -> Position { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 312 | fn get_parent_index(&self, index: Position) -> Position { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 321 | fn get_siblings(&self, position: Position) -> Option<(Position, Position)> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/bucket.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn drain(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | / self.store [INFO] [stdout] 30 | | .into_iter() [INFO] [stdout] 31 | | .filter(|bucket| !bucket.is_empty()) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/bucket.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|mut bucket| bucket.pop().unwrap()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pairing_heap.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(key: K, value: V) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | left: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pairing_heap.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(key: K, value: V) -> Self { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | next: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pairing_heap.rs:93:15 [INFO] [stdout] | [INFO] [stdout] 90 | node_a: Option>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | node_b: Option>, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | ) -> Option> { [INFO] [stdout] 93 | match (node_a, node_b) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `heapz` (lib) due to 6 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "88943da38d35dcb7a8ca94dcfbc42f031d0594f659336124996edb3c642eb7b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88943da38d35dcb7a8ca94dcfbc42f031d0594f659336124996edb3c642eb7b0", kill_on_drop: false }` [INFO] [stdout] 88943da38d35dcb7a8ca94dcfbc42f031d0594f659336124996edb3c642eb7b0