[INFO] fetching crate hdrhistogram 7.5.4... [INFO] checking hdrhistogram-7.5.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hdrhistogram 7.5.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate hdrhistogram 7.5.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hdrhistogram 7.5.4 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate hdrhistogram 7.5.4 [INFO] tweaked toml for crates.io crate hdrhistogram 7.5.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate hdrhistogram 7.5.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 237a243afcf066bd2b4d9ffb77396be0854e855d5cff1ebccad55bc0fa193305 [INFO] running `Command { std: "docker" "start" "-a" "237a243afcf066bd2b4d9ffb77396be0854e855d5cff1ebccad55bc0fa193305", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "237a243afcf066bd2b4d9ffb77396be0854e855d5cff1ebccad55bc0fa193305", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "237a243afcf066bd2b4d9ffb77396be0854e855d5cff1ebccad55bc0fa193305", kill_on_drop: false }` [INFO] [stdout] 237a243afcf066bd2b4d9ffb77396be0854e855d5cff1ebccad55bc0fa193305 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f640f12c5d4fa11af1cc4f3f328fc4ee78109aa97ef5018743b312a208773342 [INFO] running `Command { std: "docker" "start" "-a" "f640f12c5d4fa11af1cc4f3f328fc4ee78109aa97ef5018743b312a208773342", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling gmp-mpfr-sys v1.6.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling rug v1.22.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking ieee754 v0.2.6 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.24 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hdrhistogram v7.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialization/v2_serializer.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / writer [INFO] [stdout] 111 | | .write_all(&self.buf[0..(total_len)]) [INFO] [stdout] 112 | | .map(|_| total_len) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn activate(mut self) -> Recorder { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | self.reactivate(); [INFO] [stdout] 145 | self.recorder.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:227:23 [INFO] [stdout] | [INFO] [stdout] 224 | pub fn into_idle(mut self) -> IdleRecorder { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | recorder: Some(self), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:234:24 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn add>>(&mut self, source: B) -> Result<(), AdditionError> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | self.with_hist(move |h| h.add(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:243:24 [INFO] [stdout] | [INFO] [stdout] 240 | source: B, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | self.with_hist(move |h| h.add_correct(source, interval)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:251:24 [INFO] [stdout] | [INFO] [stdout] 249 | subtrahend: B, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | ) -> Result<(), SubtractionError> { [INFO] [stdout] 251 | self.with_hist(move |h| h.subtract(subtrahend)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/mod.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 391 | let (tx, rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | shared: Arc::new(Shared { [INFO] [stdout] | _____________________^ [INFO] [stdout] 396 | | truth: Mutex::new(Critical { recorders: 0 }), [INFO] [stdout] 397 | | sender: tx, [INFO] [stdout] 398 | | phase: atomic::AtomicUsize::new(0), [INFO] [stdout] 399 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hdrhistogram` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f640f12c5d4fa11af1cc4f3f328fc4ee78109aa97ef5018743b312a208773342", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f640f12c5d4fa11af1cc4f3f328fc4ee78109aa97ef5018743b312a208773342", kill_on_drop: false }` [INFO] [stdout] f640f12c5d4fa11af1cc4f3f328fc4ee78109aa97ef5018743b312a208773342