[INFO] fetching crate hdrfix 1.0.7... [INFO] checking hdrfix-1.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hdrfix 1.0.7 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate hdrfix 1.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hdrfix 1.0.7 [INFO] finished tweaking crates.io crate hdrfix 1.0.7 [INFO] tweaked toml for crates.io crate hdrfix 1.0.7 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate hdrfix 1.0.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `mozjpeg` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76dd3d5b7696d5ca41641f7ffad3bb9647f07c6ae4cb758db44dbc33a13904c4 [INFO] running `Command { std: "docker" "start" "-a" "76dd3d5b7696d5ca41641f7ffad3bb9647f07c6ae4cb758db44dbc33a13904c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76dd3d5b7696d5ca41641f7ffad3bb9647f07c6ae4cb758db44dbc33a13904c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76dd3d5b7696d5ca41641f7ffad3bb9647f07c6ae4cb758db44dbc33a13904c4", kill_on_drop: false }` [INFO] [stdout] 76dd3d5b7696d5ca41641f7ffad3bb9647f07c6ae4cb758db44dbc33a13904c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6145b33dd30659564b39cfce7ac4e89292f17d2e66f30e5e4c6af1cd05c003a [INFO] running `Command { std: "docker" "start" "-a" "c6145b33dd30659564b39cfce7ac4e89292f17d2e66f30e5e4c6af1cd05c003a", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `mozjpeg` dependency) [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling prettyplease v0.2.16 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling bitflags v2.4.2 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling libloading v0.8.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling build_const v0.2.2 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking oklab v1.0.1 [INFO] [stderr] Checking png v0.17.11 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking glam v0.18.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Compiling mozjpeg-sys v1.1.1 [INFO] [stderr] Compiling libz-sys v1.1.15 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking mtpng v0.3.5 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking mozjpeg v0.9.8 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling jpegxr v0.3.1 [INFO] [stderr] Checking hdrfix v1.0.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 142 | fn fill(&mut self, source: T) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | / self.par_iter_mut() [INFO] [stdout] 147 | | .zip(source) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:834:20 [INFO] [stdout] | [INFO] [stdout] 832 | fn new(func: F) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 833 | Lazy { [INFO] [stdout] 834 | value: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 142 | fn fill(&mut self, source: T) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | / self.par_iter_mut() [INFO] [stdout] 147 | | .zip(source) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:835:19 [INFO] [stdout] | [INFO] [stdout] 832 | fn new(func: F) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 835 | func: Some(func) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:887:44 [INFO] [stdout] | [INFO] [stdout] 887 | let mut input_histogram = Lazy::new(|| time_func("input histogram", || { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 888 | | Ok(Histogram::new(&source)) [INFO] [stdout] 889 | | }).unwrap()); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1059:11 [INFO] [stdout] | [INFO] [stdout] 994 | let args = App::new("hdrfix converter for HDR screenshots") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1059 | match run(&args) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:834:20 [INFO] [stdout] | [INFO] [stdout] 832 | fn new(func: F) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 833 | Lazy { [INFO] [stdout] 834 | value: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:835:19 [INFO] [stdout] | [INFO] [stdout] 832 | fn new(func: F) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 835 | func: Some(func) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:887:44 [INFO] [stdout] | [INFO] [stdout] 887 | let mut input_histogram = Lazy::new(|| time_func("input histogram", || { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 888 | | Ok(Histogram::new(&source)) [INFO] [stdout] 889 | | }).unwrap()); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1059:11 [INFO] [stdout] | [INFO] [stdout] 994 | let args = App::new("hdrfix converter for HDR screenshots") [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1059 | match run(&args) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hdrfix` (bin "hdrfix") due to 6 previous errors [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hdrfix` (bin "hdrfix" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c6145b33dd30659564b39cfce7ac4e89292f17d2e66f30e5e4c6af1cd05c003a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6145b33dd30659564b39cfce7ac4e89292f17d2e66f30e5e4c6af1cd05c003a", kill_on_drop: false }` [INFO] [stdout] c6145b33dd30659564b39cfce7ac4e89292f17d2e66f30e5e4c6af1cd05c003a