[INFO] fetching crate hddwiper 2.0.0... [INFO] checking hddwiper-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hddwiper 2.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hddwiper 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate hddwiper 2.0.0 [INFO] finished tweaking crates.io crate hddwiper 2.0.0 [INFO] tweaked toml for crates.io crate hddwiper 2.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate hddwiper 2.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a2648b254b19d099bb0bccc833fbc754d59ccab495c90193e3f0451393168b5 [INFO] running `Command { std: "docker" "start" "-a" "2a2648b254b19d099bb0bccc833fbc754d59ccab495c90193e3f0451393168b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a2648b254b19d099bb0bccc833fbc754d59ccab495c90193e3f0451393168b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a2648b254b19d099bb0bccc833fbc754d59ccab495c90193e3f0451393168b5", kill_on_drop: false }` [INFO] [stdout] 2a2648b254b19d099bb0bccc833fbc754d59ccab495c90193e3f0451393168b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93d583554087fbcff38fbaa2935ab4701cb090ccd348846c4d8e10d152ba7f95 [INFO] running `Command { std: "docker" "start" "-a" "93d583554087fbcff38fbaa2935ab4701cb090ccd348846c4d8e10d152ba7f95", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.124 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking clap_lex v0.1.1 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking running-average v0.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking spin v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rdrand v0.8.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking cipher v0.4.3 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking flume v0.10.12 [INFO] [stderr] Checking clap v3.1.12 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking hddwiper v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `AsyncBlockSource` and `SyncBlockSource` [INFO] [stdout] --> src/byte_stream/mod.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | pub use block_source::{AsyncBlockSource, SyncBlockSource}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `block_source_byte_stream::BlockSourceByteStream` [INFO] [stdout] --> src/byte_stream/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | pub use block_source_byte_stream::BlockSourceByteStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProductBlockSource` [INFO] [stdout] --> src/byte_stream/mod.rs:55:59 [INFO] [stdout] | [INFO] [stdout] 55 | pub use producer_byte_stream::{byte_stream_from_producer, ProductBlockSource}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::rdrand::SyncByteStreamOrZeroes` [INFO] [stdout] --> src/random/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use self::rdrand::SyncByteStreamOrZeroes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(generic_associated_types)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `scoped_threads` has been stable since 1.63.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(scoped_threads)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncBlockSource` [INFO] [stdout] --> src/byte_stream/mod.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | pub use block_source::{AsyncBlockSource, SyncBlockSource}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `block_source_byte_stream::BlockSourceByteStream` [INFO] [stdout] --> src/byte_stream/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | pub use block_source_byte_stream::BlockSourceByteStream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ProductBlockSource` [INFO] [stdout] --> src/byte_stream/mod.rs:55:59 [INFO] [stdout] | [INFO] [stdout] 55 | pub use producer_byte_stream::{byte_stream_from_producer, ProductBlockSource}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::rdrand::SyncByteStreamOrZeroes` [INFO] [stdout] --> src/random/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use self::rdrand::SyncByteStreamOrZeroes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `generic_associated_types` has been stable since 1.65.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(generic_associated_types)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `scoped_threads` has been stable since 1.63.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(scoped_threads)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `async_read` is never used [INFO] [stdout] --> src/byte_stream/mod.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait AsyncByteStream { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 10 | async fn async_read(&mut self, dest: &mut [u8]) -> Result<()>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `try_get_product` is never used [INFO] [stdout] --> src/producer.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 125 | pub trait ProductReceiver { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 129 | fn try_get_product(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_writer.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 46 | block_source: impl 'static + ProductReceiver> + Send, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | mut writer: impl 'static + Write + Send, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | num_bytes_written: Arc, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ) -> JoinHandle<()> { [INFO] [stdout] 50 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 51 | | loop { [INFO] [stdout] 52 | | log::debug!("Getting blocks..."); [INFO] [stdout] 53 | | // TODO Test that crashes bubble up correctly [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/block_source_byte_stream.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(block_source: B) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | buffer: Buffer::new(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/producer_byte_stream.rs:13:65 [INFO] [stdout] | [INFO] [stdout] 11 | producer: impl ProductReceiver> + Send, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> impl SyncByteStream + AsyncByteStream { [INFO] [stdout] 13 | super::block_source_byte_stream::BlockSourceByteStream::new(ProductBlockSource::new(producer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/byte_stream_producer.rs:13:61 [INFO] [stdout] | [INFO] [stdout] 11 | make_byte_stream: impl Fn() -> Result, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> Result>> { [INFO] [stdout] 13 | ThreadPoolProducer::new(num_workers, buffer_num_blocks, move || { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 14 | | let mut byte_stream = make_byte_stream()?; [INFO] [stdout] 15 | | Ok(move || { [INFO] [stdout] 16 | | // TODO Can we avoid the zero initialization of the buffer? [INFO] [stdout] ... | [INFO] [stdout] 20 | | }) [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/byte_stream_producer.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 11 | make_byte_stream: impl Fn() -> Result, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let mut byte_stream = make_byte_stream()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | // TODO Can we avoid the zero initialization of the buffer? [INFO] [stdout] 17 | | let mut buffer = vec![0; block_size]; [INFO] [stdout] 18 | | byte_stream.blocking_read(buffer.as_mut()).unwrap(); [INFO] [stdout] 19 | | Ok(buffer) [INFO] [stdout] 20 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | make_produce_fn: impl Fn() -> Result, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let (sender, receiver) = flume::bounded(product_buffer_size); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let cancellation_token = CancellationToken::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let workers: Vec = (0..num_workers) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | receiver, [INFO] [stdout] 54 | | workers, [INFO] [stdout] 55 | | cancellation_token, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 145 | let product = self.receiver.recv(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(product?) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/rdrand.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new_stream(stream: G) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | stream: Some(stream), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/reseeding.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(reseed_every_n_bytes: usize, seed_source: S) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { [INFO] [stdout] 22 | generator: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hddwiper` (bin "hddwiper") due to 10 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `try_get_product` is never used [INFO] [stdout] --> src/producer.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 125 | pub trait ProductReceiver { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 129 | fn try_get_product(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_writer.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 46 | block_source: impl 'static + ProductReceiver> + Send, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | mut writer: impl 'static + Write + Send, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | num_bytes_written: Arc, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ) -> JoinHandle<()> { [INFO] [stdout] 50 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 51 | | loop { [INFO] [stdout] 52 | | log::debug!("Getting blocks..."); [INFO] [stdout] 53 | | // TODO Test that crashes bubble up correctly [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/block_source_byte_stream.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(block_source: B) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | buffer: Buffer::new(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/producer_byte_stream.rs:13:65 [INFO] [stdout] | [INFO] [stdout] 11 | producer: impl ProductReceiver> + Send, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> impl SyncByteStream + AsyncByteStream { [INFO] [stdout] 13 | super::block_source_byte_stream::BlockSourceByteStream::new(ProductBlockSource::new(producer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/byte_stream_producer.rs:13:61 [INFO] [stdout] | [INFO] [stdout] 11 | make_byte_stream: impl Fn() -> Result, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | ) -> Result>> { [INFO] [stdout] 13 | ThreadPoolProducer::new(num_workers, buffer_num_blocks, move || { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 14 | | let mut byte_stream = make_byte_stream()?; [INFO] [stdout] 15 | | Ok(move || { [INFO] [stdout] 16 | | // TODO Can we avoid the zero initialization of the buffer? [INFO] [stdout] ... | [INFO] [stdout] 20 | | }) [INFO] [stdout] 21 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_stream/byte_stream_producer.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 11 | make_byte_stream: impl Fn() -> Result, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let mut byte_stream = make_byte_stream()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | // TODO Can we avoid the zero initialization of the buffer? [INFO] [stdout] 17 | | let mut buffer = vec![0; block_size]; [INFO] [stdout] 18 | | byte_stream.blocking_read(buffer.as_mut()).unwrap(); [INFO] [stdout] 19 | | Ok(buffer) [INFO] [stdout] 20 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | make_produce_fn: impl Fn() -> Result, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let (sender, receiver) = flume::bounded(product_buffer_size); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let cancellation_token = CancellationToken::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let workers: Vec = (0..num_workers) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | receiver, [INFO] [stdout] 54 | | workers, [INFO] [stdout] 55 | | cancellation_token, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/producer.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 145 | let product = self.receiver.recv(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(product?) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/rdrand.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn new_stream(stream: G) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | stream: Some(stream), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/random/reseeding.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(reseed_every_n_bytes: usize, seed_source: S) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Self { [INFO] [stdout] 22 | generator: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hddwiper` (bin "hddwiper" test) due to 10 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "93d583554087fbcff38fbaa2935ab4701cb090ccd348846c4d8e10d152ba7f95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93d583554087fbcff38fbaa2935ab4701cb090ccd348846c4d8e10d152ba7f95", kill_on_drop: false }` [INFO] [stdout] 93d583554087fbcff38fbaa2935ab4701cb090ccd348846c4d8e10d152ba7f95