[INFO] fetching crate hdd 0.10.3... [INFO] checking hdd-0.10.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hdd 0.10.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate hdd 0.10.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hdd 0.10.3 [INFO] finished tweaking crates.io crate hdd 0.10.3 [INFO] tweaked toml for crates.io crate hdd 0.10.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate hdd 0.10.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a377c7914f9d723f991df585335c7354889fa7413be028de62675e91811ac78 [INFO] running `Command { std: "docker" "start" "-a" "1a377c7914f9d723f991df585335c7354889fa7413be028de62675e91811ac78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a377c7914f9d723f991df585335c7354889fa7413be028de62675e91811ac78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a377c7914f9d723f991df585335c7354889fa7413be028de62675e91811ac78", kill_on_drop: false }` [INFO] [stdout] 1a377c7914f9d723f991df585335c7354889fa7413be028de62675e91811ac78 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5aa3f2f8627266c08f2e538ed45d40c601aebacbb4e1a4ecabbf7e0fa456541b [INFO] running `Command { std: "docker" "start" "-a" "5aa3f2f8627266c08f2e538ed45d40c601aebacbb4e1a4ecabbf7e0fa456541b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking ucd-util v0.1.8 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking utf8-ranges v1.0.4 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Compiling hdd v0.10.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ata/data/id.rs:271:28 [INFO] [stdout] | [INFO] [stdout] 271 | 0x0000 | 0xffff | 0x0002...0x0400 => RPM::Unknown, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ata/data/id.rs:280:11 [INFO] [stdout] | [INFO] [stdout] 280 | 0x0001 ... 0x000c => Some("(obsolete)"), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/scsi/pages.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | 0x30...0x3e => "(Vendor-Specific)", [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/scsi/pages.rs:226:15 [INFO] [stdout] | [INFO] [stdout] 226 | x @ 0x8000...0xffff => VendorSpecific(x), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/scsi/pages.rs:410:7 [INFO] [stdout] | [INFO] [stdout] 410 | 4...7 => Failed, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/drivedb/drivedb.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | #[cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `clap`, `default`, `env_logger`, `lazy_static`, `number_prefix`, `prettytable-rs`, `separator`, `serde`, `serde_derive`, `serde_json`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/utils.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `clap`, `default`, `env_logger`, `lazy_static`, `number_prefix`, `prettytable-rs`, `separator`, `serde`, `serde_derive`, `serde_json`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/utils.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `clap`, `default`, `env_logger`, `lazy_static`, `number_prefix`, `prettytable-rs`, `separator`, `serde`, `serde_derive`, `serde_json`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ata/data/id.rs:271:28 [INFO] [stdout] | [INFO] [stdout] 271 | 0x0000 | 0xffff | 0x0002...0x0400 => RPM::Unknown, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/ata/data/id.rs:280:11 [INFO] [stdout] | [INFO] [stdout] 280 | 0x0001 ... 0x000c => Some("(obsolete)"), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/scsi/pages.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | 0x30...0x3e => "(Vendor-Specific)", [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/scsi/pages.rs:226:15 [INFO] [stdout] | [INFO] [stdout] 226 | x @ 0x8000...0xffff => VendorSpecific(x), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/scsi/pages.rs:410:7 [INFO] [stdout] | [INFO] [stdout] 410 | 4...7 => Failed, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/drivedb/drivedb.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | #[cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `clap`, `default`, `env_logger`, `lazy_static`, `number_prefix`, `prettytable-rs`, `separator`, `serde`, `serde_derive`, `serde_json`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/utils.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `clap`, `default`, `env_logger`, `lazy_static`, `number_prefix`, `prettytable-rs`, `separator`, `serde`, `serde_derive`, `serde_json`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/utils.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 66 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `bin`, `clap`, `default`, `env_logger`, `lazy_static`, `number_prefix`, `prettytable-rs`, `separator`, `serde`, `serde_derive`, `serde_json`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/device/linux.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 106 | let mut buf = BufReader::new(uevent); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/device/linux.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 106 | let mut buf = BufReader::new(uevent); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/linux.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Device { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | file: OpenOptions::new() [INFO] [stdout] 23 | | .read(true) [INFO] [stdout] 24 | | // > Under Linux, the O_NONBLOCK flag indicates that one wants to open but does not necessarily have the intention to... [INFO] [stdout] ... | [INFO] [stdout] 30 | | .open(path)?, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/mod.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 56 | / quick_error! { [INFO] [stdout] 57 | | #[derive(Debug)] [INFO] [stdout] 58 | | pub enum ATAError { [INFO] [stdout] 59 | | SCSI(err: Error) { [INFO] [stdout] 60 | | from() [INFO] [stdout] 61 | | from(err: io::Error) -> (Error::IO(err)) [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | } [INFO] [stdout] | |_- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `alloc` should have an upper case name [INFO] [stdout] --> src/scsi/mod.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | const alloc: usize = 4096; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `ALLOC` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/mod.rs:151:4 [INFO] [stdout] | [INFO] [stdout] 151 | (&data[0..4]).read_u32::().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/mod.rs:152:4 [INFO] [stdout] | [INFO] [stdout] 152 | (&data[4..8]).read_u32::().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `alloc` should have an upper case name [INFO] [stdout] --> src/scsi/mod.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | const alloc: usize = 4096; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `ALLOC` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/pages.rs:190:32 [INFO] [stdout] | [INFO] [stdout] 190 | log_page::parse(&data).ok_or(Error::InvalidData("parse log page data")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/pages.rs:195:29 [INFO] [stdout] | [INFO] [stdout] 195 | page.parse_params().ok_or(Error::InvalidData("parse log page params")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/pages.rs:277:7 [INFO] [stdout] | [INFO] [stdout] 277 | Err(Error::InvalidData("find valid param in the page")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hdd` (lib) due to 8 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/linux.rs:21:6 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn open>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Device { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | file: OpenOptions::new() [INFO] [stdout] 23 | | .read(true) [INFO] [stdout] 24 | | // > Under Linux, the O_NONBLOCK flag indicates that one wants to open but does not necessarily have the intention to... [INFO] [stdout] ... | [INFO] [stdout] 30 | | .open(path)?, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/mod.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 56 | / quick_error! { [INFO] [stdout] 57 | | #[derive(Debug)] [INFO] [stdout] 58 | | pub enum ATAError { [INFO] [stdout] 59 | | SCSI(err: Error) { [INFO] [stdout] 60 | | from() [INFO] [stdout] 61 | | from(err: io::Error) -> (Error::IO(err)) [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | } [INFO] [stdout] | |_- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `alloc` should have an upper case name [INFO] [stdout] --> src/scsi/mod.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | const alloc: usize = 4096; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `ALLOC` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/mod.rs:151:4 [INFO] [stdout] | [INFO] [stdout] 151 | (&data[0..4]).read_u32::().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/mod.rs:152:4 [INFO] [stdout] | [INFO] [stdout] 152 | (&data[4..8]).read_u32::().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `alloc` should have an upper case name [INFO] [stdout] --> src/scsi/mod.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | const alloc: usize = 4096; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `ALLOC` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/pages.rs:190:32 [INFO] [stdout] | [INFO] [stdout] 190 | log_page::parse(&data).ok_or(Error::InvalidData("parse log page data")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/pages.rs:195:29 [INFO] [stdout] | [INFO] [stdout] 195 | page.parse_params().ok_or(Error::InvalidData("parse log page params")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scsi/pages.rs:277:7 [INFO] [stdout] | [INFO] [stdout] 277 | Err(Error::InvalidData("find valid param in the page")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hdd` (lib test) due to 8 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5aa3f2f8627266c08f2e538ed45d40c601aebacbb4e1a4ecabbf7e0fa456541b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5aa3f2f8627266c08f2e538ed45d40c601aebacbb4e1a4ecabbf7e0fa456541b", kill_on_drop: false }` [INFO] [stdout] 5aa3f2f8627266c08f2e538ed45d40c601aebacbb4e1a4ecabbf7e0fa456541b