[INFO] fetching crate hcp 0.2.0... [INFO] checking hcp-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hcp 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate hcp 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate hcp 0.2.0 [INFO] finished tweaking crates.io crate hcp 0.2.0 [INFO] tweaked toml for crates.io crate hcp 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate hcp 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cc0d68c20a976620aa3a9cbb6238e574b4b8bc7296115102dd8d48fbfdfd060 [INFO] running `Command { std: "docker" "start" "-a" "3cc0d68c20a976620aa3a9cbb6238e574b4b8bc7296115102dd8d48fbfdfd060", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cc0d68c20a976620aa3a9cbb6238e574b4b8bc7296115102dd8d48fbfdfd060", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cc0d68c20a976620aa3a9cbb6238e574b4b8bc7296115102dd8d48fbfdfd060", kill_on_drop: false }` [INFO] [stdout] 3cc0d68c20a976620aa3a9cbb6238e574b4b8bc7296115102dd8d48fbfdfd060 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 38f363cdbc5261ed6fdcd48b1eaf25192426b36f3f1538f10f172b357e4b2799 [INFO] running `Command { std: "docker" "start" "-a" "38f363cdbc5261ed6fdcd48b1eaf25192426b36f3f1538f10f172b357e4b2799", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rustls v0.20.2 [INFO] [stderr] Checking webpki-roots v0.22.2 [INFO] [stderr] Checking ureq v2.4.0 [INFO] [stderr] Checking hcp v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:253:11 [INFO] [stdout] | [INFO] [stdout] 229 | let mut proc = match Command::new(cmd) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Ok(p) => p, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Err(e) => hc.finish_and_exit(&format!("Failed to spawn process: {}", e), EXIT_CODE, true), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let child_stdout = proc.stdout.take().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | let child_stderr = proc.stderr.take().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let stdout_thread = std::thread::spawn(move || read_to_end_tee(child_stdout, pipe_stdout)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let stderr_thread = std::thread::spawn(move || read_to_end_tee(child_stderr, pipe_stderr)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | [INFO] [stdout] 253 | match proc.wait() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:253:11 [INFO] [stdout] | [INFO] [stdout] 229 | let mut proc = match Command::new(cmd) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Ok(p) => p, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Err(e) => hc.finish_and_exit(&format!("Failed to spawn process: {}", e), EXIT_CODE, true), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let child_stdout = proc.stdout.take().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | let child_stderr = proc.stderr.take().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let stdout_thread = std::thread::spawn(move || read_to_end_tee(child_stdout, pipe_stdout)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let stderr_thread = std::thread::spawn(move || read_to_end_tee(child_stderr, pipe_stderr)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | [INFO] [stdout] 253 | match proc.wait() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hcp` (bin "hcp") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hcp` (bin "hcp" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "38f363cdbc5261ed6fdcd48b1eaf25192426b36f3f1538f10f172b357e4b2799", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38f363cdbc5261ed6fdcd48b1eaf25192426b36f3f1538f10f172b357e4b2799", kill_on_drop: false }` [INFO] [stdout] 38f363cdbc5261ed6fdcd48b1eaf25192426b36f3f1538f10f172b357e4b2799