[INFO] fetching crate hc_zome_profiles 0.0.1... [INFO] checking hc_zome_profiles-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hc_zome_profiles 0.0.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate hc_zome_profiles 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hc_zome_profiles 0.0.1 [INFO] finished tweaking crates.io crate hc_zome_profiles 0.0.1 [INFO] tweaked toml for crates.io crate hc_zome_profiles 0.0.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 111 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding hdk v0.0.120 (latest: v0.3.2) [INFO] [stderr] Adding hdk_derive v0.0.22 (latest: v0.3.2) [INFO] [stderr] Adding holo_hash v0.0.17 (latest: v0.3.2) [INFO] [stderr] Adding holochain_serialized_bytes v0.0.51 (latest: v0.0.55) [INFO] [stderr] Adding holochain_serialized_bytes_derive v0.0.51 (latest: v0.0.55) [INFO] [stderr] Adding holochain_wasmer_common v0.0.76 (latest: v0.0.96) [INFO] [stderr] Adding holochain_wasmer_guest v0.0.76 (latest: v0.0.96) [INFO] [stderr] Adding holochain_zome_types v0.0.22 (latest: v0.3.2) [INFO] [stderr] Adding kitsune_p2p_dht_arc v0.0.7 (latest: v0.3.2) [INFO] [stderr] Adding kitsune_p2p_timestamp v0.0.5 (latest: v0.3.2) [INFO] [stderr] Adding matchers v0.0.1 (latest: v0.2.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding paste v1.0.5 (latest: v1.0.15) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rmp-serde v0.15.5 (latest: v1.3.0) [INFO] [stderr] Adding serde v1.0.123 (latest: v1.0.209) [INFO] [stderr] Adding serde_bytes v0.11.10 (latest: v0.11.15) [INFO] [stderr] Adding serde_derive v1.0.123 (latest: v1.0.209) [INFO] [stderr] Adding serde_json v1.0.99 (latest: v1.0.127) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tracing-log v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (latest: v0.3.18) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d839edb9e1fe9f02b639533e22662d12f2efcdf87365ea97da10a065630add68 [INFO] running `Command { std: "docker" "start" "-a" "d839edb9e1fe9f02b639533e22662d12f2efcdf87365ea97da10a065630add68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d839edb9e1fe9f02b639533e22662d12f2efcdf87365ea97da10a065630add68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d839edb9e1fe9f02b639533e22662d12f2efcdf87365ea97da10a065630add68", kill_on_drop: false }` [INFO] [stdout] d839edb9e1fe9f02b639533e22662d12f2efcdf87365ea97da10a065630add68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 49d776ebd947a89fb08acf68722f0fcc99539f605abc06b12a25eac1f706002a [INFO] running `Command { std: "docker" "start" "-a" "49d776ebd947a89fb08acf68722f0fcc99539f605abc06b12a25eac1f706002a", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling serde_json v1.0.99 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling trilean v1.1.0 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling arrayref v0.3.8 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling constant_time_eq v0.1.5 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Compiling base64 v0.13.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling blake2b_simd v0.5.11 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking gcollections v1.5.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking intervallum v1.4.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling holochain_serialized_bytes_derive v0.0.51 [INFO] [stderr] Checking serde_bytes v0.11.10 [INFO] [stderr] Checking serde-transcode v1.1.1 [INFO] [stderr] Checking rmp-serde v0.15.5 [INFO] [stderr] Checking kitsune_p2p_dht_arc v0.0.7 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking kitsune_p2p_timestamp v0.0.5 [INFO] [stderr] Checking holochain_serialized_bytes v0.0.51 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking holochain_wasmer_common v0.0.76 [INFO] [stderr] Checking holo_hash v0.0.17 [INFO] [stderr] Checking holochain_wasmer_guest v0.0.76 [INFO] [stderr] Checking holochain_zome_types v0.0.22 [INFO] [stderr] Compiling hdk_derive v0.0.22 [INFO] [stderr] Checking hdk v0.0.120 [INFO] [stderr] Checking hc_zome_profiles_types v0.0.1 [INFO] [stderr] Checking hc_zome_profiles v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/handlers.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | link_tag(profile.nickname.as_str().clone())?, [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/handlers.rs:94:43 [INFO] [stdout] | [INFO] [stdout] 94 | link_tag(profile.nickname.as_str().clone())?, [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 187 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | [INFO] [stdout] 189 | / get_output [INFO] [stdout] 190 | | .into_iter() [INFO] [stdout] 191 | | .filter_map(|maybe_option| maybe_option) [INFO] [stdout] 192 | | .map(get_agent_profile_from_element) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:178:19 [INFO] [stdout] | [INFO] [stdout] 178 | .with(|h| h.borrow().get_links(get_links_input))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:187:35 [INFO] [stdout] | [INFO] [stdout] 187 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 214 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | [INFO] [stdout] 216 | / get_output [INFO] [stdout] 217 | | .into_iter() [INFO] [stdout] 218 | | .filter_map(|maybe_option| maybe_option) [INFO] [stdout] 219 | | .map(get_agent_profile_from_element) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:214:35 [INFO] [stdout] | [INFO] [stdout] 214 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hc_zome_profiles` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/handlers.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | link_tag(profile.nickname.as_str().clone())?, [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hc_zome_profiles` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/handlers.rs:94:43 [INFO] [stdout] | [INFO] [stdout] 94 | link_tag(profile.nickname.as_str().clone())?, [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 187 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | [INFO] [stdout] 189 | / get_output [INFO] [stdout] 190 | | .into_iter() [INFO] [stdout] 191 | | .filter_map(|maybe_option| maybe_option) [INFO] [stdout] 192 | | .map(get_agent_profile_from_element) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:178:19 [INFO] [stdout] | [INFO] [stdout] 178 | .with(|h| h.borrow().get_links(get_links_input))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:187:35 [INFO] [stdout] | [INFO] [stdout] 187 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 214 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | [INFO] [stdout] 216 | / get_output [INFO] [stdout] 217 | | .into_iter() [INFO] [stdout] 218 | | .filter_map(|maybe_option| maybe_option) [INFO] [stdout] 219 | | .map(get_agent_profile_from_element) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:214:35 [INFO] [stdout] | [INFO] [stdout] 214 | let get_output = HDK.with(|h| h.borrow().get(get_input))?; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "49d776ebd947a89fb08acf68722f0fcc99539f605abc06b12a25eac1f706002a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49d776ebd947a89fb08acf68722f0fcc99539f605abc06b12a25eac1f706002a", kill_on_drop: false }` [INFO] [stdout] 49d776ebd947a89fb08acf68722f0fcc99539f605abc06b12a25eac1f706002a