[INFO] fetching crate hc_seed_bundle 0.2.4... [INFO] checking hc_seed_bundle-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hc_seed_bundle 0.2.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate hc_seed_bundle 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hc_seed_bundle 0.2.4 [INFO] finished tweaking crates.io crate hc_seed_bundle 0.2.4 [INFO] tweaked toml for crates.io crate hc_seed_bundle 0.2.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 125 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf721769a5a6508dcadac2ca371461010c418d013400422812506f22402a5749 [INFO] running `Command { std: "docker" "start" "-a" "bf721769a5a6508dcadac2ca371461010c418d013400422812506f22402a5749", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf721769a5a6508dcadac2ca371461010c418d013400422812506f22402a5749", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf721769a5a6508dcadac2ca371461010c418d013400422812506f22402a5749", kill_on_drop: false }` [INFO] [stdout] bf721769a5a6508dcadac2ca371461010c418d013400422812506f22402a5749 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1fadaa4bb189a8c6d49957ac047b91203f524b7e625c324e9de5961b331ff549 [INFO] running `Command { std: "docker" "start" "-a" "1fadaa4bb189a8c6d49957ac047b91203f524b7e625c324e9de5961b331ff549", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling tinyvec v1.8.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling allocator-api2 v0.2.18 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling rle-decode-fast v1.0.3 [INFO] [stderr] Compiling core2 v0.4.0 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling adler32 v1.2.0 [INFO] [stderr] Compiling dary_heap v0.3.6 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libflate_lz77 v2.1.0 [INFO] [stderr] Compiling filetime v0.2.25 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling libflate v2.1.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling minisign-verify v0.2.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling url v2.5.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling ureq v2.10.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling tar v0.4.41 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling libsodium-sys-stable v1.21.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking rmpv v1.3.0 [INFO] [stderr] Checking one_err v0.0.8 [INFO] [stderr] Checking sodoken v0.0.11 [INFO] [stderr] Checking hc_seed_bundle v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(seed: S, app_data: Arc<[u8]>) -> Self [INFO] [stdout] | ------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | seed: seed.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(seed: S, app_data: Arc<[u8]>) -> Self [INFO] [stdout] | ------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | cipher_list: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 54 | let passphrase = passphrase.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let gen_cipher: PrivCalcCipher = Box::new(move |seed| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | / async move { [INFO] [stdout] 57 | | // encrypt the passphrase [INFO] [stdout] 58 | | let (salt, header, cipher) = [INFO] [stdout] 59 | | pw_enc(seed, passphrase, limits).await?; [INFO] [stdout] ... | [INFO] [stdout] 68 | | }) [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 80 | answer_list: (A, A, A), [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let gen_cipher: PrivCalcCipher = Box::new(move |seed| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | / async move { [INFO] [stdout] 88 | | // generate a deterministic passphrase from the answers [INFO] [stdout] 89 | | let (a1, a2, a3) = answer_list; [INFO] [stdout] 90 | | let passphrase = process_security_answers(a1, a2, a3)?; [INFO] [stdout] ... | [INFO] [stdout] 104 | | }) [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:123:24 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|c| c(seed.clone())) [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/u8array.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 21 | fn from(o: sodoken::BufReadSized) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | (*o.read_lock_sized()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/seed_bundle.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 44 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let dec: IDes<'de> = serde::Deserialize::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(SeedBundle { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | cipher_list: dec.1, [INFO] [stdout] 57 | | app_data: dec.2, [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/pw_utils.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 7 | a1: A1, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | a2: A2, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | a3: A3, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let a1 = a1.into(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let a1 = a1.read_lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let a2 = a2.into(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let a2 = a2.read_lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let a3 = a3.into(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let a3 = a3.read_lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let out = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(out.to_read()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/pw_hash_limits.rs:37:33 [INFO] [stdout] | [INFO] [stdout] 37 | PWHASH_LIMITS.with(|s| *s.borrow()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/pw_hash_limits.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn with_exec(self, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | PWHASH_LIMITS.with(move |s| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 46 | | *s.borrow_mut() = self; [INFO] [stdout] 47 | | let res = f(); [INFO] [stdout] 48 | | *s.borrow_mut() = PwHashLimits::Moderate; [INFO] [stdout] 49 | | res [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:83:60 [INFO] [stdout] | [INFO] [stdout] 74 | let seed = self.seed.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | async move { [INFO] [stdout] 76 | let new_seed = sodoken::BufWriteSized::new_mem_locked()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Self::priv_from_seed(new_seed.to_read_sized()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 97 | message: M, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let sign_sec_key = self.sign_sec_key.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | async move { [INFO] [stdout] 108 | let sig = sodoken::BufWriteSized::new_no_lock(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | sodoken::sign::detached(sig.clone(), message, sign_sec_key).await?; [INFO] [stdout] 110 | Ok(sig.to_read_sized()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(seed: S, app_data: Arc<[u8]>) -> Self [INFO] [stdout] | ------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | seed: seed.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(seed: S, app_data: Arc<[u8]>) -> Self [INFO] [stdout] | ------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | cipher_list: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 54 | let passphrase = passphrase.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let gen_cipher: PrivCalcCipher = Box::new(move |seed| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | / async move { [INFO] [stdout] 57 | | // encrypt the passphrase [INFO] [stdout] 58 | | let (salt, header, cipher) = [INFO] [stdout] 59 | | pw_enc(seed, passphrase, limits).await?; [INFO] [stdout] ... | [INFO] [stdout] 68 | | }) [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 80 | answer_list: (A, A, A), [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let gen_cipher: PrivCalcCipher = Box::new(move |seed| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | / async move { [INFO] [stdout] 88 | | // generate a deterministic passphrase from the answers [INFO] [stdout] 89 | | let (a1, a2, a3) = answer_list; [INFO] [stdout] 90 | | let passphrase = process_security_answers(a1, a2, a3)?; [INFO] [stdout] ... | [INFO] [stdout] 104 | | }) [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher.rs:123:24 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|c| c(seed.clone())) [INFO] [stdout] | - ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/u8array.rs:22:11 [INFO] [stdout] | [INFO] [stdout] 21 | fn from(o: sodoken::BufReadSized) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | (*o.read_lock_sized()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/seed_bundle.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 44 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let dec: IDes<'de> = serde::Deserialize::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(SeedBundle { [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | cipher_list: dec.1, [INFO] [stdout] 57 | | app_data: dec.2, [INFO] [stdout] 58 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/pw_utils.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 7 | a1: A1, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | a2: A2, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | a3: A3, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let a1 = a1.into(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let a1 = a1.read_lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let a2 = a2.into(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let a2 = a2.read_lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let a3 = a3.into(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let a3 = a3.read_lock(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let out = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(out.to_read()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/pw_hash_limits.rs:37:33 [INFO] [stdout] | [INFO] [stdout] 37 | PWHASH_LIMITS.with(|s| *s.borrow()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seed_cipher/pw_hash_limits.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn with_exec(self, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | PWHASH_LIMITS.with(move |s| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 46 | | *s.borrow_mut() = self; [INFO] [stdout] 47 | | let res = f(); [INFO] [stdout] 48 | | *s.borrow_mut() = PwHashLimits::Moderate; [INFO] [stdout] 49 | | res [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:83:60 [INFO] [stdout] | [INFO] [stdout] 74 | let seed = self.seed.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | async move { [INFO] [stdout] 76 | let new_seed = sodoken::BufWriteSized::new_mem_locked()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Self::priv_from_seed(new_seed.to_read_sized()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 97 | message: M, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let sign_sec_key = self.sign_sec_key.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | async move { [INFO] [stdout] 108 | let sig = sodoken::BufWriteSized::new_no_lock(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | sodoken::sign::detached(sig.clone(), message, sign_sec_key).await?; [INFO] [stdout] 110 | Ok(sig.to_read_sized()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:171:15 [INFO] [stdout] | [INFO] [stdout] 159 | let mut seed = UnlockedSeedBundle::new_random().await.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let orig_pub_key = seed.get_sign_pub_key(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | [INFO] [stdout] 164 | let passphrase = sodoken::BufRead::from(b"test-passphrase".to_vec()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | let cipher = PwHashLimits::Minimum [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let encoded = cipher.lock().await.unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | [INFO] [stdout] 171 | match UnlockedSeedBundle::from_locked(&encoded) [INFO] [stdout] | _______________^ [INFO] [stdout] 172 | | .await [INFO] [stdout] 173 | | .unwrap() [INFO] [stdout] 174 | | .remove(0) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:167:27 [INFO] [stdout] | [INFO] [stdout] 167 | .with_exec(|| seed.lock().add_pwhash_cipher(passphrase.clone())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:167:57 [INFO] [stdout] | [INFO] [stdout] 167 | .with_exec(|| seed.lock().add_pwhash_cipher(passphrase.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 190 | let mut seed = UnlockedSeedBundle::new_random().await.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let orig_pub_key = seed.get_sign_pub_key(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | let a1 = sodoken::BufRead::from(b"blUe".to_vec()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let a2 = sodoken::BufRead::from(b"spicy ".to_vec()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let a3 = sodoken::BufRead::from(b" big".to_vec()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | let cipher = PwHashLimits::Minimum.with_exec(|| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let encoded = cipher.lock().await.unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | [INFO] [stdout] 210 | match UnlockedSeedBundle::from_locked(&encoded) [INFO] [stdout] | _______________^ [INFO] [stdout] 211 | | .await [INFO] [stdout] 212 | | .unwrap() [INFO] [stdout] 213 | | .remove(0) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unlocked_seed_bundle.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 198 | let a1 = sodoken::BufRead::from(b"blUe".to_vec()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let a2 = sodoken::BufRead::from(b"spicy ".to_vec()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let a3 = sodoken::BufRead::from(b" big".to_vec()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let a_list = (a1, a2, a3); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | seed.lock().add_security_question_cipher(q_list, a_list) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hc_seed_bundle` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hc_seed_bundle` (lib test) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "1fadaa4bb189a8c6d49957ac047b91203f524b7e625c324e9de5961b331ff549", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fadaa4bb189a8c6d49957ac047b91203f524b7e625c324e9de5961b331ff549", kill_on_drop: false }` [INFO] [stdout] 1fadaa4bb189a8c6d49957ac047b91203f524b7e625c324e9de5961b331ff549