[INFO] fetching crate hashcow 0.2.0... [INFO] checking hashcow-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hashcow 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hashcow 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hashcow 0.2.0 [INFO] finished tweaking crates.io crate hashcow 0.2.0 [INFO] tweaked toml for crates.io crate hashcow 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.1.8 (latest: v0.14.5) [INFO] [stderr] Adding scopeguard v0.3.3 (latest: v1.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2663752cd1955726122cb6f017e6f66292c74a2da8adc2155bc34dd3c39124e [INFO] running `Command { std: "docker" "start" "-a" "d2663752cd1955726122cb6f017e6f66292c74a2da8adc2155bc34dd3c39124e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2663752cd1955726122cb6f017e6f66292c74a2da8adc2155bc34dd3c39124e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2663752cd1955726122cb6f017e6f66292c74a2da8adc2155bc34dd3c39124e", kill_on_drop: false }` [INFO] [stdout] d2663752cd1955726122cb6f017e6f66292c74a2da8adc2155bc34dd3c39124e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85ccd53ff0158ca5c22522e105820b6a3012054dea2bda47dffb9c252f75ee64 [INFO] running `Command { std: "docker" "start" "-a" "85ccd53ff0158ca5c22522e105820b6a3012054dea2bda47dffb9c252f75ee64", kill_on_drop: false }` [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking hashbrown v0.1.8 [INFO] [stderr] Checking hashcow v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused attribute [INFO] [stdout] --> src/lib.rs:310:5 [INFO] [stdout] | [INFO] [stdout] 310 | #[inline] [INFO] [stdout] | ^^^^^^^^^ help: remove this attribute [INFO] [stdout] | [INFO] [stdout] note: attribute also specified here [INFO] [stdout] --> src/lib.rs:293:5 [INFO] [stdout] | [INFO] [stdout] 293 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused attribute [INFO] [stdout] --> src/lib.rs:310:5 [INFO] [stdout] | [INFO] [stdout] 310 | #[inline] [INFO] [stdout] | ^^^^^^^^^ help: remove this attribute [INFO] [stdout] | [INFO] [stdout] note: attribute also specified here [INFO] [stdout] --> src/lib.rs:293:5 [INFO] [stdout] | [INFO] [stdout] 293 | #[inline] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn insert_owned(&mut self, key: ::Owned, value: ::Owned) -> Option<::Owned> { [INFO] [stdout] | -------------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | self.inner.insert(Cow::Owned(key), Cow::Owned(value)).map(|x| x.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn insert_owned(&mut self, key: ::Owned, value: ::Owned) -> Option<::Owned> { [INFO] [stdout] | -------------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | self.inner.insert(Cow::Owned(key), Cow::Owned(value)).map(|x| x.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn insert_owned_borrowed_key(&mut self, key: &'a K, value: ::Owned) -> Option<::Owned> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | self.inner.insert(Cow::Borrowed(key), Cow::Owned(value)).map(|x| x.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn insert_borrowed_owned_key(&mut self, key: ::Owned, value: &'a V) -> Option<::Owned> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | self.inner.insert(Cow::Owned(key), Cow::Borrowed(value)).map(|x| x.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn insert_owned_borrowed_key(&mut self, key: &'a K, value: ::Owned) -> Option<::Owned> { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | self.inner.insert(Cow::Borrowed(key), Cow::Owned(value)).map(|x| x.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn insert_borrowed_owned_key(&mut self, key: ::Owned, value: &'a V) -> Option<::Owned> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | self.inner.insert(Cow::Owned(key), Cow::Borrowed(value)).map(|x| x.into_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hashcow` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hashcow` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "85ccd53ff0158ca5c22522e105820b6a3012054dea2bda47dffb9c252f75ee64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85ccd53ff0158ca5c22522e105820b6a3012054dea2bda47dffb9c252f75ee64", kill_on_drop: false }` [INFO] [stdout] 85ccd53ff0158ca5c22522e105820b6a3012054dea2bda47dffb9c252f75ee64