[INFO] fetching crate hash40 1.3.1... [INFO] checking hash40-1.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hash40 1.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate hash40 1.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hash40 1.3.1 [INFO] finished tweaking crates.io crate hash40 1.3.1 [INFO] tweaked toml for crates.io crate hash40 1.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding binrw v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding binrw_derive v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding diff-struct v0.3.1 (latest: v0.5.3) [INFO] [stderr] Adding diff_derive v0.1.2 (latest: v0.2.3) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18399f6f2957482d6a4538d0c7a6e880824d2c7764cc1123754f06dc14018ea4 [INFO] running `Command { std: "docker" "start" "-a" "18399f6f2957482d6a4538d0c7a6e880824d2c7764cc1123754f06dc14018ea4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18399f6f2957482d6a4538d0c7a6e880824d2c7764cc1123754f06dc14018ea4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18399f6f2957482d6a4538d0c7a6e880824d2c7764cc1123754f06dc14018ea4", kill_on_drop: false }` [INFO] [stdout] 18399f6f2957482d6a4538d0c7a6e880824d2c7764cc1123754f06dc14018ea4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d097e5fc22701fd2726926a18a529b6ba6699ded555c939ef426f52728c45f4 [INFO] running `Command { std: "docker" "start" "-a" "8d097e5fc22701fd2726926a18a529b6ba6699ded555c939ef426f52728c45f4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling diff_derive v0.1.2 [INFO] [stderr] Checking diff-struct v0.3.1 [INFO] [stderr] Checking hash40 v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_map.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn read_labels>(path: P) -> Result, io::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let reader = BufReader::new(File::open(path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | reader.lines().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_map.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 63 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ) -> Result, CustomLabelError> { [INFO] [stdout] 65 | let reader = BufReader::new(File::open(path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / reader [INFO] [stdout] 67 | | .lines() [INFO] [stdout] 68 | | .map(|line_result| { [INFO] [stdout] 69 | | let line = line_result?; [INFO] [stdout] ... | [INFO] [stdout] 77 | | }) [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_map.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|line_result| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | / split [INFO] [stdout] 72 | | .next() [INFO] [stdout] 73 | | .zip(split.next()) [INFO] [stdout] 74 | | .ok_or(CustomLabelError::MisingColumn) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hash40` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_map.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn read_labels>(path: P) -> Result, io::Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let reader = BufReader::new(File::open(path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | reader.lines().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_map.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 63 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | ) -> Result, CustomLabelError> { [INFO] [stdout] 65 | let reader = BufReader::new(File::open(path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / reader [INFO] [stdout] 67 | | .lines() [INFO] [stdout] 68 | | .map(|line_result| { [INFO] [stdout] 69 | | let line = line_result?; [INFO] [stdout] ... | [INFO] [stdout] 77 | | }) [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/label_map.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|line_result| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | / split [INFO] [stdout] 72 | | .next() [INFO] [stdout] 73 | | .zip(split.next()) [INFO] [stdout] 74 | | .ok_or(CustomLabelError::MisingColumn) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hash40` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8d097e5fc22701fd2726926a18a529b6ba6699ded555c939ef426f52728c45f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d097e5fc22701fd2726926a18a529b6ba6699ded555c939ef426f52728c45f4", kill_on_drop: false }` [INFO] [stdout] 8d097e5fc22701fd2726926a18a529b6ba6699ded555c939ef426f52728c45f4