[INFO] fetching crate harmony_rust_sdk 0.8.0... [INFO] checking harmony_rust_sdk-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate harmony_rust_sdk 0.8.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate harmony_rust_sdk 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate harmony_rust_sdk 0.8.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate harmony_rust_sdk 0.8.0 [INFO] tweaked toml for crates.io crate harmony_rust_sdk 0.8.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate harmony_rust_sdk 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae1e5b17f1807b57483ecfc32399833468746bffe0763d941206c864c42d3b82 [INFO] running `Command { std: "docker" "start" "-a" "ae1e5b17f1807b57483ecfc32399833468746bffe0763d941206c864c42d3b82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae1e5b17f1807b57483ecfc32399833468746bffe0763d941206c864c42d3b82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae1e5b17f1807b57483ecfc32399833468746bffe0763d941206c864c42d3b82", kill_on_drop: false }` [INFO] [stdout] ae1e5b17f1807b57483ecfc32399833468746bffe0763d941206c864c42d3b82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c4e79d146d339cc42b8bbd0582759b3ad63203543c0103bbb69108f0a7607f6a [INFO] running `Command { std: "docker" "start" "-a" "c4e79d146d339cc42b8bbd0582759b3ad63203543c0103bbb69108f0a7607f6a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling fastrand v1.6.0 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling fixedbitset v0.4.1 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Compiling walkdir v2.3.2 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling which v4.2.2 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Compiling prost-build v0.9.0 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling petgraph v0.6.0 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.5 [INFO] [stderr] Compiling prost-derive v0.9.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling harmony_derive v0.1.3 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking ctrlc v3.2.1 [INFO] [stderr] Compiling prost v0.9.0 [INFO] [stderr] Compiling prost-types v0.9.0 [INFO] [stderr] Compiling hrpc-build v0.33.0 [INFO] [stderr] Compiling hrpc v0.33.17 [INFO] [stderr] Compiling harmony_rust_sdk v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `std::array::IntoIter::::new`: use `IntoIterator::into_iter` instead [INFO] [stdout] --> src/api/chat.rs:230:39 [INFO] [stdout] | [INFO] [stdout] 230 | std::array::IntoIter::new([("messages.send", false)]), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 218 | let url = value.parse::().map_err(HmcFromStrError::UrlParse)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | [INFO] [stdout] 220 | Self::try_from(url).map_err(HmcFromStrError::HmcParse) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 227 | fn try_from(value: Uri) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(Self { inner: value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 294 | let mut parts = Parts::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | Uri::from_parts(parts).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/rest.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(o: FileIds) -> Vec { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | o.into_iter().map(|id| id.to_string()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/chat.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | fn try_from(value: stream_events_response::Event) -> Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / (match value { [INFO] [stdout] 35 | | stream_events_response::Event::Chat(s) => s.event.map(Self::Chat), [INFO] [stdout] 36 | | stream_events_response::Event::Emote(e) => e.event.map(Self::Emote), [INFO] [stdout] 37 | | stream_events_response::Event::Profile(p) => p.event.map(Self::Profile), [INFO] [stdout] 38 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 218 | let url = value.parse::().map_err(HmcFromStrError::UrlParse)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | [INFO] [stdout] 220 | Self::try_from(url).map_err(HmcFromStrError::HmcParse) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 227 | fn try_from(value: Uri) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(Self { inner: value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/mod.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 294 | let mut parts = Parts::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | Uri::from_parts(parts).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/rest.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | fn from(o: FileIds) -> Vec { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | o.into_iter().map(|id| id.to_string()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/chat.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | fn try_from(value: stream_events_response::Event) -> Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / (match value { [INFO] [stdout] 35 | | stream_events_response::Event::Chat(s) => s.event.map(Self::Chat), [INFO] [stdout] 36 | | stream_events_response::Event::Emote(e) => e.event.map(Self::Emote), [INFO] [stdout] 37 | | stream_events_response::Event::Profile(p) => p.event.map(Self::Profile), [INFO] [stdout] 38 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/chat.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn has_permission<'a, Perm, I>(perms: I, query: &str) -> Option [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let mut matching_perms = perms [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | matching_perms.pop().map(|p| p.borrow().1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/chat.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn has_permission<'a, Perm, I>(perms: I, query: &str) -> Option [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let mut matching_perms = perms [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | matching_perms.pop().map(|p| p.borrow().1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `harmony_rust_sdk` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `harmony_rust_sdk` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "c4e79d146d339cc42b8bbd0582759b3ad63203543c0103bbb69108f0a7607f6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4e79d146d339cc42b8bbd0582759b3ad63203543c0103bbb69108f0a7607f6a", kill_on_drop: false }` [INFO] [stdout] c4e79d146d339cc42b8bbd0582759b3ad63203543c0103bbb69108f0a7607f6a