[INFO] fetching crate harbourmaster 0.5.0... [INFO] checking harbourmaster-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate harbourmaster 0.5.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate harbourmaster 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate harbourmaster 0.5.0 [INFO] finished tweaking crates.io crate harbourmaster 0.5.0 [INFO] tweaked toml for crates.io crate harbourmaster 0.5.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 167 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-openssl v0.9.2 (latest: v0.10.2) [INFO] [stderr] Adding hyperlocal v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pin-project v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding pin-project-internal v0.4.30 (latest: v1.1.5) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdbbd5be542323dc4c58e02115d9531ce5dd1e7f47720c1d6ca2fd2f8ac9f9fe [INFO] running `Command { std: "docker" "start" "-a" "cdbbd5be542323dc4c58e02115d9531ce5dd1e7f47720c1d6ca2fd2f8ac9f9fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdbbd5be542323dc4c58e02115d9531ce5dd1e7f47720c1d6ca2fd2f8ac9f9fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdbbd5be542323dc4c58e02115d9531ce5dd1e7f47720c1d6ca2fd2f8ac9f9fe", kill_on_drop: false }` [INFO] [stdout] cdbbd5be542323dc4c58e02115d9531ce5dd1e7f47720c1d6ca2fd2f8ac9f9fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fae5c1340629c3e42438c3f6d3c7b7b8c9b22a83a750c3f4cae3b78778ac6da2 [INFO] running `Command { std: "docker" "start" "-a" "fae5c1340629c3e42438c3f6d3c7b7b8c9b22a83a750c3f4cae3b78778ac6da2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling tokio-openssl v0.6.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling hyper-openssl v0.9.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking linked_hash_set v0.1.4 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking futures_codec v0.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyperlocal v0.8.0 [INFO] [stderr] Checking shiplift v0.7.0 [INFO] [stderr] Checking harbourmaster v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(docker: shiplift::Docker) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Client { [INFO] [stdout] 57 | inner_client: Arc::new(docker), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 173 | fn new(image_name: impl Into) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | client: Client::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 51 | fn new(name: impl AsRef) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self { [INFO] [stdout] 53 | client: Client::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(docker: shiplift::Docker) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Client { [INFO] [stdout] 57 | inner_client: Arc::new(docker), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/container.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 173 | fn new(image_name: impl Into) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | client: Client::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 51 | fn new(name: impl AsRef) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self { [INFO] [stdout] 53 | client: Client::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `harbourmaster` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `harbourmaster` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "fae5c1340629c3e42438c3f6d3c7b7b8c9b22a83a750c3f4cae3b78778ac6da2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fae5c1340629c3e42438c3f6d3c7b7b8c9b22a83a750c3f4cae3b78778ac6da2", kill_on_drop: false }` [INFO] [stdout] fae5c1340629c3e42438c3f6d3c7b7b8c9b22a83a750c3f4cae3b78778ac6da2