[INFO] fetching crate handsome_logger 0.8.0... [INFO] checking handsome_logger-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate handsome_logger 0.8.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate handsome_logger 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate handsome_logger 0.8.0 [INFO] finished tweaking crates.io crate handsome_logger 0.8.0 [INFO] tweaked toml for crates.io crate handsome_logger 0.8.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c6bf1dc476ca67527da29c95497e664d6bab3e0dbd8efb116ba62bf0fe745d0 [INFO] running `Command { std: "docker" "start" "-a" "9c6bf1dc476ca67527da29c95497e664d6bab3e0dbd8efb116ba62bf0fe745d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c6bf1dc476ca67527da29c95497e664d6bab3e0dbd8efb116ba62bf0fe745d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c6bf1dc476ca67527da29c95497e664d6bab3e0dbd8efb116ba62bf0fe745d0", kill_on_drop: false }` [INFO] [stdout] 9c6bf1dc476ca67527da29c95497e664d6bab3e0dbd8efb116ba62bf0fe745d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47103d7ae930ffc444ee59be889e597ede7e3d2ba3b23f2d63586436e761e351 [INFO] running `Command { std: "docker" "start" "-a" "47103d7ae930ffc444ee59be889e597ede7e3d2ba3b23f2d63586436e761e351", kill_on_drop: false }` [INFO] [stderr] Compiling const_fn v0.4.10 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking tz-rs v0.6.14 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking handsome_logger v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/combine_logger.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(logger: Vec>) -> Box { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Box::new(CombinedLogger { level: log_level, logger }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/simple_logger.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(log_level: LevelFilter, mut config: Config) -> Box { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Box::new(SimpleLogger { [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | level: log_level, [INFO] [stdout] 33 | | config, [INFO] [stdout] 34 | | output_lock: Mutex::new(()), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/term_logger.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(mut config: Config, mode: TerminalMode, color_choice: ColorChoice) -> Box { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let streams = match mode { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Box::new(TermLogger { [INFO] [stdout] | __________________^ [INFO] [stdout] 61 | | level: log_level, [INFO] [stdout] 62 | | config, [INFO] [stdout] 63 | | streams: Mutex::new(streams), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/write_logger.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(mut config: Config, writable: W) -> Box> { [INFO] [stdout] | ------------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Box::new(WriteLogger { [INFO] [stdout] | __________________^ [INFO] [stdout] 31 | | level: log_level, [INFO] [stdout] 32 | | config, [INFO] [stdout] 33 | | writable: Mutex::new(writable), [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `handsome_logger` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/combine_logger.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(logger: Vec>) -> Box { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Box::new(CombinedLogger { level: log_level, logger }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/simple_logger.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(log_level: LevelFilter, mut config: Config) -> Box { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Box::new(SimpleLogger { [INFO] [stdout] | __________________^ [INFO] [stdout] 32 | | level: log_level, [INFO] [stdout] 33 | | config, [INFO] [stdout] 34 | | output_lock: Mutex::new(()), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/term_logger.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn new(mut config: Config, mode: TerminalMode, color_choice: ColorChoice) -> Box { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let streams = match mode { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Box::new(TermLogger { [INFO] [stdout] | __________________^ [INFO] [stdout] 61 | | level: log_level, [INFO] [stdout] 62 | | config, [INFO] [stdout] 63 | | streams: Mutex::new(streams), [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loggers/write_logger.rs:30:18 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(mut config: Config, writable: W) -> Box> { [INFO] [stdout] | ------------------ ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Box::new(WriteLogger { [INFO] [stdout] | __________________^ [INFO] [stdout] 31 | | level: log_level, [INFO] [stdout] 32 | | config, [INFO] [stdout] 33 | | writable: Mutex::new(writable), [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `handsome_logger` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "47103d7ae930ffc444ee59be889e597ede7e3d2ba3b23f2d63586436e761e351", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47103d7ae930ffc444ee59be889e597ede7e3d2ba3b23f2d63586436e761e351", kill_on_drop: false }` [INFO] [stdout] 47103d7ae930ffc444ee59be889e597ede7e3d2ba3b23f2d63586436e761e351