[INFO] fetching crate ham 0.2.0... [INFO] checking ham-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ham 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ham 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ham 0.2.0 [INFO] finished tweaking crates.io crate ham 0.2.0 [INFO] tweaked toml for crates.io crate ham 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ham 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1713219699caa3d73f2850e33400103bb44cf1aecd9a37410671b178f54a4741 [INFO] running `Command { std: "docker" "start" "-a" "1713219699caa3d73f2850e33400103bb44cf1aecd9a37410671b178f54a4741", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1713219699caa3d73f2850e33400103bb44cf1aecd9a37410671b178f54a4741", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1713219699caa3d73f2850e33400103bb44cf1aecd9a37410671b178f54a4741", kill_on_drop: false }` [INFO] [stdout] 1713219699caa3d73f2850e33400103bb44cf1aecd9a37410671b178f54a4741 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4205ea5228a8d82ecbbd69f216e76983b8756c2ac69d211b41cae2fb4181f139 [INFO] running `Command { std: "docker" "start" "-a" "4205ea5228a8d82ecbbd69f216e76983b8756c2ac69d211b41cae2fb4181f139", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling proc-macro2 v1.0.21 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling nix v0.11.1 [INFO] [stderr] Compiling syn v1.0.41 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking reed-solomon v0.2.1 [INFO] [stderr] Checking spin_sleep v0.3.7 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling miniz_oxide v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Compiling num-derive v0.3.2 [INFO] [stderr] Checking gpio-cdev v0.2.0 [INFO] [stderr] Checking spidev v0.4.0 [INFO] [stderr] Checking ham v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Index` [INFO] [stdout] --> src/rfm69/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::ops::Index; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Filtering` [INFO] [stdout] --> src/rfm69/receiver.rs:1:28 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::rfm69::{DCFree, Filtering, Mode, PacketConfig, Rfm69, SyncConfig}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `RwLock` [INFO] [stdout] --> src/rfm69/receiver.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::{Arc, RwLock}; [INFO] [stdout] | ^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Filtering` [INFO] [stdout] --> src/rfm69/receiver.rs:1:28 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::rfm69::{DCFree, Filtering, Mode, PacketConfig, Rfm69, SyncConfig}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `RwLock` [INFO] [stdout] --> src/rfm69/receiver.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::{Arc, RwLock}; [INFO] [stdout] | ^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Index` [INFO] [stdout] --> src/rfm69/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::ops::Index; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `NetworkPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:107:7 [INFO] [stdout] | [INFO] [stdout] 107 | trait NetworkPacketReceiver: PacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AddressPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:110:7 [INFO] [stdout] | [INFO] [stdout] 110 | trait AddressPacketReceiver: NetworkPacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `BroadcastPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:115:7 [INFO] [stdout] | [INFO] [stdout] 115 | trait BroadcastPacketReceiver: AddressPacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `VerifiedPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | trait VerifiedPacketReceiver: PacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AddressPacketSender` is never used [INFO] [stdout] --> src/lib.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | trait AddressPacketSender: NetworkPacketSender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `VerifiedPacketSender` is never used [INFO] [stdout] --> src/lib.rs:135:7 [INFO] [stdout] | [INFO] [stdout] 135 | trait VerifiedPacketSender: PacketSender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SetAddr` and `SetBroadcast` are never constructed [INFO] [stdout] --> src/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 139 | enum ConfigMessage { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] 140 | SetNetwork(N), [INFO] [stdout] 141 | SetAddr(A), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 142 | SetBroadcast(A), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_true_irq` is never used [INFO] [stdout] --> src/rfm69/mod.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 45 | impl IrqWait<'_> { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 117 | fn is_true_irq(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_fifo_overrun`, `get_payload_ready`, and `get_sync_address` are never used [INFO] [stdout] --> src/rfm69/mod.rs:1027:8 [INFO] [stdout] | [INFO] [stdout] 127 | impl Rfm69 { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1027 | fn get_fifo_overrun(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1085 | fn get_payload_ready(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1173 | fn get_sync_address(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn terminate(self) -> Result)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | self.conf_sender.send(ConfigMessage::Terminate).ok(); // ignore error [INFO] [stdout] 26 | / self.rfm_thread [INFO] [stdout] 27 | | .join() [INFO] [stdout] 28 | | .map_err(|_| { [INFO] [stdout] 29 | | ( [INFO] [stdout] ... | [INFO] [stdout] 32 | | ) [INFO] [stdout] 33 | | })? [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 28 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ( [INFO] [stdout] 30 | Error::Unrecoverable("The receiver thread paniced!".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 28 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | .map_err(|e| (e.0, Some(e.1))) [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:211:12 [INFO] [stdout] | [INFO] [stdout] 116 | fn into_packet_receiver(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | self.set_mode_internal(Mode::Standby)?; [INFO] [stdout] 118 | let (conf_sender, conf_recv) = sync_channel(0); [INFO] [stdout] | ----------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let (msg_sender, msg_recv) = channel(); [INFO] [stdout] | ---------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let builder = ThreadBuilder::new().name("rfm69_sender".to_string()); [INFO] [stdout] 121 | let rfm_thread = builder.spawn(move ||{ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok(Rfm69PR { [INFO] [stdout] | ____________^ [INFO] [stdout] 212 | | rfm_thread, [INFO] [stdout] 213 | | conf_sender, [INFO] [stdout] 214 | | msg_recv, [INFO] [stdout] ... | [INFO] [stdout] 218 | | verbose: 0, [INFO] [stdout] 219 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn terminate(self) -> Result)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | self.conf_sender.send(ConfigMessage::Terminate).ok(); [INFO] [stdout] 21 | / self.rfm_thread [INFO] [stdout] 22 | | .join() [INFO] [stdout] 23 | | .map_err(|_| { [INFO] [stdout] 24 | | ( [INFO] [stdout] ... | [INFO] [stdout] 27 | | ) [INFO] [stdout] 28 | | })? [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 23 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | ( [INFO] [stdout] 25 | Error::Unrecoverable("The sender thread panicked!".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 23 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:29:32 [INFO] [stdout] | [INFO] [stdout] 29 | .map_err(|e| (e.0, Some(e.1))) [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 80 | fn into_packet_sender(mut self, msg_buf: usize) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.set_mode_internal(Mode::Standby)?; [INFO] [stdout] 82 | let (conf_sender, conf_recv) = sync_channel(msg_buf); [INFO] [stdout] | ----------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let rfm_thread = builder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(Rfm69PS { [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | conf_sender, [INFO] [stdout] 165 | | rfm_thread, [INFO] [stdout] 166 | | encoder, [INFO] [stdout] 167 | | verbose: 0, [INFO] [stdout] 168 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ham` (lib test) due to 11 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `NetworkPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:107:7 [INFO] [stdout] | [INFO] [stdout] 107 | trait NetworkPacketReceiver: PacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AddressPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:110:7 [INFO] [stdout] | [INFO] [stdout] 110 | trait AddressPacketReceiver: NetworkPacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `BroadcastPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:115:7 [INFO] [stdout] | [INFO] [stdout] 115 | trait BroadcastPacketReceiver: AddressPacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `VerifiedPacketReceiver` is never used [INFO] [stdout] --> src/lib.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 118 | trait VerifiedPacketReceiver: PacketReceiver { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `AddressPacketSender` is never used [INFO] [stdout] --> src/lib.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | trait AddressPacketSender: NetworkPacketSender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `VerifiedPacketSender` is never used [INFO] [stdout] --> src/lib.rs:135:7 [INFO] [stdout] | [INFO] [stdout] 135 | trait VerifiedPacketSender: PacketSender { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `SetAddr` and `SetBroadcast` are never constructed [INFO] [stdout] --> src/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 139 | enum ConfigMessage { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] 140 | SetNetwork(N), [INFO] [stdout] 141 | SetAddr(A), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 142 | SetBroadcast(A), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_true_irq` is never used [INFO] [stdout] --> src/rfm69/mod.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 45 | impl IrqWait<'_> { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 117 | fn is_true_irq(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_fifo_overrun`, `get_payload_ready`, and `get_sync_address` are never used [INFO] [stdout] --> src/rfm69/mod.rs:1027:8 [INFO] [stdout] | [INFO] [stdout] 127 | impl Rfm69 { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1027 | fn get_fifo_overrun(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1085 | fn get_payload_ready(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1173 | fn get_sync_address(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn terminate(self) -> Result)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | self.conf_sender.send(ConfigMessage::Terminate).ok(); // ignore error [INFO] [stdout] 26 | / self.rfm_thread [INFO] [stdout] 27 | | .join() [INFO] [stdout] 28 | | .map_err(|_| { [INFO] [stdout] 29 | | ( [INFO] [stdout] ... | [INFO] [stdout] 32 | | ) [INFO] [stdout] 33 | | })? [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 28 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | ( [INFO] [stdout] 30 | Error::Unrecoverable("The receiver thread paniced!".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 28 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:34:32 [INFO] [stdout] | [INFO] [stdout] 34 | .map_err(|e| (e.0, Some(e.1))) [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/receiver.rs:211:12 [INFO] [stdout] | [INFO] [stdout] 116 | fn into_packet_receiver(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | self.set_mode_internal(Mode::Standby)?; [INFO] [stdout] 118 | let (conf_sender, conf_recv) = sync_channel(0); [INFO] [stdout] | ----------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let (msg_sender, msg_recv) = channel(); [INFO] [stdout] | ---------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let builder = ThreadBuilder::new().name("rfm69_sender".to_string()); [INFO] [stdout] 121 | let rfm_thread = builder.spawn(move ||{ [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok(Rfm69PR { [INFO] [stdout] | ____________^ [INFO] [stdout] 212 | | rfm_thread, [INFO] [stdout] 213 | | conf_sender, [INFO] [stdout] 214 | | msg_recv, [INFO] [stdout] ... | [INFO] [stdout] 218 | | verbose: 0, [INFO] [stdout] 219 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn terminate(self) -> Result)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | self.conf_sender.send(ConfigMessage::Terminate).ok(); [INFO] [stdout] 21 | / self.rfm_thread [INFO] [stdout] 22 | | .join() [INFO] [stdout] 23 | | .map_err(|_| { [INFO] [stdout] 24 | | ( [INFO] [stdout] ... | [INFO] [stdout] 27 | | ) [INFO] [stdout] 28 | | })? [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 23 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | ( [INFO] [stdout] 25 | Error::Unrecoverable("The sender thread panicked!".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 23 | .map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:29:32 [INFO] [stdout] | [INFO] [stdout] 29 | .map_err(|e| (e.0, Some(e.1))) [INFO] [stdout] | - ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rfm69/sender.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 80 | fn into_packet_sender(mut self, msg_buf: usize) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.set_mode_internal(Mode::Standby)?; [INFO] [stdout] 82 | let (conf_sender, conf_recv) = sync_channel(msg_buf); [INFO] [stdout] | ----------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let rfm_thread = builder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(Rfm69PS { [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | conf_sender, [INFO] [stdout] 165 | | rfm_thread, [INFO] [stdout] 166 | | encoder, [INFO] [stdout] 167 | | verbose: 0, [INFO] [stdout] 168 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ham` (lib) due to 11 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4205ea5228a8d82ecbbd69f216e76983b8756c2ac69d211b41cae2fb4181f139", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4205ea5228a8d82ecbbd69f216e76983b8756c2ac69d211b41cae2fb4181f139", kill_on_drop: false }` [INFO] [stdout] 4205ea5228a8d82ecbbd69f216e76983b8756c2ac69d211b41cae2fb4181f139