[INFO] fetching crate hac-client 0.2.0... [INFO] checking hac-client-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hac-client 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate hac-client 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hac-client 0.2.0 [INFO] finished tweaking crates.io crate hac-client 0.2.0 [INFO] tweaked toml for crates.io crate hac-client 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate hac-client 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4f57813312b1c8edbeca2a9a6455cc6d347860e86d461eba5f3e8579aad68911 [INFO] running `Command { std: "docker" "start" "-a" "4f57813312b1c8edbeca2a9a6455cc6d347860e86d461eba5f3e8579aad68911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4f57813312b1c8edbeca2a9a6455cc6d347860e86d461eba5f3e8579aad68911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f57813312b1c8edbeca2a9a6455cc6d347860e86d461eba5f3e8579aad68911", kill_on_drop: false }` [INFO] [stdout] 4f57813312b1c8edbeca2a9a6455cc6d347860e86d461eba5f3e8579aad68911 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec4181524e9169d098799e6906e93552754e51dcd6176b4554f1126e3dbc2ad2 [INFO] running `Command { std: "docker" "start" "-a" "ec4181524e9169d098799e6906e93552754e51dcd6176b4554f1126e3dbc2ad2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling cc v1.0.96 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde v1.0.199 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking rustls-pki-types v1.5.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Compiling tree-sitter v0.22.5 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking winnow v0.6.7 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling tree-sitter-json v0.21.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking rustls-webpki v0.102.3 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking jsonxf v1.1.1 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking font8x8 v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.199 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling uuid-macro-internal v1.8.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Compiling divan-macros v0.1.14 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking ratatui v0.26.2 [INFO] [stderr] Checking thiserror v1.0.59 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking tracing-appender v0.2.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling mutants v0.0.3 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking hac-cli v0.2.0 [INFO] [stderr] Checking divan v0.1.14 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tui-big-text v0.4.3 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking hac-config v0.2.0 [INFO] [stderr] Checking hac-colors v0.2.0 [INFO] [stderr] Checking hac-core v0.2.0 [INFO] [stderr] Checking hac-client v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 22 | collections: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let terminal = Terminal::new(CrosstermBackend::new(std::io::stdout()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | screen_manager: ScreenManager::new( [INFO] [stdout] 29 | | terminal.size()?, [INFO] [stdout] 30 | | colors, [INFO] [stdout] ... | [INFO] [stdout] 37 | | terminal, [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_dashboard/collection_dashboard.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 64 | collections: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let mut list_state = CollectionListState::new(collections.clone()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(CollectionDashboard { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | list_state, [INFO] [stdout] 75 | | form_state: FormState::default(), [INFO] [stdout] 76 | | colors, [INFO] [stdout] ... | [INFO] [stdout] 84 | | dry_run, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_dashboard/collection_dashboard.rs:243:31 [INFO] [stdout] | [INFO] [stdout] 235 | let sender_copy = self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | match hac_core::fs::create_collection(name, description, dry_run).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:57:31 [INFO] [stdout] | [INFO] [stdout] 57 | .and_then(|items| items.read().unwrap().first().map(|item| item.get_id())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:88:57 [INFO] [stdout] | [INFO] [stdout] 88 | .get_or_insert_with(|| Arc::new(RwLock::new(vec![]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:117:31 [INFO] [stdout] | [INFO] [stdout] 117 | .and_then(|state| state.borrow().selected_request.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|state| state.borrow().focused_pane) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:130:26 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|state| state.borrow().selected_pane) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:137:31 [INFO] [stdout] | [INFO] [stdout] 137 | .and_then(|state| state.borrow().hovered_request.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|state| state.borrow().collection.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:149:26 [INFO] [stdout] | [INFO] [stdout] 149 | .map(|state| state.borrow().dirs_expanded.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:161:31 [INFO] [stdout] | [INFO] [stdout] 161 | .and_then(|state| state.borrow_mut().overlay_stack.pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:167:31 [INFO] [stdout] | [INFO] [stdout] 167 | .and_then(|state| state.borrow().overlay_stack.last().cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | .map(|state| !state.borrow().overlay_stack.is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:199:34 [INFO] [stdout] | [INFO] [stdout] 199 | .is_some_and(|state| state.borrow().has_pending_request) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:369:5 [INFO] [stdout] | [INFO] [stdout] 354 | let mut path = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | path.pop() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:388:5 [INFO] [stdout] | [INFO] [stdout] 380 | let mut path = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | found.then(|| path.pop()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_viewer.rs:130:36 [INFO] [stdout] | [INFO] [stdout] 100 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let (request_tx, response_rx) = unbounded_channel::(); [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | let sidebar = sidebar::Sidebar::new(colors, collection_store.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let request_editor = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let response_viewer = ResponseViewer::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let request_uri = RequestUri::new(colors, collection_store.clone(), layout.req_uri); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | global_command_sender: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_viewer.rs:132:28 [INFO] [stdout] | [INFO] [stdout] 100 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let (request_tx, response_rx) = unbounded_channel::(); [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | let sidebar = sidebar::Sidebar::new(colors, collection_store.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let request_editor = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let response_viewer = ResponseViewer::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let request_uri = RequestUri::new(colors, collection_store.clone(), layout.req_uri); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | responses_map: HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_viewer.rs:244:61 [INFO] [stdout] | [INFO] [stdout] 185 | let sender = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let mut collection = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | match hac_core::fs::sync_collection(collection).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_editor.rs:126:26 [INFO] [stdout] | [INFO] [stdout] 110 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | body_editor: BodyEditor::new( [INFO] [stdout] | __________________________^ [INFO] [stdout] 127 | | colors, [INFO] [stdout] 128 | | config, [INFO] [stdout] 129 | | collection_store.clone(), [INFO] [stdout] 130 | | layout.content_pane, [INFO] [stdout] 131 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_editor.rs:132:29 [INFO] [stdout] | [INFO] [stdout] 110 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | headers_editor: HeadersEditor::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 133 | | colors, [INFO] [stdout] 134 | | collection_store.clone(), [INFO] [stdout] 135 | | layout.content_pane, [INFO] [stdout] 136 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_editor/headers_editor.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 56 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | header_form: HeadersEditorForm::new(colors, collection_store.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_uri.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|req| req.read().unwrap().uri.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/response_viewer.rs:321:32 [INFO] [stdout] | [INFO] [stdout] 321 | .is_some_and(|res| res.borrow().is_error) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/response_viewer.rs:333:33 [INFO] [stdout] | [INFO] [stdout] 333 | .is_some_and(|res| !res.borrow().is_error) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar.rs:342:48 [INFO] [stdout] | [INFO] [stdout] 342 | ... .is_some_and(|req| req.read().unwrap().id.eq(&item_id)); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 22 | collections: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let terminal = Terminal::new(CrosstermBackend::new(std::io::stdout()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | screen_manager: ScreenManager::new( [INFO] [stdout] 29 | | terminal.size()?, [INFO] [stdout] 30 | | colors, [INFO] [stdout] ... | [INFO] [stdout] 37 | | terminal, [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_dashboard/collection_dashboard.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 64 | collections: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let mut list_state = CollectionListState::new(collections.clone()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(CollectionDashboard { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | list_state, [INFO] [stdout] 75 | | form_state: FormState::default(), [INFO] [stdout] 76 | | colors, [INFO] [stdout] ... | [INFO] [stdout] 84 | | dry_run, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_dashboard/collection_dashboard.rs:243:31 [INFO] [stdout] | [INFO] [stdout] 235 | let sender_copy = self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | match hac_core::fs::create_collection(name, description, dry_run).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:57:31 [INFO] [stdout] | [INFO] [stdout] 57 | .and_then(|items| items.read().unwrap().first().map(|item| item.get_id())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:88:57 [INFO] [stdout] | [INFO] [stdout] 88 | .get_or_insert_with(|| Arc::new(RwLock::new(vec![]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:117:31 [INFO] [stdout] | [INFO] [stdout] 117 | .and_then(|state| state.borrow().selected_request.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | .map(|state| state.borrow().focused_pane) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:130:26 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|state| state.borrow().selected_pane) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:137:31 [INFO] [stdout] | [INFO] [stdout] 137 | .and_then(|state| state.borrow().hovered_request.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|state| state.borrow().collection.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:149:26 [INFO] [stdout] | [INFO] [stdout] 149 | .map(|state| state.borrow().dirs_expanded.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:161:31 [INFO] [stdout] | [INFO] [stdout] 161 | .and_then(|state| state.borrow_mut().overlay_stack.pop()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:167:31 [INFO] [stdout] | [INFO] [stdout] 167 | .and_then(|state| state.borrow().overlay_stack.last().cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | .map(|state| !state.borrow().overlay_stack.is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:199:34 [INFO] [stdout] | [INFO] [stdout] 199 | .is_some_and(|state| state.borrow().has_pending_request) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:369:5 [INFO] [stdout] | [INFO] [stdout] 354 | let mut path = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | path.pop() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_store.rs:388:5 [INFO] [stdout] | [INFO] [stdout] 380 | let mut path = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | found.then(|| path.pop()).flatten() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 442 | requests: Option>>>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | level: usize, [INFO] [stdout] 444 | selected_request: Option>>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | / requests [INFO] [stdout] 450 | | .unwrap_or(Arc::new(RwLock::new(vec![]))) [INFO] [stdout] 451 | | .read() [INFO] [stdout] 452 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/create_request_form.rs:46:30 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | parent_selector: SelectRequestParent::new(colors, collection_store.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/create_request_form.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | request: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/edit_request_form.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | request: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let store = collection_store.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let Some(collection) = store.get_collection() else { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let collection = collection.borrow(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | parent_selector: SelectRequestParent::new(colors, collection_store.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/edit_request_form.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | request: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let store = collection_store.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let Some(collection) = store.get_collection() else { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let collection = collection.borrow(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | request: Some(request), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen_manager.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 52 | collections: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | curr_screen: Screens::CollectionDashboard, [INFO] [stdout] 58 | | prev_screen: Screens::CollectionDashboard, [INFO] [stdout] 59 | | collection_viewer: None, [INFO] [stdout] ... | [INFO] [stdout] 67 | | dry_run, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_viewer.rs:130:36 [INFO] [stdout] | [INFO] [stdout] 100 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let (request_tx, response_rx) = unbounded_channel::(); [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | let sidebar = sidebar::Sidebar::new(colors, collection_store.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let request_editor = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let response_viewer = ResponseViewer::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let request_uri = RequestUri::new(colors, collection_store.clone(), layout.req_uri); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | global_command_sender: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_viewer.rs:132:28 [INFO] [stdout] | [INFO] [stdout] 100 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let (request_tx, response_rx) = unbounded_channel::(); [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | let sidebar = sidebar::Sidebar::new(colors, collection_store.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | let request_editor = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let response_viewer = ResponseViewer::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let request_uri = RequestUri::new(colors, collection_store.clone(), layout.req_uri); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | responses_map: HashMap::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/collection_viewer.rs:244:61 [INFO] [stdout] | [INFO] [stdout] 185 | let sender = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let mut collection = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | match hac_core::fs::sync_collection(collection).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_editor.rs:126:26 [INFO] [stdout] | [INFO] [stdout] 110 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | body_editor: BodyEditor::new( [INFO] [stdout] | __________________________^ [INFO] [stdout] 127 | | colors, [INFO] [stdout] 128 | | config, [INFO] [stdout] 129 | | collection_store.clone(), [INFO] [stdout] 130 | | layout.content_pane, [INFO] [stdout] 131 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_editor.rs:132:29 [INFO] [stdout] | [INFO] [stdout] 110 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | headers_editor: HeadersEditor::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 133 | | colors, [INFO] [stdout] 134 | | collection_store.clone(), [INFO] [stdout] 135 | | layout.content_pane, [INFO] [stdout] 136 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_editor/headers_editor.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 56 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | header_form: HeadersEditorForm::new(colors, collection_store.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/request_uri.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|req| req.read().unwrap().uri.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/response_viewer.rs:321:32 [INFO] [stdout] | [INFO] [stdout] 321 | .is_some_and(|res| res.borrow().is_error) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/response_viewer.rs:333:33 [INFO] [stdout] | [INFO] [stdout] 333 | .is_some_and(|res| !res.borrow().is_error) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar.rs:342:48 [INFO] [stdout] | [INFO] [stdout] 342 | ... .is_some_and(|req| req.read().unwrap().id.eq(&item_id)); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 442 | requests: Option>>>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | level: usize, [INFO] [stdout] 444 | selected_request: Option>>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | / requests [INFO] [stdout] 450 | | .unwrap_or(Arc::new(RwLock::new(vec![]))) [INFO] [stdout] 451 | | .read() [INFO] [stdout] 452 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/create_request_form.rs:46:30 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | parent_selector: SelectRequestParent::new(colors, collection_store.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/create_request_form.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | request: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/edit_request_form.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | request: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let store = collection_store.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let Some(collection) = store.get_collection() else { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let collection = collection.borrow(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | parent_selector: SelectRequestParent::new(colors, collection_store.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pages/collection_viewer/sidebar/edit_request_form.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 40 | collection_store: Rc>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | request: Arc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let store = collection_store.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let Some(collection) = store.get_collection() else { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let collection = collection.borrow(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | request: Some(request), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/screen_manager.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 52 | collections: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | curr_screen: Screens::CollectionDashboard, [INFO] [stdout] 58 | | prev_screen: Screens::CollectionDashboard, [INFO] [stdout] 59 | | collection_viewer: None, [INFO] [stdout] ... | [INFO] [stdout] 67 | | dry_run, [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 33 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hac-client` (lib) due to 34 previous errors [INFO] [stdout] error: aborting due to 33 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hac-client` (lib test) due to 34 previous errors [INFO] running `Command { std: "docker" "inspect" "ec4181524e9169d098799e6906e93552754e51dcd6176b4554f1126e3dbc2ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec4181524e9169d098799e6906e93552754e51dcd6176b4554f1126e3dbc2ad2", kill_on_drop: false }` [INFO] [stdout] ec4181524e9169d098799e6906e93552754e51dcd6176b4554f1126e3dbc2ad2