[INFO] fetching crate h4x_core 0.0.2... [INFO] checking h4x_core-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate h4x_core 0.0.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate h4x_core 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate h4x_core 0.0.2 [INFO] finished tweaking crates.io crate h4x_core 0.0.2 [INFO] tweaked toml for crates.io crate h4x_core 0.0.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a43de14518fad7e375897dee02cd37f87ecf3f778bc6e58895a7b27f720a210f [INFO] running `Command { std: "docker" "start" "-a" "a43de14518fad7e375897dee02cd37f87ecf3f778bc6e58895a7b27f720a210f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a43de14518fad7e375897dee02cd37f87ecf3f778bc6e58895a7b27f720a210f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a43de14518fad7e375897dee02cd37f87ecf3f778bc6e58895a7b27f720a210f", kill_on_drop: false }` [INFO] [stdout] a43de14518fad7e375897dee02cd37f87ecf3f778bc6e58895a7b27f720a210f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1805e0271db0187bcf2d5bd121f393a5bbe7672d66501c3558c73ddfe8fdfbd4 [INFO] running `Command { std: "docker" "start" "-a" "1805e0271db0187bcf2d5bd121f393a5bbe7672d66501c3558c73ddfe8fdfbd4", kill_on_drop: false }` [INFO] [stderr] Checking h4x_core v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `file` is never read [INFO] [stdout] --> src/file/lock.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct LockFile { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 17 | path: String, [INFO] [stdout] 18 | file: File, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/lock.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(path: T) -> io::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | where T: AsRef { [INFO] [stdout] 25 | let file = OpenOptions::new().read(true).write(true).create(true).open(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | path: path.as_ref().to_str().unwrap().to_string(), [INFO] [stdout] 28 | | file, [INFO] [stdout] 29 | | is_locked: false, [INFO] [stdout] 30 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/random_access_file.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn open>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let meta = std::fs::metadata(path.as_ref()).ok(); [INFO] [stdout] 26 | let file = std::fs::OpenOptions::new().create(true).write(true).read(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self::new(file, meta)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h4x_core` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `file` is never read [INFO] [stdout] --> src/file/lock.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct LockFile { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 17 | path: String, [INFO] [stdout] 18 | file: File, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/lock.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(path: T) -> io::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | where T: AsRef { [INFO] [stdout] 25 | let file = OpenOptions::new().read(true).write(true).create(true).open(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | path: path.as_ref().to_str().unwrap().to_string(), [INFO] [stdout] 28 | | file, [INFO] [stdout] 29 | | is_locked: false, [INFO] [stdout] 30 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/random_access_file.rs:27:6 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn open>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let meta = std::fs::metadata(path.as_ref()).ok(); [INFO] [stdout] 26 | let file = std::fs::OpenOptions::new().create(true).write(true).read(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self::new(file, meta)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `h4x_core` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1805e0271db0187bcf2d5bd121f393a5bbe7672d66501c3558c73ddfe8fdfbd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1805e0271db0187bcf2d5bd121f393a5bbe7672d66501c3558c73ddfe8fdfbd4", kill_on_drop: false }` [INFO] [stdout] 1805e0271db0187bcf2d5bd121f393a5bbe7672d66501c3558c73ddfe8fdfbd4