[INFO] fetching crate gw2_taco_parser 0.4.0... [INFO] checking gw2_taco_parser-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gw2_taco_parser 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gw2_taco_parser 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gw2_taco_parser 0.4.0 [INFO] finished tweaking crates.io crate gw2_taco_parser 0.4.0 [INFO] tweaked toml for crates.io crate gw2_taco_parser 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate gw2_taco_parser 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f2fe9c8e9e7d200f5cbff05510c5ddff3193c96b66eb45476d9f0c3686d7f93 [INFO] running `Command { std: "docker" "start" "-a" "5f2fe9c8e9e7d200f5cbff05510c5ddff3193c96b66eb45476d9f0c3686d7f93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f2fe9c8e9e7d200f5cbff05510c5ddff3193c96b66eb45476d9f0c3686d7f93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f2fe9c8e9e7d200f5cbff05510c5ddff3193c96b66eb45476d9f0c3686d7f93", kill_on_drop: false }` [INFO] [stdout] 5f2fe9c8e9e7d200f5cbff05510c5ddff3193c96b66eb45476d9f0c3686d7f93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01b13c2d935488f85a4d374aa733a68ce94b6e286a413039157141f9c32fde6c [INFO] running `Command { std: "docker" "start" "-a" "01b13c2d935488f85a4d374aa733a68ce94b6e286a413039157141f9c32fde6c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.78 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking minimal-lexical v0.1.3 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking serde-xml-rs v0.5.1 [INFO] [stderr] Checking gw2_taco_parser v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/xml_parser.rs:218:33 [INFO] [stdout] | [INFO] [stdout] 218 | let process_poi_closure = | mut acc: HashMap, item: &PoiItems | { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `height_offset` is never read [INFO] [stdout] --> src/xml_parser.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct MarkerCategory { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | height_offset: Option [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MarkerCategory` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `height_offset` is never read [INFO] [stdout] --> src/xml_parser.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 43 | struct POI { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | height_offset: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `POI` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `icon_file` is never read [INFO] [stdout] --> src/xml_parser.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 58 | struct TrailMetadata { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | icon_file: Option [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TrailMetadata` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_to_hashmap` is never used [INFO] [stdout] --> src/xml_parser.rs:100:4 [INFO] [stdout] | [INFO] [stdout] 100 | fn add_to_hashmap(mut acc: HashMap, item: &MarkerCategory, key_prefix: String) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml_parser.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/xml_parser.rs:218:33 [INFO] [stdout] | [INFO] [stdout] 218 | let process_poi_closure = | mut acc: HashMap, item: &PoiItems | { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `height_offset` is never read [INFO] [stdout] --> src/xml_parser.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct MarkerCategory { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 29 | height_offset: Option [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MarkerCategory` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `height_offset` is never read [INFO] [stdout] --> src/xml_parser.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 43 | struct POI { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | height_offset: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `POI` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `icon_file` is never read [INFO] [stdout] --> src/xml_parser.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 58 | struct TrailMetadata { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | icon_file: Option [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TrailMetadata` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_to_hashmap` is never used [INFO] [stdout] --> src/xml_parser.rs:100:4 [INFO] [stdout] | [INFO] [stdout] 100 | fn add_to_hashmap(mut acc: HashMap, item: &MarkerCategory, key_prefix: String) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xml_parser.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gw2_taco_parser` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gw2_taco_parser` (lib) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "01b13c2d935488f85a4d374aa733a68ce94b6e286a413039157141f9c32fde6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01b13c2d935488f85a4d374aa733a68ce94b6e286a413039157141f9c32fde6c", kill_on_drop: false }` [INFO] [stdout] 01b13c2d935488f85a4d374aa733a68ce94b6e286a413039157141f9c32fde6c