[INFO] fetching crate gvfs 0.1.2... [INFO] checking gvfs-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gvfs 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gvfs 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gvfs 0.1.2 [INFO] finished tweaking crates.io crate gvfs 0.1.2 [INFO] tweaked toml for crates.io crate gvfs 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding cargo_metadata v0.14.2 (latest: v0.18.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding directories v2.0.2 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zip v0.5.13 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0c7f42e8bdb6136b021234cfaceed2782ce27238c23b3d7720a02e0cabf6ac8 [INFO] running `Command { std: "docker" "start" "-a" "e0c7f42e8bdb6136b021234cfaceed2782ce27238c23b3d7720a02e0cabf6ac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0c7f42e8bdb6136b021234cfaceed2782ce27238c23b3d7720a02e0cabf6ac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0c7f42e8bdb6136b021234cfaceed2782ce27238c23b3d7720a02e0cabf6ac8", kill_on_drop: false }` [INFO] [stdout] e0c7f42e8bdb6136b021234cfaceed2782ce27238c23b3d7720a02e0cabf6ac8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc6113e54dae32e2ed6b754cc9f9721e65b287824550112ab56e500bc836da08 [INFO] running `Command { std: "docker" "start" "-a" "bc6113e54dae32e2ed6b754cc9f9721e65b287824550112ab56e500bc836da08", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling bytecount v0.6.8 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking skeptic v0.13.7 [INFO] [stderr] Compiling gvfs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | format!("Zip error: {}", e.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | format!("Zip error: {}", e.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `resources_path`, `zip_path`, `user_config_path`, and `user_data_path` are never read [INFO] [stdout] --> src/filesystem.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Filesystem { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 43 | vfs: vfs::OverlayFS, [INFO] [stdout] 44 | resources_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 45 | zip_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 46 | user_config_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | user_data_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Filesystem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:24 [INFO] [stdout] | [INFO] [stdout] 48 | fn from(e: std::io::Error) -> Error { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Error::IOError(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn open>(&mut self, path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | self.vfs.open(path.as_ref()).map(|f| File::VfsFile(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 183 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | / self.vfs [INFO] [stdout] 187 | | .open_options(path.as_ref(), options) [INFO] [stdout] 188 | | .map(|f| File::VfsFile(f)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn create>(&mut self, path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | self.vfs.create(path.as_ref()).map(|f| File::VfsFile(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn is_file>(&self, path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | / self.vfs [INFO] [stdout] 230 | | .metadata(path.as_ref()) [INFO] [stdout] 231 | | .map(|m| m.is_file()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn is_dir>(&self, path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | / self.vfs [INFO] [stdout] 238 | | .metadata(path.as_ref()) [INFO] [stdout] 239 | | .map(|m| m.is_dir()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 249 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | ) -> Result>> { [INFO] [stdout] 251 | let itr = self.vfs.read_dir(path.as_ref())?.map(|fname| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok(Box::new(itr)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | / open_options [INFO] [stdout] 293 | | .to_fs_openoptions() [INFO] [stdout] 294 | | .open(p) [INFO] [stdout] 295 | | .map(|x| Box::new(x) as Box) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:295:22 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | / fs::DirBuilder::new() [INFO] [stdout] 312 | | .recursive(true) [INFO] [stdout] 313 | | .create(p) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | / p.metadata() [INFO] [stdout] 366 | | .map(|m| Box::new(PhysicalMetadata(m)) as Box) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:366:22 [INFO] [stdout] | [INFO] [stdout] 366 | .map(|m| Box::new(PhysicalMetadata(m)) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 390 | let itr = fs::read_dir(p)? [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | Ok(Box::new(itr)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:391:44 [INFO] [stdout] | [INFO] [stdout] 391 | .map(|entry| direntry_to_path(&entry?)) [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:448:13 [INFO] [stdout] | [INFO] [stdout] 433 | let mut tried: Vec<(PathBuf, Error)> = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | Err(Error::ResourceNotFound(errmessage, tried)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:525:12 [INFO] [stdout] | [INFO] [stdout] 519 | let mut v = Vec::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | Ok(Box::new(v.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:614:12 [INFO] [stdout] | [INFO] [stdout] 602 | mut archive: Box, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 614 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 615 | | source, [INFO] [stdout] 616 | | archive: RefCell::new(archive), [INFO] [stdout] 617 | | index: idx, [INFO] [stdout] 618 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:732:12 [INFO] [stdout] | [INFO] [stdout] 727 | let mut stupid_archive_borrow = self.archive [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 730 | let mut f = stupid_archive_borrow.by_name(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | let zipfile = ZipFileWrapper::new(&mut f)?; [INFO] [stdout] 732 | Ok(Box::new(zipfile) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:794:12 [INFO] [stdout] | [INFO] [stdout] 788 | let itr = self [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 794 | Ok(Box::new(itr.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gvfs` (lib) due to 20 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `resources_path`, `zip_path`, `user_config_path`, and `user_data_path` are never read [INFO] [stdout] --> src/filesystem.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Filesystem { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 43 | vfs: vfs::OverlayFS, [INFO] [stdout] 44 | resources_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 45 | zip_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 46 | user_config_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | user_data_path: path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Filesystem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:24 [INFO] [stdout] | [INFO] [stdout] 48 | fn from(e: std::io::Error) -> Error { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Error::IOError(Arc::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 173 | pub fn open>(&mut self, path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | self.vfs.open(path.as_ref()).map(|f| File::VfsFile(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 183 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | / self.vfs [INFO] [stdout] 187 | | .open_options(path.as_ref(), options) [INFO] [stdout] 188 | | .map(|f| File::VfsFile(f)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn create>(&mut self, path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | self.vfs.create(path.as_ref()).map(|f| File::VfsFile(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn is_file>(&self, path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | / self.vfs [INFO] [stdout] 230 | | .metadata(path.as_ref()) [INFO] [stdout] 231 | | .map(|m| m.is_file()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn is_dir>(&self, path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | / self.vfs [INFO] [stdout] 238 | | .metadata(path.as_ref()) [INFO] [stdout] 239 | | .map(|m| m.is_dir()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:254:12 [INFO] [stdout] | [INFO] [stdout] 249 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | ) -> Result>> { [INFO] [stdout] 251 | let itr = self.vfs.read_dir(path.as_ref())?.map(|fname| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | Ok(Box::new(itr)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | / open_options [INFO] [stdout] 293 | | .to_fs_openoptions() [INFO] [stdout] 294 | | .open(p) [INFO] [stdout] 295 | | .map(|x| Box::new(x) as Box) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:295:22 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | / fs::DirBuilder::new() [INFO] [stdout] 312 | | .recursive(true) [INFO] [stdout] 313 | | .create(p) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | / p.metadata() [INFO] [stdout] 366 | | .map(|m| Box::new(PhysicalMetadata(m)) as Box) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:366:22 [INFO] [stdout] | [INFO] [stdout] 366 | .map(|m| Box::new(PhysicalMetadata(m)) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 390 | let itr = fs::read_dir(p)? [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | Ok(Box::new(itr)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:391:44 [INFO] [stdout] | [INFO] [stdout] 391 | .map(|entry| direntry_to_path(&entry?)) [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:448:13 [INFO] [stdout] | [INFO] [stdout] 433 | let mut tried: Vec<(PathBuf, Error)> = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | Err(Error::ResourceNotFound(errmessage, tried)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:525:12 [INFO] [stdout] | [INFO] [stdout] 519 | let mut v = Vec::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | Ok(Box::new(v.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:614:12 [INFO] [stdout] | [INFO] [stdout] 602 | mut archive: Box, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 614 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 615 | | source, [INFO] [stdout] 616 | | archive: RefCell::new(archive), [INFO] [stdout] 617 | | index: idx, [INFO] [stdout] 618 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:732:12 [INFO] [stdout] | [INFO] [stdout] 727 | let mut stupid_archive_borrow = self.archive [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 730 | let mut f = stupid_archive_borrow.by_name(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | let zipfile = ZipFileWrapper::new(&mut f)?; [INFO] [stdout] 732 | Ok(Box::new(zipfile) as Box) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vfs.rs:794:12 [INFO] [stdout] | [INFO] [stdout] 788 | let itr = self [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 794 | Ok(Box::new(itr.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gvfs` (lib test) due to 20 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bc6113e54dae32e2ed6b754cc9f9721e65b287824550112ab56e500bc836da08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc6113e54dae32e2ed6b754cc9f9721e65b287824550112ab56e500bc836da08", kill_on_drop: false }` [INFO] [stdout] bc6113e54dae32e2ed6b754cc9f9721e65b287824550112ab56e500bc836da08